2189544880

Committed 01 Dec 2025 04:20PM UTC coverage: 75.865%. First build

Build # 2189544880

Build Type

push

gitlab-ci

Committed by

michalkopczan

Commit Message

fix: Sanitize Update Module paths - payload_type must not point outside of Update Modules' directory

(cherry picked from commit c76f042b3)

Ticket: MEN-9027
Changelog: Sanitized the payload_type field of Mender artifacts, removing relative paths pointing outside Update Modules directory.

Signed-off-by: Michal Kopczan <michal.kopczan@northern.tech>

Run Details

37 of 54 new or added lines in 7 files covered. (68.52%)

7415 of 9774 relevant lines covered (75.86%)

13875.41 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.89

/src/mender-update/update_module/v3/update_module.cpp

// Copyright 2023 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.

#include <mender-update/update_module/v3/update_module.hpp>

#include <common/events.hpp>
#include <common/error.hpp>
#include <common/expected.hpp>
#include <common/path.hpp>

namespace mender {
namespace update {
namespace update_module {
namespace v3 {

namespace error = mender::common::error;
namespace expected = mender::common::expected;
namespace path = mender::common::path;

static std::string StateString[] = {
        "ProvidePayloadFileSizes",
        "Download",
        "DownloadWithFileSizes",
        "ArtifactInstall",
        "NeedsArtifactReboot",
        "ArtifactReboot",
        "ArtifactCommit",
        "SupportsRollback",
        "ArtifactRollback",
        "ArtifactVerifyReboot",
        "ArtifactRollbackReboot",
        "ArtifactVerifyRollbackReboot",
        "ArtifactFailure",
        "Cleanup"};

std::string StateToString(State state) {
        static_assert(
                sizeof(StateString) / sizeof(*StateString) == static_cast<int>(State::LastState),
                "Make sure to keep State and StateString in sync!");
        return StateString[static_cast<int>(state)];
}

expected::Expected<std::unique_ptr<UpdateModule>> UpdateModule::Create(
        MenderContext &ctx, const string &payload_type) {
        auto update_module_path = path::Join(ctx.GetConfig().paths.GetModulesPath(), payload_type);
        auto exp_path_is_safe =
                path::IsWithinOrEqual(update_module_path, ctx.GetConfig().paths.GetModulesPath());
        if (!exp_path_is_safe.has_value()) {
                return expected::unexpected(exp_path_is_safe.error().WithContext(
                        "Error checking if path is equal to or within directory"));
        }
        if (!exp_path_is_safe.value()) {
                return expected::unexpected(context::MakeError(
                        context::NoSuchUpdateModuleError,
                        "Error creating Update Module: Provided Module path is outside Update Modules directory."));
        }

        return std::unique_ptr<UpdateModule>(new UpdateModule(ctx, payload_type, update_module_path));
}

UpdateModule::UpdateModule(
        MenderContext &ctx, const string &payload_type, string update_module_path) :
        ctx_ {ctx} {
        update_module_path_ = update_module_path;
        update_module_workdir_ =
                path::Join(ctx.GetConfig().paths.GetModulesWorkPath(), "payloads", "0000", "tree");
}

UpdateModule::DownloadData::DownloadData(
        events::EventLoop &event_loop, artifact::Payload &payload) :
        payload_ {payload},
        event_loop_ {event_loop} {
        buffer_.resize(MENDER_BUFSIZE);
}

static expected::ExpectedBool HandleProvidePayloadFileSizesOutput(
        const expected::ExpectedString &exp_output) {
        if (!exp_output) {
                return expected::unexpected(error::Error(exp_output.error()));
        }
        auto &processStdOut = exp_output.value();
        if (processStdOut == "Yes") {
                return true;
        } else if (processStdOut == "No" || processStdOut == "") {
                return false;
        }
        return expected::unexpected(error::Error(
                make_error_condition(errc::protocol_error),
                "Unexpected output from the process for ProvidePayloadFileSizes state: " + processStdOut));
}

expected::ExpectedBool UpdateModule::ProvidePayloadFileSizes() {
        return HandleProvidePayloadFileSizesOutput(CallStateCapture(State::ProvidePayloadFileSizes));
}

error::Error UpdateModule::AsyncProvidePayloadFileSizes(
        events::EventLoop &event_loop, ProvidePayloadFileSizesFinishedHandler handler) {
        return AsyncCallStateCapture(
                event_loop, State::ProvidePayloadFileSizes, [handler](expected::ExpectedString exp_output) {
                        handler(HandleProvidePayloadFileSizesOutput(exp_output));
                });
}

error::Error UpdateModule::Download(artifact::Payload &payload) {
        events::EventLoop event_loop;
        error::Error err;
        AsyncDownload(event_loop, payload, [&event_loop, &err](error::Error inner_err) {
                err = inner_err;
                event_loop.Stop();
        });
        event_loop.Run();
        return err;
}

void UpdateModule::AsyncDownload(
        events::EventLoop &event_loop,
        artifact::Payload &payload,
        UpdateModule::StateFinishedHandler handler) {
        download_ = make_unique<DownloadData>(event_loop, payload);

        download_->download_finished_handler_ = [this, handler](error::Error err) {
                handler(err);
                download_.reset();
        };

        download_->event_loop_.Post([this]() { StartDownloadProcess(); });
}

error::Error UpdateModule::DownloadWithFileSizes(artifact::Payload &payload) {
        events::EventLoop event_loop;
        error::Error err;
        AsyncDownloadWithFileSizes(event_loop, payload, [&event_loop, &err](error::Error inner_err) {
                err = inner_err;
                event_loop.Stop();
        });
        event_loop.Run();
        return err;
}

void UpdateModule::AsyncDownloadWithFileSizes(
        events::EventLoop &event_loop,
        artifact::Payload &payload,
        UpdateModule::StateFinishedHandler handler) {
        download_ = make_unique<DownloadData>(event_loop, payload);
        download_->downloading_with_sizes_ = true;

        download_->download_finished_handler_ = [this, handler](error::Error err) {
                handler(err);
                download_.reset();
        };

        download_->event_loop_.Post([this]() { StartDownloadProcess(); });
}

error::Error UpdateModule::ArtifactInstall() {
        return CallStateNoCapture(State::ArtifactInstall);
}

error::Error UpdateModule::AsyncArtifactInstall(
        events::EventLoop &event_loop, StateFinishedHandler handler) {
        return AsyncCallStateNoCapture(event_loop, State::ArtifactInstall, handler);
}

static ExpectedRebootAction HandleNeedsRebootOutput(const expected::ExpectedString &exp_output) {
        if (!exp_output) {
                return expected::unexpected(error::Error(exp_output.error()));
        }
        auto &processStdOut = exp_output.value();
        if (processStdOut == "Yes") {
                return RebootAction::Yes;
        } else if (processStdOut == "No" || processStdOut == "") {
                return RebootAction::No;
        } else if (processStdOut == "Automatic") {
                return RebootAction::Automatic;
        }
        return expected::unexpected(error::Error(
                make_error_condition(errc::protocol_error),
                "Unexpected output from the process for NeedsReboot state: " + processStdOut));
}

ExpectedRebootAction UpdateModule::NeedsReboot() {
        return HandleNeedsRebootOutput(CallStateCapture(State::NeedsReboot));
}

error::Error UpdateModule::AsyncNeedsReboot(
        events::EventLoop &event_loop, NeedsRebootFinishedHandler handler) {
        return AsyncCallStateCapture(
                event_loop, State::NeedsReboot, [handler](expected::ExpectedString exp_output) {
                        handler(HandleNeedsRebootOutput(exp_output));
                });
}

error::Error UpdateModule::ArtifactReboot() {
        return CallStateNoCapture(State::ArtifactReboot);
}

error::Error UpdateModule::AsyncArtifactReboot(
        events::EventLoop &event_loop, StateFinishedHandler handler) {
        return AsyncCallStateNoCapture(event_loop, State::ArtifactReboot, handler);
}

error::Error UpdateModule::ArtifactCommit() {
        return CallStateNoCapture(State::ArtifactCommit);
}

error::Error UpdateModule::AsyncArtifactCommit(
        events::EventLoop &event_loop, StateFinishedHandler handler) {
        return AsyncCallStateNoCapture(event_loop, State::ArtifactCommit, handler);
}

static expected::ExpectedBool HandleSupportsRollbackOutput(
        const expected::ExpectedString &exp_output) {
        if (!exp_output) {
                return expected::unexpected(error::Error(exp_output.error()));
        }
        auto &processStdOut = exp_output.value();
        if (processStdOut == "Yes") {
                return true;
        } else if (processStdOut == "No" || processStdOut == "") {
                return false;
        }
        return expected::unexpected(error::Error(
                make_error_condition(errc::protocol_error),
                "Unexpected output from the process for SupportsRollback state: " + processStdOut));
}

expected::ExpectedBool UpdateModule::SupportsRollback() {
        return HandleSupportsRollbackOutput(CallStateCapture(State::SupportsRollback));
}

error::Error UpdateModule::AsyncSupportsRollback(
        events::EventLoop &event_loop, SupportsRollbackFinishedHandler handler) {
        return AsyncCallStateCapture(
                event_loop, State::SupportsRollback, [handler](expected::ExpectedString exp_output) {
                        handler(HandleSupportsRollbackOutput(exp_output));
                });
}

error::Error UpdateModule::ArtifactRollback() {
        return CallStateNoCapture(State::ArtifactRollback);
}

error::Error UpdateModule::AsyncArtifactRollback(
        events::EventLoop &event_loop, StateFinishedHandler handler) {
        return AsyncCallStateNoCapture(event_loop, State::ArtifactRollback, handler);
}

error::Error UpdateModule::ArtifactVerifyReboot() {
        return CallStateNoCapture(State::ArtifactVerifyReboot);
}

error::Error UpdateModule::AsyncArtifactVerifyReboot(
        events::EventLoop &event_loop, StateFinishedHandler handler) {
        return AsyncCallStateNoCapture(event_loop, State::ArtifactVerifyReboot, handler);
}

error::Error UpdateModule::ArtifactRollbackReboot() {
        return CallStateNoCapture(State::ArtifactRollbackReboot);
}

error::Error UpdateModule::AsyncArtifactRollbackReboot(
        events::EventLoop &event_loop, StateFinishedHandler handler) {
        return AsyncCallStateNoCapture(event_loop, State::ArtifactRollbackReboot, handler);
}

error::Error UpdateModule::ArtifactVerifyRollbackReboot() {
        return CallStateNoCapture(State::ArtifactVerifyRollbackReboot);
}

error::Error UpdateModule::AsyncArtifactVerifyRollbackReboot(
        events::EventLoop &event_loop, StateFinishedHandler handler) {
        return AsyncCallStateNoCapture(event_loop, State::ArtifactVerifyRollbackReboot, handler);
}

error::Error UpdateModule::ArtifactFailure() {
        return CallStateNoCapture(State::ArtifactFailure);
}

error::Error UpdateModule::AsyncArtifactFailure(
        events::EventLoop &event_loop, StateFinishedHandler handler) {
        return AsyncCallStateNoCapture(event_loop, State::ArtifactFailure, handler);
}

error::Error UpdateModule::Cleanup() {
        return CallStateNoCapture(State::Cleanup);
}

error::Error UpdateModule::AsyncCleanup(
        events::EventLoop &event_loop, StateFinishedHandler handler) {
        return AsyncCallStateNoCapture(event_loop, State::Cleanup, handler);
}

string UpdateModule::GetModulePath() const {
        return update_module_path_;
}

string UpdateModule::GetModulesWorkPath() const {
        return update_module_workdir_;
}

error::Error UpdateModule::GetProcessError(const error::Error &err) {
        if (err.code == make_error_condition(errc::no_such_file_or_directory)) {
                return context::MakeError(context::NoSuchUpdateModuleError, err.message);
        }
        return err;
}

error::Error UpdateModule::AsyncCallStateCapture(
        events::EventLoop &loop, State state, function<void(expected::ExpectedString)> handler) {
        state_runner_.reset(new StateRunner(loop, state, GetModulePath(), GetModulesWorkPath()));

        return state_runner_->AsyncCallState(
                state,
                true,
                chrono::seconds(ctx_.GetConfig().module_timeout_seconds),
                [handler](expected::expected<optional<string>, error::Error> exp_output) {
                        if (!exp_output) {
                                handler(expected::unexpected(exp_output.error()));
                        } else {
                                assert(exp_output.value());
                                handler(exp_output.value().value());
                        }
                });
}

expected::ExpectedString UpdateModule::CallStateCapture(State state) {
        events::EventLoop loop;
        expected::ExpectedString ret;
        auto err = AsyncCallStateCapture(loop, state, [&ret, &loop](expected::ExpectedString str) {
                ret = str;
                loop.Stop();
        });

        if (err != error::NoError) {
                return expected::unexpected(err);
        }

        loop.Run();

        state_runner_.reset();

        return ret;
}

error::Error UpdateModule::AsyncCallStateNoCapture(
        events::EventLoop &loop, State state, function<void(error::Error)> handler) {
        state_runner_.reset(new StateRunner(loop, state, GetModulePath(), GetModulesWorkPath()));

        return state_runner_->AsyncCallState(
                state,
                false,
                chrono::seconds(ctx_.GetConfig().module_timeout_seconds),
                [handler](expected::expected<optional<string>, error::Error> exp_output) {
                        if (!exp_output) {
                                handler(exp_output.error());
                        } else {
                                assert(!exp_output.value());
                                handler(error::NoError);
                        }
                });
}

error::Error UpdateModule::CallStateNoCapture(State state) {
        events::EventLoop loop;
        error::Error err;
        err = AsyncCallStateNoCapture(loop, state, [&err, &loop](error::Error inner_err) {
                err = inner_err;
                loop.Stop();
        });

        if (err != error::NoError) {
                return err;
        }

        loop.Run();

        state_runner_.reset();

        return err;
}

void UpdateModule::SetSystemRebootRunner(unique_ptr<SystemRebootRunner> &&system_reboot_runner) {
        system_reboot_ = std::move(system_reboot_runner);
}

} // namespace v3
} // namespace update_module
} // namespace update
} // namespace mender

1	// Copyright 2023 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14
15	#include <mender-update/update_module/v3/update_module.hpp>
16
17	#include <common/events.hpp>
18	#include <common/error.hpp>
19	#include <common/expected.hpp>
20	#include <common/path.hpp>
21
22	namespace mender {
23	namespace update {
24	namespace update_module {
25	namespace v3 {
26
27	namespace error = mender::common::error;
28	namespace expected = mender::common::expected;
29	namespace path = mender::common::path;
30
31	static std::string StateString[] = {
32	"ProvidePayloadFileSizes",
33	"Download",
34	"DownloadWithFileSizes",
35	"ArtifactInstall",
36	"NeedsArtifactReboot",
37	"ArtifactReboot",
38	"ArtifactCommit",
39	"SupportsRollback",
40	"ArtifactRollback",
41	"ArtifactVerifyReboot",
42	"ArtifactRollbackReboot",
43	"ArtifactVerifyRollbackReboot",
44	"ArtifactFailure",
45	"Cleanup"};
46
47	std::string StateToString(State state) {	2,804✔
48	static_assert(
49	sizeof(StateString) / sizeof(*StateString) == static_cast<int>(State::LastState),
50	"Make sure to keep State and StateString in sync!");
51	return StateString[static_cast<int>(state)];	2,804✔
52	}
53
54	expected::Expected<std::unique_ptr<UpdateModule>> UpdateModule::Create(	196✔
55	MenderContext &ctx, const string &payload_type) {
56	auto update_module_path = path::Join(ctx.GetConfig().paths.GetModulesPath(), payload_type);	392✔
57	auto exp_path_is_safe =
58	path::IsWithinOrEqual(update_module_path, ctx.GetConfig().paths.GetModulesPath());	392✔
59	if (!exp_path_is_safe.has_value()) {	196✔
NEW 60	return expected::unexpected(exp_path_is_safe.error().WithContext(	×
NEW 61	"Error checking if path is equal to or within directory"));	×
62	}
63	if (!exp_path_is_safe.value()) {	196✔
64	return expected::unexpected(context::MakeError(	1✔
65	context::NoSuchUpdateModuleError,
66	"Error creating Update Module: Provided Module path is outside Update Modules directory."));	3✔
67	}
68
69	return std::unique_ptr<UpdateModule>(new UpdateModule(ctx, payload_type, update_module_path));	195✔
70	}
71
72	UpdateModule::UpdateModule(	195✔
73	MenderContext &ctx, const string &payload_type, string update_module_path) :	195✔
74	ctx_ {ctx} {	195✔
75	update_module_path_ = update_module_path;
76	update_module_workdir_ =
77	path::Join(ctx.GetConfig().paths.GetModulesWorkPath(), "payloads", "0000", "tree");	390✔
78	}	195✔
79
80	UpdateModule::DownloadData::DownloadData(	117✔
81	events::EventLoop &event_loop, artifact::Payload &payload) :	117✔
82	payload_ {payload},
83	event_loop_ {event_loop} {	117✔
84	buffer_.resize(MENDER_BUFSIZE);	117✔
85	}	117✔
86
87	static expected::ExpectedBool HandleProvidePayloadFileSizesOutput(	109✔
88	const expected::ExpectedString &exp_output) {
89	if (!exp_output) {	109✔
90	return expected::unexpected(error::Error(exp_output.error()));	3✔
91	}
92	auto &processStdOut = exp_output.value();	108✔
93	if (processStdOut == "Yes") {	108✔
94	return true;
95	} else if (processStdOut == "No" \|\| processStdOut == "") {	105✔
96	return false;
97	}
98	return expected::unexpected(error::Error(	1✔
99	make_error_condition(errc::protocol_error),	2✔
100	"Unexpected output from the process for ProvidePayloadFileSizes state: " + processStdOut));	3✔
101	}
102
103	expected::ExpectedBool UpdateModule::ProvidePayloadFileSizes() {	60✔
104	return HandleProvidePayloadFileSizesOutput(CallStateCapture(State::ProvidePayloadFileSizes));	120✔
105	}
106
107	error::Error UpdateModule::AsyncProvidePayloadFileSizes(	49✔
108	events::EventLoop &event_loop, ProvidePayloadFileSizesFinishedHandler handler) {
109	return AsyncCallStateCapture(
110	event_loop, State::ProvidePayloadFileSizes, [handler](expected::ExpectedString exp_output) {	882✔
111	handler(HandleProvidePayloadFileSizesOutput(exp_output));	49✔
112	});	147✔
113	}
114
115	error::Error UpdateModule::Download(artifact::Payload &payload) {	66✔
116	events::EventLoop event_loop;
117	error::Error err;	66✔
118	AsyncDownload(event_loop, payload, [&event_loop, &err](error::Error inner_err) {	66✔
119	err = inner_err;	66✔
120	event_loop.Stop();	66✔
121	});	×
122	event_loop.Run();	66✔
123	return err;	66✔
124	}
125
126	void UpdateModule::AsyncDownload(	114✔
127	events::EventLoop &event_loop,
128	artifact::Payload &payload,
129	UpdateModule::StateFinishedHandler handler) {
130	download_ = make_unique<DownloadData>(event_loop, payload);	228✔
131
132	download_->download_finished_handler_ = [this, handler](error::Error err) {	228✔
133	handler(err);	228✔
134	download_.reset();
135	};	342✔
136
137	download_->event_loop_.Post([this]() { StartDownloadProcess(); });	228✔
138	}	114✔
139
140	error::Error UpdateModule::DownloadWithFileSizes(artifact::Payload &payload) {	2✔
141	events::EventLoop event_loop;
142	error::Error err;	2✔
143	AsyncDownloadWithFileSizes(event_loop, payload, [&event_loop, &err](error::Error inner_err) {	2✔
144	err = inner_err;	2✔
145	event_loop.Stop();	2✔
146	});	×
147	event_loop.Run();	2✔
148	return err;	2✔
149	}
150
151	void UpdateModule::AsyncDownloadWithFileSizes(	3✔
152	events::EventLoop &event_loop,
153	artifact::Payload &payload,
154	UpdateModule::StateFinishedHandler handler) {
155	download_ = make_unique<DownloadData>(event_loop, payload);	6✔
156	download_->downloading_with_sizes_ = true;	3✔
157
158	download_->download_finished_handler_ = [this, handler](error::Error err) {	6✔
159	handler(err);	6✔
160	download_.reset();
161	};	9✔
162
163	download_->event_loop_.Post([this]() { StartDownloadProcess(); });	6✔
164	}	3✔
165
166	error::Error UpdateModule::ArtifactInstall() {	52✔
167	return CallStateNoCapture(State::ArtifactInstall);	52✔
168	}
169
170	error::Error UpdateModule::AsyncArtifactInstall(	42✔
171	events::EventLoop &event_loop, StateFinishedHandler handler) {
172	return AsyncCallStateNoCapture(event_loop, State::ArtifactInstall, handler);	84✔
173	}
174
175	static ExpectedRebootAction HandleNeedsRebootOutput(const expected::ExpectedString &exp_output) {	122✔
176	if (!exp_output) {	122✔
177	return expected::unexpected(error::Error(exp_output.error()));	9✔
178	}
179	auto &processStdOut = exp_output.value();	119✔
180	if (processStdOut == "Yes") {	119✔
181	return RebootAction::Yes;
182	} else if (processStdOut == "No" \|\| processStdOut == "") {	55✔
183	return RebootAction::No;
184	} else if (processStdOut == "Automatic") {	4✔
185	return RebootAction::Automatic;
186	}
187	return expected::unexpected(error::Error(	1✔
188	make_error_condition(errc::protocol_error),	2✔
189	"Unexpected output from the process for NeedsReboot state: " + processStdOut));	3✔
190	}
191
192	ExpectedRebootAction UpdateModule::NeedsReboot() {	49✔
193	return HandleNeedsRebootOutput(CallStateCapture(State::NeedsReboot));	98✔
194	}
195
196	error::Error UpdateModule::AsyncNeedsReboot(	73✔
197	events::EventLoop &event_loop, NeedsRebootFinishedHandler handler) {
198	return AsyncCallStateCapture(
199	event_loop, State::NeedsReboot, [handler](expected::ExpectedString exp_output) {	1,314✔
200	handler(HandleNeedsRebootOutput(exp_output));	73✔
201	});	219✔
202	}
203
204	error::Error UpdateModule::ArtifactReboot() {	1✔
205	return CallStateNoCapture(State::ArtifactReboot);	1✔
206	}
207
208	error::Error UpdateModule::AsyncArtifactReboot(	26✔
209	events::EventLoop &event_loop, StateFinishedHandler handler) {
210	return AsyncCallStateNoCapture(event_loop, State::ArtifactReboot, handler);	52✔
211	}
212
213	error::Error UpdateModule::ArtifactCommit() {	40✔
214	return CallStateNoCapture(State::ArtifactCommit);	40✔
215	}
216
217	error::Error UpdateModule::AsyncArtifactCommit(	19✔
218	events::EventLoop &event_loop, StateFinishedHandler handler) {
219	return AsyncCallStateNoCapture(event_loop, State::ArtifactCommit, handler);	38✔
220	}
221
222	static expected::ExpectedBool HandleSupportsRollbackOutput(	112✔
223	const expected::ExpectedString &exp_output) {
224	if (!exp_output) {	112✔
225	return expected::unexpected(error::Error(exp_output.error()));	6✔
226	}
227	auto &processStdOut = exp_output.value();	110✔
228	if (processStdOut == "Yes") {	110✔
229	return true;
230	} else if (processStdOut == "No" \|\| processStdOut == "") {	50✔
231	return false;
232	}
233	return expected::unexpected(error::Error(	1✔
234	make_error_condition(errc::protocol_error),	2✔
235	"Unexpected output from the process for SupportsRollback state: " + processStdOut));	3✔
236	}
237
238	expected::ExpectedBool UpdateModule::SupportsRollback() {	67✔
239	return HandleSupportsRollbackOutput(CallStateCapture(State::SupportsRollback));	134✔
240	}
241
242	error::Error UpdateModule::AsyncSupportsRollback(	45✔
243	events::EventLoop &event_loop, SupportsRollbackFinishedHandler handler) {
244	return AsyncCallStateCapture(
245	event_loop, State::SupportsRollback, [handler](expected::ExpectedString exp_output) {	810✔
246	handler(HandleSupportsRollbackOutput(exp_output));	45✔
247	});	135✔
248	}
249
250	error::Error UpdateModule::ArtifactRollback() {	10✔
251	return CallStateNoCapture(State::ArtifactRollback);	10✔
252	}
253
254	error::Error UpdateModule::AsyncArtifactRollback(	41✔
255	events::EventLoop &event_loop, StateFinishedHandler handler) {
256	return AsyncCallStateNoCapture(event_loop, State::ArtifactRollback, handler);	82✔
257	}
258
259	error::Error UpdateModule::ArtifactVerifyReboot() {	1✔
260	return CallStateNoCapture(State::ArtifactVerifyReboot);	1✔
261	}
262
263	error::Error UpdateModule::AsyncArtifactVerifyReboot(	29✔
264	events::EventLoop &event_loop, StateFinishedHandler handler) {
265	return AsyncCallStateNoCapture(event_loop, State::ArtifactVerifyReboot, handler);	58✔
266	}
267
268	error::Error UpdateModule::ArtifactRollbackReboot() {	1✔
269	return CallStateNoCapture(State::ArtifactRollbackReboot);	1✔
270	}
271
272	error::Error UpdateModule::AsyncArtifactRollbackReboot(	57✔
273	events::EventLoop &event_loop, StateFinishedHandler handler) {
274	return AsyncCallStateNoCapture(event_loop, State::ArtifactRollbackReboot, handler);	114✔
275	}
276
277	error::Error UpdateModule::ArtifactVerifyRollbackReboot() {	1✔
278	return CallStateNoCapture(State::ArtifactVerifyRollbackReboot);	1✔
279	}
280
281	error::Error UpdateModule::AsyncArtifactVerifyRollbackReboot(	60✔
282	events::EventLoop &event_loop, StateFinishedHandler handler) {
283	return AsyncCallStateNoCapture(event_loop, State::ArtifactVerifyRollbackReboot, handler);	120✔
284	}
285
286	error::Error UpdateModule::ArtifactFailure() {	18✔
287	return CallStateNoCapture(State::ArtifactFailure);	18✔
288	}
289
290	error::Error UpdateModule::AsyncArtifactFailure(	55✔
291	events::EventLoop &event_loop, StateFinishedHandler handler) {
292	return AsyncCallStateNoCapture(event_loop, State::ArtifactFailure, handler);	110✔
293	}
294
295	error::Error UpdateModule::Cleanup() {	56✔
296	return CallStateNoCapture(State::Cleanup);	56✔
297	}
298
299	error::Error UpdateModule::AsyncCleanup(	82✔
300	events::EventLoop &event_loop, StateFinishedHandler handler) {
301	return AsyncCallStateNoCapture(event_loop, State::Cleanup, handler);	164✔
302	}
303
304	string UpdateModule::GetModulePath() const {	×
305	return update_module_path_;	×
306	}
307
308	string UpdateModule::GetModulesWorkPath() const {	×
309	return update_module_workdir_;	934✔
310	}
311
312	error::Error UpdateModule::GetProcessError(const error::Error &err) {	5✔
313	if (err.code == make_error_condition(errc::no_such_file_or_directory)) {	5✔
314	return context::MakeError(context::NoSuchUpdateModuleError, err.message);	×
315	}
316	return err;	5✔
317	}
318
319	error::Error UpdateModule::AsyncCallStateCapture(	343✔
320	events::EventLoop &loop, State state, function<void(expected::ExpectedString)> handler) {
321	state_runner_.reset(new StateRunner(loop, state, GetModulePath(), GetModulesWorkPath()));	686✔
322
323	return state_runner_->AsyncCallState(
324	state,
325	true,
326	chrono::seconds(ctx_.GetConfig().module_timeout_seconds),	343✔
327	[handler](expected::expected<optional<string>, error::Error> exp_output) {	5,831✔
328	if (!exp_output) {	343✔
329	handler(expected::unexpected(exp_output.error()));	12✔
330	} else {
331	assert(exp_output.value());
332	handler(exp_output.value().value());	674✔
333	}
334	});	686✔
335	}
336
337	expected::ExpectedString UpdateModule::CallStateCapture(State state) {	176✔
338	events::EventLoop loop;
339	expected::ExpectedString ret;
340	auto err = AsyncCallStateCapture(loop, state, [&ret, &loop](expected::ExpectedString str) {	176✔
341	ret = str;
342	loop.Stop();	176✔
343	});	176✔
344
345	if (err != error::NoError) {	176✔
346	return expected::unexpected(err);	×
347	}
348
349	loop.Run();	176✔
350
351	state_runner_.reset();
352
353	return ret;
354	}
355
356	error::Error UpdateModule::AsyncCallStateNoCapture(	591✔
357	events::EventLoop &loop, State state, function<void(error::Error)> handler) {
358	state_runner_.reset(new StateRunner(loop, state, GetModulePath(), GetModulesWorkPath()));	1,182✔
359
360	return state_runner_->AsyncCallState(
361	state,
362	false,
363	chrono::seconds(ctx_.GetConfig().module_timeout_seconds),	591✔
364	[handler](expected::expected<optional<string>, error::Error> exp_output) {	10,030✔
365	if (!exp_output) {	590✔
366	handler(exp_output.error());	120✔
367	} else {
368	assert(!exp_output.value());
369	handler(error::NoError);	1,060✔
370	}
371	});	1,181✔
372	}
373
374	error::Error UpdateModule::CallStateNoCapture(State state) {	180✔
375	events::EventLoop loop;
376	error::Error err;	180✔
377	err = AsyncCallStateNoCapture(loop, state, [&err, &loop](error::Error inner_err) {	180✔
378	err = inner_err;	179✔
379	loop.Stop();	179✔
380	});	180✔
381
382	if (err != error::NoError) {	180✔
383	return err;
384	}
385
386	loop.Run();	179✔
387
388	state_runner_.reset();
389
390	return err;
391	}
392
393	void UpdateModule::SetSystemRebootRunner(unique_ptr<SystemRebootRunner> &&system_reboot_runner) {	3✔
394	system_reboot_ = std::move(system_reboot_runner);
395	}	3✔
396
397	} // namespace v3
398	} // namespace update_module
399	} // namespace update
400	} // namespace mender

mendersoftware / mender / 2189544880

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous