34dcbd97-a3da-420a-b11e-066310a63dda

Committed 01 Dec 2025 07:52PM UTC coverage: 87.656% (-3.7%) from 91.374%

Build # 34dcbd97-a3da-420a-b11e-066310a63dda

Build Type

push

circleci

Committed by

web-flow

Commit Message

Fixed quota display bug on dashboard (#2256)

Closes #2255 

## Local screenshot

<img width="1262" height="488" alt="Screenshot 2025-12-01 at 2 24 43 PM"
src="https://github.com/user-attachments/assets/c339863e-6d08-48f5-90c4-7a8d994fdc92"
/>

Run Details

2805 of 3200 relevant lines covered (87.66%)

359.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.37

/app/models/user.rb

# frozen_string_literal: true

require "csv"
class User < ApplicationRecord
  # Include default devise modules. Others available are:
  # :confirmable, :lockable, :timeoutable, :trackable and :omniauthable
  devise :rememberable, :omniauthable

  has_many :user_requests, dependent: :destroy

  paginates_per 100

  USER_REGISTRATION_LIST = Rails.root.join("data", "user_registration_list_#{Rails.env}.csv")

  attr_accessor :mediaflux_session

  def self.from_cas(access_token)
    user = User.find_by(provider: access_token.provider, uid: access_token.uid)
    if user.present? && user.given_name.nil? # fix any users that do not have the name information loaded
      user.initialize_name_values(access_token.extra)
      user.save
    end
    user
  end

  # Users that can be project sponsors
  def self.sponsor_users
    if Rails.env.development? || Rails.env.staging?
      User.where(eligible_sponsor: true).or(User.where(developer: true))
    else
      User.where(eligible_sponsor: true)
    end
  end

  # Users that can be data managers
  def self.manager_users
    if Rails.env.development? || Rails.env.staging?
      User.where(eligible_manager: true).or(User.where(developer: true))
    else
      User.where(eligible_manager: true)
    end
  end

  def clear_mediaflux_session(session)
    Rails.logger.debug("!!!!!!! Clearing Mediaflux session !!!!!!!!")
    @mediaflux_session = nil
    session[:mediaflux_session] = nil
  end

  def mediaflux_from_session(session)
    logger.debug "Session Get #{session[:mediaflux_session]} cas: #{session[:active_web_user]}  user: #{uid}"
    if session[:mediaflux_session].blank?
      logger.debug("!!!! Creating a new session !!! #{uid}")
      session[:mediaflux_session] = SystemUser.mediaflux_session
      session[:active_web_user] = false
    end
    @active_web_user = session[:active_web_user]
    @mediaflux_session = session[:mediaflux_session]
  end

  def mediaflux_login(token, session)
    logger.debug("mediaflux session created for #{uid}")
    logon_request = Mediaflux::LogonRequest.new(identity_token: token, token_type: "cas")
    if logon_request.error?
      raise "Invalid Logon #{logon_request.response_error}"
    end
    @mediaflux_session = logon_request.session_token
    @active_web_user = true
    session[:mediaflux_session] = @mediaflux_session
    session[:active_web_user] = @active_web_user
    logger.debug "Login Session #{session[:mediaflux_session]} cas: #{session[:active_web_user]}  user: #{uid}"

    User.update_user_roles(user: self)
  end

  def terminate_mediaflux_session
    return if @mediaflux_session.nil? # nothing to terminate
    logger.debug "!!!! Terminating mediaflux session"

    Mediaflux::LogoutRequest.new(session_token: @mediaflux_session).response_body
    @mediaflux_session = nil
  end

  # Initialize the name values from the CAS information.
  # Our name fields do not match their name fields, so we need to translate.
  def initialize_name_values(extra_cas_info)
    self.given_name = extra_cas_info.givenname
    self.family_name =  extra_cas_info.sn
    self.display_name = extra_cas_info.pudisplayname
  end

  # Return the display name and uid if it exists, otherwise return the uid
  # @return [String]
  def display_name_safe
    return uid if given_name.blank? && family_name.blank?
    [given_name, family_name, "(#{uid})"].compact.join(" ")
  end

  # Return the display name only (no uid) if it exists, otherwise return the uid
  # @return [String]
  def display_name_only_safe
    return uid if given_name.blank? && family_name.blank?
    [given_name, family_name].compact.join(" ")
  end

  # Is this user eligible to be a data sponsor in this environment?
  # @return [Boolean]
  def eligible_sponsor?
    return true if developer
    super
  end

  # Is this user eligible to be a data manger in this environment?
  # @return [Boolean]
  def eligible_manager?
    return true if developer
    super
  end

  def developer?
    return true if developer
    super
  end

  # Is this user eligible to be a data user in this environment?
  # @return [Boolean]
  def eligible_data_user?
    return true if developer
    return true if !eligible_sponsor? && !eligible_manager
  end

  # Is this user eligible to be a sysadmin in this environment?
  # @return [Boolean]
  def eligible_sysadmin?
    (!Rails.env.production? && (developer || sysadmin)) || (Rails.env.production? && sysadmin)
  end

  def eligible_to_create_new?
    return true if eligible_sysadmin?

    !Rails.env.production? && (eligible_sponsor? && trainer?)
  end

  # Methods serialize_into_session() and serialize_from_session() are called by Warden/Devise
  # to calculate what information will be stored in the session and to serialize an object
  # back from the session.
  #
  # By default Warden/Devise store the database ID of the record (e.g. User.id) but this causes
  # problems if we repopulate our User table and the IDs change. The implementation provided below
  # uses the User.uid field (which is unique, does not change, and it's required) as the value to
  # store in the session to prevent this issue.
  #
  # References:
  #   https://stackoverflow.com/questions/23597718/what-is-the-warden-data-in-a-rails-devise-session-composed-of/23683925#23683925
  #   https://web.archive.org/web/20211028103224/https://tadas-s.github.io/ruby-on-rails/2020/08/02/devise-serialize-into-session-trick/
  #   https://github.com/wardencommunity/warden/wiki/Setup
  def self.serialize_into_session(record)
    # The return value _must_ have at least two elements since the serialize_from_session() requires
    # two arguments (see below)
    [record.uid, ""]
  end

  def self.serialize_from_session(key, _salt, _opts = {})
    User.where(uid: key)&.first
  end

  # Fetches the most recent download jobs for the user
  def latest_downloads(limit: 10)
    @latest_downloads ||= begin
                            downloads = UserRequest.where(user_id: id).where(["completion_time > ?", 7.days.ago]).order(created_at: "DESC").limit(limit)
                            downloads.map{|download| UserRequestPresenter.new(download)}
                          end
  end

  # Updates the user's roles (sys admin, developer) depending on the information on Mediaflux.
  # This method is meant to be used only for the current logged in user since the roles depend on the Mediaflux session.
  def self.update_user_roles(user:)
    raise "User.update_user_roles called with for a user without a Mediaflux session" if user.mediaflux_session.nil?

    mediaflux_roles = mediaflux_roles(user:)
    update_developer_status(user:, mediaflux_roles:)
    update_sysadmin_status(user:, mediaflux_roles:)
  rescue => ex
    Rails.logger.error("Error updating roles for user (id: #{user.id}) status, error: #{ex.message}")
  end

  # Returns the roles in Mediaflux for the user in the session.
  # This method is meant to be used only for the current logged in user since the roles depend on the Mediaflux session.
  def self.mediaflux_roles(user:)
    raise "User.mediaflux_roles called with for a user without a Mediaflux session" if user.mediaflux_session.nil?

    request = Mediaflux::ActorSelfDescribeRequest.new(session_token: user.mediaflux_session)
    request.resolve
    request.roles
  end

  private

  def self.update_developer_status(user:, mediaflux_roles:)
    # TODO: Figure out why the role name is different in staging from production:
    #   production:   "pu-smb-group:PU:tigerdata:librarydevelopers"
    #   staging:      "pu-oit-group:PU:tigerdata:librarydevelopers"
    #   development:  "pu-lib:developer"
    #   test:         "system-administrator"
    developer_now = mediaflux_roles.include?("pu-smb-group:PU:tigerdata:librarydevelopers") ||
      mediaflux_roles.include?("pu-oit-group:PU:tigerdata:librarydevelopers") ||
      mediaflux_roles.include?("pu-lib:developer") ||
      mediaflux_roles.include?("system-administrator")
    if user.developer != developer_now
      # Only update the record in the database if there is a change
      Rails.logger.info("Updating developer role for user #{user.id} to #{developer_now}")
      user.developer = developer_now
      user.save!
    end
  end

  def self.update_sysadmin_status(user:, mediaflux_roles:)
    sysadmin_now = mediaflux_roles.include?("system-administrator")
    if user.sysadmin != sysadmin_now
      # Only update the record in the database if there is a change
      Rails.logger.info("Updating sysadmin role for user #{user.id} to #{sysadmin_now}")
      user.sysadmin = sysadmin_now
      user.save!
    end
  end
end

1	# frozen_string_literal: true
2
3	require "csv"	4✔
4	class User < ApplicationRecord	4✔
5	# Include default devise modules. Others available are:
6	# :confirmable, :lockable, :timeoutable, :trackable and :omniauthable
7	devise :rememberable, :omniauthable	4✔
8
9	has_many :user_requests, dependent: :destroy	4✔
10
11	paginates_per 100	4✔
12
13	USER_REGISTRATION_LIST = Rails.root.join("data", "user_registration_list_#{Rails.env}.csv")	4✔
14
15	attr_accessor :mediaflux_session	4✔
16
17	def self.from_cas(access_token)	4✔
18	user = User.find_by(provider: access_token.provider, uid: access_token.uid)	9✔
19	if user.present? && user.given_name.nil? # fix any users that do not have the name information loaded	9✔
20	user.initialize_name_values(access_token.extra)	7✔
21	user.save	7✔
22	end
23	user	9✔
24	end
25
26	# Users that can be project sponsors
27	def self.sponsor_users	4✔
28	if Rails.env.development? \|\| Rails.env.staging?	2✔
29	User.where(eligible_sponsor: true).or(User.where(developer: true))	1✔
30	else
31	User.where(eligible_sponsor: true)	1✔
32	end
33	end
34
35	# Users that can be data managers
36	def self.manager_users	4✔
37	if Rails.env.development? \|\| Rails.env.staging?	×
38	User.where(eligible_manager: true).or(User.where(developer: true))	×
39	else
40	User.where(eligible_manager: true)	×
41	end
42	end
43
44	def clear_mediaflux_session(session)	4✔
45	Rails.logger.debug("!!!!!!! Clearing Mediaflux session !!!!!!!!")	3✔
46	@mediaflux_session = nil	3✔
47	session[:mediaflux_session] = nil	3✔
48	end
49
50	def mediaflux_from_session(session)	4✔
51	logger.debug "Session Get #{session[:mediaflux_session]} cas: #{session[:active_web_user]} user: #{uid}"	200✔
52	if session[:mediaflux_session].blank?	200✔
53	logger.debug("!!!! Creating a new session !!! #{uid}")	178✔
54	session[:mediaflux_session] = SystemUser.mediaflux_session	178✔
55	session[:active_web_user] = false	176✔
56	end
57	@active_web_user = session[:active_web_user]	198✔
58	@mediaflux_session = session[:mediaflux_session]	198✔
59	end
60
61	def mediaflux_login(token, session)	4✔
62	logger.debug("mediaflux session created for #{uid}")	×
63	logon_request = Mediaflux::LogonRequest.new(identity_token: token, token_type: "cas")	×
64	if logon_request.error?	×
65	raise "Invalid Logon #{logon_request.response_error}"	×
66	end
67	@mediaflux_session = logon_request.session_token	×
68	@active_web_user = true	×
69	session[:mediaflux_session] = @mediaflux_session	×
70	session[:active_web_user] = @active_web_user	×
71	logger.debug "Login Session #{session[:mediaflux_session]} cas: #{session[:active_web_user]} user: #{uid}"	×
72
73	User.update_user_roles(user: self)	×
74	end
75
76	def terminate_mediaflux_session	4✔
77	return if @mediaflux_session.nil? # nothing to terminate	×
78	logger.debug "!!!! Terminating mediaflux session"	×
79
80	Mediaflux::LogoutRequest.new(session_token: @mediaflux_session).response_body	×
81	@mediaflux_session = nil	×
82	end
83
84	# Initialize the name values from the CAS information.
85	# Our name fields do not match their name fields, so we need to translate.
86	def initialize_name_values(extra_cas_info)	4✔
87	self.given_name = extra_cas_info.givenname	7✔
88	self.family_name = extra_cas_info.sn	7✔
89	self.display_name = extra_cas_info.pudisplayname	7✔
90	end
91
92	# Return the display name and uid if it exists, otherwise return the uid
93	# @return [String]
94	def display_name_safe	4✔
95	return uid if given_name.blank? && family_name.blank?	225✔
96	[given_name, family_name, "(#{uid})"].compact.join(" ")	218✔
97	end
98
99	# Return the display name only (no uid) if it exists, otherwise return the uid
100	# @return [String]
101	def display_name_only_safe	4✔
102	return uid if given_name.blank? && family_name.blank?	2✔
103	[given_name, family_name].compact.join(" ")	2✔
104	end
105
106	# Is this user eligible to be a data sponsor in this environment?
107	# @return [Boolean]
108	def eligible_sponsor?	4✔
109	return true if developer	11✔
110	super	10✔
111	end
112
113	# Is this user eligible to be a data manger in this environment?
114	# @return [Boolean]
115	def eligible_manager?	4✔
116	return true if developer	4✔
117	super	3✔
118	end
119
120	def developer?	4✔
121	return true if developer	2✔
122	super	1✔
123	end
124
125	# Is this user eligible to be a data user in this environment?
126	# @return [Boolean]
127	def eligible_data_user?	4✔
128	return true if developer	3✔
129	return true if !eligible_sponsor? && !eligible_manager	3✔
130	end
131
132	# Is this user eligible to be a sysadmin in this environment?
133	# @return [Boolean]
134	def eligible_sysadmin?	4✔
135	(!Rails.env.production? && (developer \|\| sysadmin)) \|\| (Rails.env.production? && sysadmin)	72✔
136	end
137
138	def eligible_to_create_new?	4✔
139	return true if eligible_sysadmin?	6✔
140
141	!Rails.env.production? && (eligible_sponsor? && trainer?)	4✔
142	end
143
144	# Methods serialize_into_session() and serialize_from_session() are called by Warden/Devise
145	# to calculate what information will be stored in the session and to serialize an object
146	# back from the session.
147	#
148	# By default Warden/Devise store the database ID of the record (e.g. User.id) but this causes
149	# problems if we repopulate our User table and the IDs change. The implementation provided below
150	# uses the User.uid field (which is unique, does not change, and it's required) as the value to
151	# store in the session to prevent this issue.
152	#
153	# References:
154	# https://stackoverflow.com/questions/23597718/what-is-the-warden-data-in-a-rails-devise-session-composed-of/23683925#23683925
155	# https://web.archive.org/web/20211028103224/https://tadas-s.github.io/ruby-on-rails/2020/08/02/devise-serialize-into-session-trick/
156	# https://github.com/wardencommunity/warden/wiki/Setup
157	def self.serialize_into_session(record)	4✔
158	# The return value _must_ have at least two elements since the serialize_from_session() requires
159	# two arguments (see below)
160	[record.uid, ""]	187✔
161	end
162
163	def self.serialize_from_session(key, _salt, _opts = {})	4✔
164	User.where(uid: key)&.first	122✔
165	end
166
167	# Fetches the most recent download jobs for the user
168	def latest_downloads(limit: 10)	4✔
169	@latest_downloads \|\|= begin	6✔
170	downloads = UserRequest.where(user_id: id).where(["completion_time > ?", 7.days.ago]).order(created_at: "DESC").limit(limit)	6✔
171	downloads.map{\|download\| UserRequestPresenter.new(download)}	6✔
172	end
173	end
174
175	# Updates the user's roles (sys admin, developer) depending on the information on Mediaflux.
176	# This method is meant to be used only for the current logged in user since the roles depend on the Mediaflux session.
177	def self.update_user_roles(user:)	4✔
178	raise "User.update_user_roles called with for a user without a Mediaflux session" if user.mediaflux_session.nil?	×
179
180	mediaflux_roles = mediaflux_roles(user:)	×
181	update_developer_status(user:, mediaflux_roles:)	×
182	update_sysadmin_status(user:, mediaflux_roles:)	×
183	rescue => ex
184	Rails.logger.error("Error updating roles for user (id: #{user.id}) status, error: #{ex.message}")	×
185	end
186
187	# Returns the roles in Mediaflux for the user in the session.
188	# This method is meant to be used only for the current logged in user since the roles depend on the Mediaflux session.
189	def self.mediaflux_roles(user:)	4✔
190	raise "User.mediaflux_roles called with for a user without a Mediaflux session" if user.mediaflux_session.nil?	2✔
191
192	request = Mediaflux::ActorSelfDescribeRequest.new(session_token: user.mediaflux_session)	2✔
193	request.resolve	2✔
194	request.roles	2✔
195	end
196
197	private	4✔
198
199	def self.update_developer_status(user:, mediaflux_roles:)	4✔
200	# TODO: Figure out why the role name is different in staging from production:
201	# production: "pu-smb-group:PU:tigerdata:librarydevelopers"
202	# staging: "pu-oit-group:PU:tigerdata:librarydevelopers"
203	# development: "pu-lib:developer"
204	# test: "system-administrator"
205	developer_now = mediaflux_roles.include?("pu-smb-group:PU:tigerdata:librarydevelopers") \|\|	×
206	mediaflux_roles.include?("pu-oit-group:PU:tigerdata:librarydevelopers") \|\|
207	mediaflux_roles.include?("pu-lib:developer") \|\|
208	mediaflux_roles.include?("system-administrator")
209	if user.developer != developer_now	×
210	# Only update the record in the database if there is a change
211	Rails.logger.info("Updating developer role for user #{user.id} to #{developer_now}")	×
212	user.developer = developer_now	×
213	user.save!	×
214	end
215	end
216
217	def self.update_sysadmin_status(user:, mediaflux_roles:)	4✔
218	sysadmin_now = mediaflux_roles.include?("system-administrator")	×
219	if user.sysadmin != sysadmin_now	×
220	# Only update the record in the database if there is a change
221	Rails.logger.info("Updating sysadmin role for user #{user.id} to #{sysadmin_now}")	×
222	user.sysadmin = sysadmin_now	×
223	user.save!	×
224	end
225	end
226	end

pulibrary / tigerdata-app / 34dcbd97-a3da-420a-b11e-066310a63dda

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous