mendersoftware / mender-artifact

76%

master: 76%

LAST BUILD ON BRANCH fix-signature-len-check

branch: fix-signature-len-check

CHANGE BRANCH

x

Reset

• fix-signature-len-check
• 3.10.0-build3
• 3.11.0
• 3.11.0-build1
• 3.11.0-build2
• 3.11.0-build3
• 3.11.0-build4
• 3.11.1
• 3.11.1-build3
• 3.11.1-build4
• 3.11.1-build5
• 3.11.1-build6
• 3.11.2
• 3.11.2-build1
• 3.11.2-build2
• 3.11.3
• 3.11.3-build2
• 3.11.3-build3
• 3.11.3-build4
• 3.11.3-build5
• 3.11.x-fix-ci
• 3.4.1
• 3.4.1-build1
• 3.4.1-build2
• 3.4.2
• 3.4.2-build3
• 3.4.2-build5
• 3.5.0
• 3.5.0-build1
• 3.5.0-build2
• 3.5.1
• 3.5.1-build1
• 3.5.1-build10
• 3.5.1-build11
• 3.5.1-build2
• 3.5.1-build4
• 3.5.1-build6
• 3.5.1-build7
• 3.5.1-build8
• 3.5.1-build9
• 3.5.2
• 3.5.2-build1
• 3.5.2-build2
• 3.5.2-build3
• 3.5.3
• 3.5.3-build1
• 3.5.3-build2
• 3.6.0
• 3.6.0-build1
• 3.6.0-build2
• 3.6.0-build3
• 3.6.0-build4
• 3.6.0-build5
• 3.6.1
• 3.6.1-build1
• 3.6.1-build2
• 3.6.1-build3
• 3.6.1-build4
• 3.6.1-build5
• 3.6.1-build6
• 3.6.1-build7
• 3.6.1-build8
• 3.6.1-build9
• 3.7.0
• 3.7.0-build2
• 3.7.0-build4
• 3.7.0-build8
• 4.0.0
• 4.0.0-build1
• 4.0.0-build2
• 4.0.0-build3
• 4.0.0-build5
• 4.0.0-build6
• 4.0.0-build7
• 4.0.0-build8
• 4.1.0
• 4.1.0-build1
• 4.1.1
• MEN-3410
• MEN-4977
• MEN-7225
• MEN-7876-enable-tty-echo-always
• MEN-8127-add-module-image-progressbar
• MEN-8141-update-go-mod-version
• MEN-8141-update-golang-compat-test
• MEN-8382_mender-artifact_fails_on_calling_mender-update_show-provides
• MEN-8382_new-mender-artifact_fails_on_calling_mender-update_show-provides
• MEN-8428-mender-artifact-does-not-reenable-echo
• MEN-8429_mender-artifact-waits-indefinitely-if-ssh-connection-fails-silently
• MEN-8491-compatible-types
• MEN-8588-artifact-multiple-payloads
• QA-1020-docker-retry
• QA-1166-mender-artifact-ccc-release
• SEC-1676-oauth-jws
• add-docs-release-template
• add-golang-license-template
• artifact-validation
• azure-keyvault
• bump-license
• cherry-3.11.x-MEN-7876-enable-tty-echo-always
• cherry-3.11.x-bump-license
• cherry-4.0.x-MEN-7876-enable-tty-echo-always
• ci-publish-on-tags
• ci-remove-virtual-client-trigger
• ci-sort
• dependabot/docker/alpine-3.21.0
• dependabot/docker/alpine-3.21.2
• dependabot/docker/alpine-3.21.3
• dependabot/docker/alpine-3.22.0
• dependabot/docker/alpine-3.22.1
• dependabot/go_modules/github.com/go-jose/go-jose/v3-3.0.4
• dependabot/go_modules/github.com/golang-jwt/jwt/v5-5.2.2
• dependabot/go_modules/github.com/googleapis/gax-go/v2-2.14.1
• dependabot/go_modules/github.com/klauspost/compress-1.18.0
• dependabot/go_modules/github.com/lestrrat-go/jwx-1.2.31
• dependabot/go_modules/github.com/mendersoftware/progressbar-0.0.3
• dependabot/go_modules/github.com/stretchr/testify-1.11.0
• dependabot/go_modules/github.com/stretchr/testify-1.11.1
• dependabot/go_modules/github.com/ulikunitz/xz-0.5.13
• dependabot/go_modules/github.com/ulikunitz/xz-0.5.14
• dependabot/go_modules/github.com/ulikunitz/xz-0.5.15
• dependabot/go_modules/github.com/urfave/cli-1.22.17
• dependabot/go_modules/golang.org/x/crypto-0.31.0
• dependabot/go_modules/golang.org/x/sys-0.28.0
• dependabot/go_modules/golang.org/x/sys-0.29.0
• dependabot/go_modules/golang.org/x/sys-0.30.0
• dependabot/go_modules/google.golang.org/protobuf-1.36.1
• dependabot/go_modules/google.golang.org/protobuf-1.36.2
• dependabot/go_modules/google.golang.org/protobuf-1.36.3
• dependabot/go_modules/google.golang.org/protobuf-1.36.6
• dependabot/go_modules/google.golang.org/protobuf-1.36.7
• deprecate-ioutils
• feature-partial_updates
• improve-error
• install-brew
• license-header-fixes
• macos-fsck-error
• makefile-unify
• master
• master-brew_build_component
• master-fix_test_mac
• master-glci_brew_install
• master-mac_binaries
• master-mac_unit_tests_e2fsprogs
• mender-artifact
• nil-check
• qa-1017
• release-please--branches--master
• test-homebrew-developer
• travis_and_coveralls
• update-codeowners-20250820-145040

Build # 1676254894

Build Type

Pull #675

gitlab-ci

Committed by jo-lund

Commit Message

fix: Correct the signature length check for ECDSA keys supplied via PKCS#11

An ASN.1 DER encoded signature is specified by RFC 3279 as:
Ecdsa-Sig-Value ::= SEQUENCE  {
    r     INTEGER,
    s     INTEGER
}

ASN.1 gives an overhead of 6 bytes (SEQUENCE and INTEGER tags + length) and
for P-256 "r" and "s" are 32 bytes each. This gives a minimum length of 70
bytes. "r" and "s" should be positive numbers so if the numbers are negative
(msb is 1), the numbers need to be padded, i.e. they will use 33 bytes
instead of 32. This means the encoded signature can be 71 or 72 bytes
depending on padding.

Ticket: MEN-7941
Changelog: Title

Signed-off-by: John Olav Lund <john.olav.lund@northern.tech>

Pull Request Pull Request #675: fix: Correct the signature length check for ECDSA keys supplied via P…

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

5812 of 7608 relevant lines covered (76.39%)

132.67 hits per line