mozilla / fxa-customs-server

95%

master: 95%

LAST BUILD ON BRANCH phil/issue-205-alt

branch: phil/issue-205-alt

CHANGE BRANCH

x

Reset

• phil/issue-205-alt
• add-blocklist-module
• add-debug-support
• add-optional-newrelic
• add-sms-docs
• add-sms-support
• add-totp-rate-limit
• backport
• backport-suspect-requests
• bug-1448854-sms-rate-limit-interval
• changelog
• config-set-merge
• custom-docker-br
• dev-deps-0720
• docker-node-4.8.2
• dockerize
• dockerpush-fix-newrelic-must-be-first
• dockerpush-fix-newrelic-native-needs-build-tools
• dont-log-msg
• extract-update-blocks
• fix-fstat-mtime
• fix-newrelic-must-be-first
• fix-per-ip-rate-limiting
• fix-process-shutdown
• fix-reload-of-nested-settings
• fix-use-node-6.12.3
• fixes-for-node-8
• i12
• i164
• i204
• issue-120-remove-account-lockout
• issue-154-update-contrib-docs
• issue-165-override-blocklist-blocking
• issue-180-add-additional-email-rate-limit
• issue-188-add-sms-block-per-email
• issue-190-fix-sms-rate-limit
• issue-217-allow-test-phone-numbers
• issue-222
• master
• n8
• no-allowed-ips-by-default
• no-merge-config-lists
• node-6.14.0
• node-sec
• node6
• nsp-updates
• pb/bug-1447452
• phil/account-access-fail
• phil/document-memcached
• phil/ffs-failing-test
• phil/issue-201
• phil/issue-205
• phil/issue-205-baby-steps
• private-tag-docs
• pushonempty-rejection
• rate-limit-verify-code
• remove-lockout-leftovers
• reputation-service-moar-logging
• rm-mockmyid
• round-ban-periods-up
• sentry
• shrink-latest
• shrinkwrap-npm
• sms-more-testing
• throw-on-enoent
• train-110
• train-111
• travis-node-8
• unblock
• unblockvs-ip-blocklist
• unref-all-timers
• up-restify
• update-blocklist-level1
• update-newrelic-version
• update-tests
• v0.66.0
• v0.67.0
• v0.68.0
• v0.69.0
• v0.71.0
• v0.72.0
• v0.78.0
• v0.79.0
• v0.80.0
• v1.100.0
• v1.101.0
• v1.102.0
• v1.103.0
• v1.106.0
• v1.108.0
• v1.109.0
• v1.110.0
• v1.112.0
• v1.81.0
• v1.82.0
• v1.83.0
• v1.84.0
• v1.85.0
• v1.86.0
• v1.88.0
• v1.89.0
• v1.90.0
• v1.91.0
• v1.92.0
• v1.98.0

Build # 688

Build Type

push

travis-ci

Committed by philbooth

Commit Message

fix(iprecord): ignore prior rate-limiting for account access actions

Requests to /check with allow-listed email addresses cause the IP record
to to be marked as rate-limited, even though those requests aren't
actually blocked. Any subsequent requests to /checkIpOnly will fetch the
rate-limited IP record from memcached and block the request incorrectly.
This is a problem for the content server functional tests.

The change here ignores any previous rate-limiting for account access
actions, effectively putting them into a separate rate-limiting bucket.

Run Details

397 of 435 branches covered (91.26%)

6 of 6 new or added lines in 1 file covered. (100.0%)

1028 of 1079 relevant lines covered (95.27%)

5535.33 hits per line