mozilla / universal-search-recommendation

100%

master: 100%

LAST BUILD ON BRANCH fix-92-open-connections

branch: fix-92-open-connections

CHANGE BRANCH

x

Reset

• fix-92-open-connections
• 2014.04.27
• 2015.03.30
• 2016-05-27
• 2016.04.07
• 2016.04.14
• 2016.05.03
• 2016.05.03-2
• 2016.05.05
• 2016.05.26
• 2016.07.26
• 2016.09.30
• 35-server-metrics
• 47-circleci-coveralls
• 67-favicon-classifier
• 78-embedly-image
• 79-heartbeat-body
• 80-bing-too-helpful
• 85-cdn-headers
• 86-check-logo
• 92-redis-pools
• bing-env-dist
• celery-3.1.22
• docker-alpine
• docker-tweaks
• dockerflow-update
• master
• movie-followup
• readme-retirement
• readme-update
• req-celery-update
• reqs-celery-3.1.23
• reqs-pylibmc
• reqs-requests-2.10.0
• reqs-werkzeug-0.11.5
• reqs-werkzeug-0.11.9
• reqs-wrapt-1.10.8
• speed-up-circle
• testpilot-badge
• use-yahoo
• waffle-badge

Build # 258

Build Type

push

travis-ci

Committed by mostlygeek

Commit Message

Fix #92 __heartbeat__ opens but never closes connections

This fix uses a shared Celery app instance for testing state of
dependent services. After testing the celery app's
connections are explicitly closed.

Notes on cause:
- the `redis_status()` and `celery_status()` checks create new Celery
  application instances on every test
- the Celery application instances opens up connections to redis but
  these connections are never closed.
- I'm assuming that because the connections are never closed, python
  never GC's them, so they stick around forever

Run Details

16 of 16 new or added lines in 2 files covered. (100.0%)

1486 of 1486 relevant lines covered (100.0%)

1.0 hits per line