pulibrary / orangetheses

86%

main: 86%

LAST BUILD ON BRANCH do-not-run-lando-in-rails

branch: do-not-run-lando-in-rails

CHANGE BRANCH

x

Reset

• do-not-run-lando-in-rails
• 76-check-class-year-v2
• 76-check-for-class-year
• 76-embargoed-no-holdings_1_display
• i72-some-theses-are-not-parsed
• i76-jrgriffiniii-theses
• i81-jrgriffiniii-thesis-json-fails
• i85-jrgriffiniii-index-error
• main
• remove-pry
• remove-pufields-from-indexer
• update_coveralls_gem
• upgrade-ruby-3.1

Build # 436f4ebe-b6cb-4913-9d39-5edf1889c268

Build Type

Pull #91

circleci

Committed by sandbergja

Commit Message

Do not check for lando environment from within a Rails application

Orangetheses checks lando to get information about locally running dev and test solrs.
This is great when developing orangetheses in isolation, however, prior to this commit,
orangetheses also did these checks whenever it was required within a Rails application.
In bibdata, this meant that every time we ran rspec, both bibdata and orangetheses
did a lando check, adding over a second to each rspec run.

This commit keeps the lando check when Orangetheses is on its own, but does not issue
the check if it notices that it is inside a Rails application.

Pull Request Pull Request #91: Do not check for lando environment from within a Rails application

Run Details

624 of 726 relevant lines covered (85.95%)

17.75 hits per line