MushroomObserver / mushroom-observer / 1654

Builds Branch Commit Type Ran Committer Via Coverage
1654 rails-5.2 Delete duplicate #setup_image_dirs Same method existed in test/general_extensions and AjaxControllerTest - DRY code by deleting the method in AjaxControllerTest - Replace nested conditional with guard clause. See https://github.com/rubocop-hq/rub... push JoeCohen travis-ci pending completion   set done
1653 rails-5.2 [Delivers ##163225406] Eliminate secret_token deprecation warning >DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from <top (required)> at /vagrant/mushroom-observ... push JoeCohen travis-ci pending completion   set done
1652 rails-5.2 Update Bundler on Travis Rails 5.2 requires Bundler 2. Otherwise we get this error when starting: ```ruby $ bundle install You must use Bundler 2 or greater with this lockfile. ``` push JoeCohen travis-ci pending completion   set done
1649 rails-5.1 Use Rack::Response test helpers instead of Rails aliases Rails aliases `success?`, `missing?` and `error?` are deprecated in Rails 5.2 This commit will avoid deprecation warnings when we upgrade to 5.2 push JoeCohen travis-ci pending completion   set done
1648 rails-5.1 Revise `altered?` replacement method. - Changed method name to be more consistent with Rails 5.2 methods - Changed last to `changed?` See generally comments to prior commit, #e433d2c push JoeCohen travis-ci pending completion   set done
1647 rails-5.1 Re-commit method to replace `altered?` Same as #868d479 (which had been reverted by #abfc056 in order to resolve merge conflicts) Calling `altered?`, which is a method of the cures_act_as_versioned gem, triggers warning like: ```ruby DEPRECATION... push JoeCohen travis-ci pending completion   set done
1646 rails-5.1 Resolve merge conflicts - Dueling solutions to conflicts triggered by `altered?` - Accepted Nathan's changes push JoeCohen travis-ci pending completion   set done
1645 rails-5.1 Merge branch 'rails-5.1' of github.com:MushroomObserver/mushroom-observer into rails-5.1 push mo-nathan travis-ci pending completion   set done
1644 rails-5.1 Fix deprecation warnings triggered by queued_email/name_change.rb - change `changed?` to `saved_changes?` push JoeCohen travis-ci pending completion   set done
1643 rails-5.1 Fix deprecation warnings in sequence.rb - change `changed?` to `saved_changes?` push JoeCohen travis-ci pending completion   set done
1642 rails-5.1 Fix deprecation warnings caused by MO code in sequence.rb - change `changes` to `saved_changes` push JoeCohen travis-ci pending completion   set done
1641 rails-5.1 Fix deprecation warnings caused by MO code in name_description.rb - change `<attribute>_changed?` to `saved_change_to_<attribute>?` - change `<attribute>_changed` to `saved_change_to_<attribute>` But this file still causes warnings with `altered... push JoeCohen travis-ci pending completion   set done
1640 rails-5.1 Switch from <attribute>_changed? to saved_change_to_<attribute>? push mo-nathan travis-ci pending completion   set done
1639 rails-5.1 Turn on minitest reporters Gives us the progress bar and nicer colorization push JoeCohen travis-ci pending completion   set done
1638 rails-5.1 Update Rails and dependencies push JoeCohen travis-ci pending completion   set done