2175
100%

Ran 19 Sep 2014 03:31PM UTC

Jobs 1

Files 229

Run time 1min

Badge

Embed ▾

pending completion

Build # 2175

Build Type

Pull #2756

travis-ci

Committed by

ubernostrum

Commit Message

Fix bug 986162: Do not allow '@' in new usernames.

This adds the validation to clean_username() on our custom allauth
adapter, ahead of allauth's own default validation (which would allow
the '@'). That validation does two checks:

1. A simple check for the '@' character which, if found, raises a
   custom error message explaining that an email address cannot be
   used as a username.

2. A tweaked version of allauth's own regex-based check, but with a
   regex that does not include '@' and displays an error message which
   does not suggest '@' as a legal character when the username does
   not match.

Testing of this is very light, checking only that clean_username()
does the correct thing and raises errors with the correct
messages. Full integration testing is not currently possible, but
should be added as soon as it becomes possible.

Pull Request Pull Request #2756: Fix bug 986162: Do not allow '@' in new usernames.

Run Details

14035 of 16211 relevant lines covered (86.58%)

0.87 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2175.1 (FORCE_DB=1 PYTHONPATH=. DJANGO_SETTINGS_MODULE=settings_travis)	19 Sep 2014 03:31PM UTC	0	86.58	Travis Job 2175.1

Source Files on build 2175

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

mozilla / kuma / 2175
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2175

mozilla / kuma / 2175 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2175

mozilla / kuma / 2175
100%

README BADGES
x