2001
65%

Ran 14 Nov 2017 06:43AM UTC

Jobs 2

Files 98

Run time 5min

Badge

Embed ▾

pending completion

Build # 2001

Build Type

push

travis-ci

Committed by

Roasbeef

Commit Message

chainntfns: Fix off by 1 block height error

In the historical dispatch of btcdnotify, the dispatcher checks if a
transaction has been included in a block. If this check happens before
the notifier has processed the update, it's possible that the
currentHeight of the notifier and the currentHeight of the chain might
be out of sync which causes an off by one error when calculating a
target height for the transaction confirmation. This change uses the
height of the block the transaction was found in, rather than the
currentHeight that's known by the notifier to eliminate this.

Run Details

13833 of 19143 relevant lines covered (72.26%)

51318.28 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2001.1 (RACE=false)	14 Nov 2017 06:48AM UTC	0	72.26	Travis Job 2001.1
3	2001.3 (RACE=false)	14 Nov 2017 06:43AM UTC	0	72.25	Travis Job 2001.3

Source Files on build 2001

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

lightningnetwork / lnd / 2001
65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2001

lightningnetwork / lnd / 2001 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2001

lightningnetwork / lnd / 2001
65%

README BADGES
x