2502
67%

Ran 09 Jan 2018 04:38AM UTC

Jobs 2

Files 101

Run time 25s

Badge

Embed ▾

pending completion

Build # 2502

Build Type

push

travis-ci

Committed by

Roasbeef

Commit Message

lnwallet: only forward freshly locked in HTLC's in ReceiveRevocation

This commit fixes a nasty bug that has been lingering within lnd, and
has been noticed due to the added retransmission logic. Before this
commit, upon a restart, if we had an active HTLC and received a new
commitment update, then we would re-forward ALL active HTLC’s. This
could at times lead to a nasty cycle:
  * We re-forward an HTLC already processed.
  * We then notice that the time-lock is out of date (retransmitted
HTLC), so we go to fail it.
  * This is detected as a replay attack, so we send an
UpdateMalformedHTLC
  * This second failure ends up creating a nil entry in the log,
leading to a panic.
  * Remote party disconnects.
  * Upon reconnect we send again as we need to retransmit the changes,
this goes on forever.

In order to fix this, we now ensure that we only forward HTLC’s that
have been newly locked in at this next state. With this, we now avoid
the loop described above, and also ensure that we don’t accidentally
attempt an HTLC replay attack on our selves.

Fixes #528.

Fixes #545.

Run Details

15051 of 20683 relevant lines covered (72.77%)

46901.29 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2502.1 (RACE=false)	09 Jan 2018 04:38AM UTC	0	72.77	Travis Job 2502.1
3	2502.3 (RACE=false)	09 Jan 2018 04:38AM UTC	0	72.77	Travis Job 2502.3

Source Files on build 2502

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

lightningnetwork / lnd / 2502
67%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2502

lightningnetwork / lnd / 2502 67%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2502

lightningnetwork / lnd / 2502
67%

README BADGES
x