3820
67%

Ran 03 May 2018 11:18PM UTC

Jobs 2

Files 146

Run time 14min

Badge

Embed ▾

pending completion

Build # 3820

Build Type

push

travis-ci

Committed by

Roasbeef

Commit Message

peer: ensure msgConsumer sets the shutdown variable on exit

In this commit, we fix a bug that could at times cause a deadlock when a
peer is attempting to disconnect. The issue was that when a peer goes to
disconnect, it needs to stop any active msgStream instances. The Stop()
method of the msgStream would block until an atomic variable was set to
indicate that the stream had fully exited. However, in the case that we
disconnected lower in the msgConsumer loop, we would never set the
streamShutdown variable, meaning that msgStream.Stop() would never
unblock.

The fix for this is simple: set the streamShutdown variable within the
quit case of the second select statement in the msgConsumer goroutine.

Run Details

22600 of 42379 relevant lines covered (53.33%)

32417.93 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	3820.1 (RACE=false)	03 May 2018 11:18PM UTC	0	53.32	Travis Job 3820.1
3	3820.3 (RACE=false)	03 May 2018 11:32PM UTC	0	53.37	Travis Job 3820.3

Source Files on build 3820

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

lightningnetwork / lnd / 3820
67%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3820

lightningnetwork / lnd / 3820 67%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3820

lightningnetwork / lnd / 3820
67%

README BADGES
x