MushroomObserver / mushroom-observer / 1779

91%

main: 95%

Pull #452

travis-ci

Improve test coverage of Observation#consensus_naming

The tests did not cover lines 826-827 because the Naming with the highest vote was select'ed first.
```ruby
 806     # First, get the Naming(s) for this Name, if any exists.
 807     matches = namings.select { |n| n.name_id == name_id }
...
 820     # More than one match: take the one with the highest vote.
 821     elsif best_naming = matches.first
 822       best_value = matches.first.vote_cache
 823       matches.each do |naming|
 824         next unless naming.vote_cache > best_value
 825
 826         best_naming = naming
 827         best_value  = naming.vote_cache
 828       end
```
I solved this by making the id of a losing Naming the lowest id, with the result that it's `match.first`.

Hopefully the marginal improvement (2 lines) will make Coveralls happy.

26 of 26 new or added lines in 2 files covered. (100.0%)

19193 of 21003 relevant lines covered (91.38%)

418.87 hits per line