zopefoundation / zope.sendmail / 88
100%
master: 99%

LAST BUILD BRANCH: pep-420-native-namespace
DEFAULT BRANCH: master
Ran
Jobs 7
Files 16
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
88

push

travis-ci

icemac 
<a href="https://github.com/zopefoundation/zope.sendmail/commit/<a class=hub.com/zopefoundation/zope.sendmail/commit/b841d80d7478ab50100e71bba1ae057d929e2b13">b841d80d7<a href="https://github.com/zopefoundation/zope.sendmail/commit/b841d80d7478ab50100e71bba1ae057d929e2b13">&quot;&gt;`Maildir.newMessage` returns a MaildirMessageWriter with a file handle opened
in text mode, see
https://github.com/zopefoundation/zope.sendmail/blob/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/zopefoundation/zope.sendmail/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/zopefoundation/zope.sendmail/commit/<a class=hub.com/zopefoundation/zope.sendmail/commit/2ee8b0a454ff484335e6b65b9d46a695309a2b2f">2ee8b0a45">2ee8b0a45</a><a href="https://github.com/zopefoundation/zope.sendmail/commit/b841d80d7478ab50100e71bba1ae057d929e2b13">/src/zope/sendmail/maildir.py#L110
(mode is &#39;w&#39; not &#39;wb&#39;)

But `MaildirMessageWriter.write` writes bytes to this file handle, see
https://github.com/zopefoundation/zope.sendmail/blob/2ee8b0a454ff484335e6b65b9d46a695309a2b2f/src/zope/sendmail/maildir.py#L131-L132

This commit changes the implementation to use bytes for Python 3.

The change is necessary to get the tests in zopefoundation/Products.MailHost#15 green.

Closes #23. (Which had a different implementation.)</a>

1683 of 1683 relevant lines covered (100.0%)

7.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 88.1 0
100.0
 Travis Job 88.1
2 88.2 0
100.0
 Travis Job 88.2
3 88.3 0
100.0
 Travis Job 88.3
4 88.4 0
100.0
 Travis Job 88.4
5 88.5 0
100.0
 Travis Job 88.5
6 88.6 0
100.0
 Travis Job 88.6
7 88.7 0
100.0
 Travis Job 88.7
Source Files on build 88
Coverage ∆ File Lines Relevant Covered Missed Hits/Line