zopefoundation
/
zope.sendmail
/
89
100%
master: 99%
master: 99%
|
Ran
|
Jobs
7
|
Files
16
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
travis-ci
web-flow`Maildir.newMessage` returns a MaildirMessageWriter with a file handle opened in text mode, see https://github.com/zopefoundation/zope.sendmail/blob/<a class=hub.com/zopefoundation/zope.sendmail/commit/2ee8b0a454ff484335e6b65b9d46a695309a2b2f">2ee8b0a45/src/zope/sendmail/maildir.py#L110 (mode is 'w' not 'wb') But `MaildirMessageWriter.write` writes bytes to this file handle, see https://github.com/zopefoundation/zope.sendmail/blob/2ee8b0a454ff484335e6b65b9d46a695309a2b2f/src/zope/sendmail/maildir.py#L131-L132 This commit changes the implementation to use bytes for Python 3. The change is necessary to get the tests in zopefoundation/Products.MailHost#15 green. Closes #23. (Which had a different implementation.)
2 of 2 new or added lines in 2 files covered. (100.0%)
1683 of 1683 relevant lines covered (100.0%)
7.0 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 89.1 | 0 |
100.0 |
Travis Job 89.1 | |
| 2 | 89.2 | 0 |
100.0 |
Travis Job 89.2 | |
| 3 | 89.3 | 0 |
100.0 |
Travis Job 89.3 | |
| 4 | 89.4 | 0 |
100.0 |
Travis Job 89.4 | |
| 5 | 89.5 | 0 |
100.0 |
Travis Job 89.5 | |
| 6 | 89.6 | 0 |
100.0 |
Travis Job 89.6 | |
| 7 | 89.7 | 0 |
100.0 |
Travis Job 89.7 |
Source Files on build 89
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
|---|