zopefoundation / zope.sendmail / 92

99%

push

travis-ci

<a href="https://github.com/zopefoundation/zope.sendmail/commit/<a class=hub.com/zopefoundation/zope.sendmail/commit/d1fb3c7baa5f1f48d0d0ae217e2f2777fa16d85d">d1fb3c7ba<a href="https://github.com/zopefoundation/zope.sendmail/commit/d1fb3c7baa5f1f48d0d0ae217e2f2777fa16d85d">&quot;&gt;Fix text/bytes issue in MailDir for Python 3 (#24)

* `Maildir.newMessage` returns a MaildirMessageWriter with a file handle opened
in text mode, see
https://github.com/zopefoundation/zope.sendmail/blob/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/zopefoundation/zope.sendmail/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/zopefoundation/zope.sendmail/commit/<a class=hub.com/zopefoundation/zope.sendmail/commit/2ee8b0a454ff484335e6b65b9d46a695309a2b2f">2ee8b0a45">2ee8b0a45</a><a href="https://github.com/zopefoundation/zope.sendmail/commit/d1fb3c7baa5f1f48d0d0ae217e2f2777fa16d85d">/src/zope/sendmail/maildir.py#L110
(mode is &#39;w&#39; not &#39;wb&#39;)

But `MaildirMessageWriter.write` writes bytes to this file handle, see
https://github.com/zopefoundation/zope.sendmail/blob/2ee8b0a454ff484335e6b65b9d46a695309a2b2f/src/zope/sendmail/maildir.py#L131-L132

This commit changes the implementation to use bytes for Python 3.

The change is necessary to get the tests in zopefoundation/Products.MailHost#15 green.</a>

1683 of 1683 relevant lines covered (100.0%)

7.0 hits per line