• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pact-foundation / pact-go / 573
82%
master: 28%

Build:
Build:
LAST BUILD BRANCH: renovate/actions-checkout-6.x
DEFAULT BRANCH: master
Ran 16 Aug 2019 12:30PM UTC
Jobs 2
Files 25
Run time 20s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Aug 2019 12:24PM UTC coverage: 83.025% (+1.4%) from 81.576%
573

push

travis-ci

mefellows
fix(https): enable external https verifications

The local proxy currently assumes that a verification will take place
against either a) a local endpoint or b) an http endpoint. It did not
support external hosts on https.o

It also did not rewrite the Host header correctly (see https://github.com/golang/go/issues/28168)

This change:

1. Rewrites the header during proxying
2. Hard codes the local proxy to run only on http - there is no reason why it should run on https
   even if the endpoint under test _is_.
3. Opens the door for client configured transports during verification,
   to enable self-signed certificates to be easily used

1389 of 1673 relevant lines covered (83.02%)

10.76 hits per line

Jobs
ID Job ID Ran Files Coverage
1 573.1 16 Aug 2019 12:31PM UTC 0
83.02
Travis Job 573.1
2 573.2 16 Aug 2019 12:30PM UTC 0
83.02
Travis Job 573.2
Source Files on build 573
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Travis Build #573
  • 6eacf8ef on github
  • Prev Build on fix/enable-external-https-requests
  • Next Build on fix/enable-external-https-requests (#575)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc