zopefoundation / transaction / 293

100%

master: 100%

Pull #84

travis-ci

Transaction._free drops more references, and Transaction.abort() is a little safer.

Specifically, free the manager and synchronizers, plus a few other
dictionaries that could be arbitrary size and contain arbitrary data.

And abort() always invokes _free() even in the case of exceptions.
commit() still doesn't so that the synchronizers are available for the
expected abort().

But take care about when and how abort frees its manager: not only
does this preserve backwards compatibility, but it lets it be
safe to abort a transaction object more than once. A happy side-effect
of only freeing the manager there is that synchronizers can access
data they set in afterCompletion().

From discussion in #82

93 of 93 new or added lines in 2 files covered. (100.0%)

3456 of 3456 relevant lines covered (100.0%)

6.99 hits per line