2059
92%
main: 95%

Ran 06 Sep 2019 08:42PM UTC

Jobs 1

Files 456

Run time 58s

Badge

Embed ▾

pending completion

Build # 2059

Build Type

Pull #515

travis-ci

Committed by

web-flow

Commit Message

[Fixes #168263064] Fix bugs in edit Naming

EditNaming gave a flash error for existing namings. See https://www.pivotaltracker.com/story/show/168263064.
- Add test
- Fix broken conditionals.
- Trivial RuboCopping

Problem was an incorrect conditional introduced in PR 492, when I refactored FormNameFeedback.
The flash error also was hiding an Error which I introduced at the same time.

Manual Test Script:
- Go to any Observation.
- Propose a New Name.
- After that Naming appears in the Observation, Edit the Naming.
- Result: Edit Proposed Name for Observation _<nnnnnnn>_, **without a flash error or warning**.

Pull Request Pull Request #515: Fix bugs in edit Naming

Run Details

19504 of 21234 relevant lines covered (91.85%)

472.07 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2059.1 (2.4.1)	06 Sep 2019 08:42PM UTC	0	91.85	Travis Job 2059.1

Source Files on build 2059

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

MushroomObserver / mushroom-observer / 2059
92%
main: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2059

MushroomObserver / mushroom-observer / 2059 92% main: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2059

MushroomObserver / mushroom-observer / 2059
92%
main: 95%

README BADGES
x