2212
92%
main: 95%

Ran 26 Apr 2020 08:35PM UTC

Jobs 1

Files 463

Run time 36s

Badge

Embed ▾

pending completion

Build # 2212

Build Type

push

travis-ci

Committed by

JoeCohen

Commit Message

Remove string interpolation inside of path string

The interpolation caused a "Possible command injection" warning from Brakeman.
@mo-nathan noted:
> Brakeman doesn't like string interpolation inside of strings that get used as paths.  In this case the attacker would have to override the value for ::Rails.root which sounds tricky, but who knows.  What it is encouraging you to do is to use File.join rather than string interpolation.  If you replace the assignment of "script" with "script = File.join(::Rails.root, "script", "jpegsize")", I believe the brakeman issue will go away.  Note this is also more portable between operating systems which admittedly is very unlikely in the case of MO, but it is a better way to do thing

Run Details

19663 of 21377 relevant lines covered (91.98%)

474.73 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2212.1 (2.6.6)	26 Apr 2020 08:35PM UTC	0	91.98	Travis Job 2212.1

MushroomObserver / mushroom-observer / 2212
92%
main: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2212

MushroomObserver / mushroom-observer / 2212 92% main: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2212

MushroomObserver / mushroom-observer / 2212
92%
main: 95%

README BADGES
x