mozilla / blurts-server / #10043

29%

main: 19%

push

circleci

Add ability to opt out of pilot (#2427)

* *Note*: contains DB migrations which must be run in order to test, and upon merge / deployment to server

rename previous opt-out modal to manual modal, as it treats manual removal instructions for broker results
create new opt out modal that allows user to opt out of the removal pilot, thus hiding any part of the removal pilot experience from further view
implement this opt out modal trigger both on the enroll screen as well as in the initial data removal signup form (but only when signing up for the first time, not editing info).
handle setting the session variable which allows users to see the removal pilot navigation to false on optout
create a database migration which adds a removal_optout column to the subscribers table - this column will be checked as part of the `checkIfOnRemovalPilotList` function - if the user is on the list but has opted out, the check returns false. This allows us to prevent having to write to the pilot list and re-hash whenever someone opts out.
add an accessibility sr-only button label for all top right modal close buttons.

* add middleware which specifically checks optout status to prevent users from being able to access the remove dashboard by direct url input
add noOptOut check to remove-data and delete-confirmation routes
remove duplicated postRemovalKan controller

fixes from PR review from pdehaan - localization of strings, Opt-Out vs Opt Out consistency, null check on delete response (thanks @pdehaan!)

* oops, stragglers from prev. commit

* changes based on pr feedback from @toufali

281 of 1246 branches covered (22.55%)

Branch coverage included in aggregate %.

33 of 33 new or added lines in 4 files covered. (100.0%)

951 of 3083 relevant lines covered (30.85%)

2.29 hits per line