OCA / server-tools / 1429

69%

9.0: 86%

Pull #349

travis-ci

Fix comparator equals when value is returned as a list.

 * At least with an OpenLDAP server, the values returned are always
   lists even when there is only one value. For example:

	{'cn': ['Carlos Lopez'],
	 'employeeType': ['employee'],
	 'givenName': ['Carlos'],
	 'loginShell': ['/bin/bash'],
	 }

 * Therefore, using the operator 'equals' for 'employeeType' == 'employee'
   will fail because the value is inside a list.

 * This patch checks if the value returned is a list and then picks the
   first field to do the comparision. If there is more than one field
   it returns False (contains should be use instead)

 * If the value returned is not a list then it behaves as before.

8 of 8 new or added lines in 1 file covered. (100.0%)

1787 of 3303 relevant lines covered (54.1%)

1.08 hits per line