1081664682
83%
master: 83%

Ran 22 Nov 2023 02:25PM UTC

Jobs 1

Files 245

Run time 17s

Badge

Embed ▾

Committed 22 Nov 2023 02:11PM UTC coverage: 82.798% (-17.2%) from 99.964%

Build # 1081664682

Build Type

Pull #4214

gitlab-ci

Committed by

tranchitella

Commit Message

fix: Fixed the infinite page redirects when the back button is pressed

Remove the location and navigate from the useLocationParams.setValue callback
dependencies as they change the set function that is presented in other
useEffect dependencies. This happens when the back button is clicked, which
leads to the location changing infinitely.

Changelog: Title
Ticket: MEN-6847
Ticket: MEN-6796

Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Signed-off-by: Fabio Tranchitella <fabio.tranchitella@northern.tech>

Pull Request Pull Request #4214: fix: Fixed the infinite page redirects when the back button is pressed

Run Details

4319 of 6292 branches covered (0.0%)

8332 of 10063 relevant lines covered (82.8%)

191.0 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	98.68	-1.32%	src/js/actions/onboardingActions.js
1	94.44	-5.56%	src/js/components/auditlogs/eventdetails/portforward.js
1	94.74	-5.26%	src/js/components/auditlogs/eventdetails/terminalsession.js
1	95.83	-4.17%	src/js/components/common/forms/filters.js
1	96.3	-3.7%	src/js/components/common/pagination.js
1	97.37	-2.63%	src/js/components/deployments/deploymentitem.js
1	95.65	-4.35%	src/js/components/deployments/deployment-wizard/rolloutsteps.js
1	98.08	-1.92%	src/js/components/devices/device-details/installedsoftware.js
1	95.0	-5.0%	src/js/components/devices/dialogs/preauth-dialog.js
1	83.33	-16.67%	src/js/components/devices/widgets/listoptions.js
1	88.89	-11.11%	src/js/components/header/trialnotification.js
1	85.71	-14.29%	src/js/components/login/signup-steps/userdata-entry.js
1	85.71	-14.29%	src/js/components/releases/dialogs/removeartifact.js
1	88.89	-11.11%	src/js/components/settings/planselection.js
1	95.0	-5.0%	src/js/components/uploads.js
1	91.67	-8.33%	src/js/reducers/onboardingReducer.js
1	93.75	-6.25%	src/js/utils/liststatehook.js
2	86.67	-13.33%	src/js/components/auditlogs/eventdetails/filetransfer.js
2	77.78	-22.22%	src/js/components/auditlogs/eventdetails/userchange.js
2	92.31	-7.69%	src/js/components/common/devicenameinput.js
2	60.0	-40.0%	src/js/components/common/dialogs/confirmdismisshelptips.js
2	88.89	-11.11%	src/js/components/common/enterpriseNotification.js
2	71.43	-28.57%	src/js/components/common/lined-header.js
2	92.0	-8.0%	src/js/components/common/xterm.js
2	94.44	-5.56%	src/js/components/dashboard/devices.js
2	95.74	-4.26%	src/js/components/deployments/deployment-report/devicelist.js
2	90.0	-10.0%	src/js/components/deployments/deployment-report/overview.js
2	96.92	-3.08%	src/js/components/deployments/progressChart.js
2	96.36	-3.64%	src/js/components/devices/base-devices.js
2	93.1	-6.9%	src/js/components/devices/device-details/monitoring.js
2	84.62	-15.38%	src/js/components/devices/groups.js
2	94.44	-5.56%	src/js/components/devices/troubleshoot/terminal.js
2	95.74	-4.26%	src/js/components/devices/widgets/issueselection.js
2	94.29	-5.71%	src/js/components/helptips/baseonboardingtip.js
2	77.78	-22.22%	src/js/components/login/signup-steps/orgdata-entry.js
2	84.62	-15.38%	src/js/components/releases/artifactPayload.js
2	96.0	-4.0%	src/js/components/settings/user-management/userdefinition.js
2	93.55	-6.45%	src/js/components/settings/webhooks/activity.js
2	71.43	-28.57%	src/js/components/settings/webhooks/management.js
2	60.0	-40.0%	src/js/errorboundary.js
2	94.87	-5.13%	src/js/reducers/deviceReducer.js
2	90.91	-9.09%	src/js/reducers/userReducer.js
2	81.82	-18.18%	src/js/utils/deploymentdevicehook.js
3	85.0	-15.0%	src/js/api/general-api.js
3	83.33	-16.67%	src/js/components/auditlogs/eventdetails/deviceconfiguration.js
3	66.67	-33.33%	src/js/components/common/dialogs/log.js
3	88.89	-11.11%	src/js/components/common/search.js
3	91.43	-8.57%	src/js/components/dashboard/deployments.js
3	92.11	-7.89%	src/js/components/dashboard/widgets/chart-addition.js
3	95.45	-4.55%	src/js/components/deployments/inprogressdeployments.js
3	91.89	-8.11%	src/js/components/devices/dialogs/monitordetailsdialog.js
3	91.89	-8.11%	src/js/components/help/help.js
3	78.57	-21.43%	src/js/components/helptips/onboardingcompletetip.js
3	72.73	-27.27%	src/js/components/settings/quoterequestform.js
3	93.18	-6.82%	src/js/constants/userConstants.js
3	0.0	-100.0%	src/js/main.js
4	88.89	-11.11%	src/js/auth.js
4	86.21	-13.79%	src/js/components/common/chipselect.js
4	92.73	-7.27%	src/js/components/common/forms/passwordinput.js
4	73.33	-26.67%	src/js/components/common/sharedsnackbar.js
4	82.61	-17.39%	src/js/components/deployments/deployment-report/deploymentstatus.js
4	87.88	-12.12%	src/js/components/deployments/deployment-report/rolloutschedule.js
4	89.19	-10.81%	src/js/components/deployments/deployment-wizard/rolloutoptions.js
4	77.78	-22.22%	src/js/components/devices/device-details/authsets/authsets.js
4	80.0	-20.0%	src/js/components/devices/device-details/authstatus.js
4	93.33	-6.67%	src/js/components/releases/releases.js
4	90.91	-9.09%	src/js/components/settings/user-management/userform.js
4	98.24	-1.76%	src/js/utils/locationutils.js
5	88.89	-11.11%	src/js/actions/monitorActions.js
5	80.77	-19.23%	src/js/components/common/asyncautocomplete.js
5	86.49	-13.51%	src/js/components/common/mendertooltip.js
5	81.48	-18.52%	src/js/components/dashboard/dashboard.js
5	92.42	-7.58%	src/js/components/helptips/helptooltips.js
5	92.65	-7.35%	src/js/components/releases/dialogs/addartifact.js
5	92.54	-7.46%	src/js/components/settings/accesstokenmanagement.js
5	90.74	-9.26%	src/js/components/settings/artifactgeneration.js
5	88.89	-11.11%	src/js/components/settings/settings.js
6	86.96	-13.04%	src/js/components/common/dialogs/deviceconnectiondialog.js
6	76.0	-24.0%	src/js/components/common/forms/fileupload.js
6	87.5	-12.5%	src/js/components/devices/device-details/deployments.js
6	72.73	-27.27%	src/js/components/devices/widgets/deviceadditionwidget.js
6	80.0	-20.0%	src/js/components/helptips/onboardingtips.js
6	76.92	-23.08%	src/js/components/settings/user-management/twofactorauth-steps/authsetup.js
6	57.14	-42.86%	src/js/components/settings/user-management/twofactorauth-steps/emailverification.js
6	87.5	-12.5%	src/js/components/settings/user-management/usermanagement.js
6	97.21	-2.79%	src/js/selectors/index.js
7	74.07	-25.93%	src/js/components/common/docslink.js
7	61.11	-38.89%	src/js/components/devices/group-management/create-group.js
7	86.27	-13.73%	src/js/components/login/login.js
7	66.67	-33.33%	src/js/components/settings/addonselection.js
7	58.82	-41.18%	src/js/components/settings/organization/organizationpaymentsettings.js
7	83.72	-16.28%	src/js/components/settings/roles.js
7	75.0	-25.0%	src/js/components/settings/webhooks/configuration.js
8	75.76	-24.24%	src/js/components/common/configurationobject.js
8	65.22	-34.78%	src/js/components/common/expandable-attribute.js
8	84.31	-15.69%	src/js/components/common/forms/form.js
8	73.33	-26.67%	src/js/components/common/forms/timeframe-picker.js
8	79.49	-20.51%	src/js/components/settings/organization/samlconfig.js
8	94.12	-5.88%	src/js/components/settings/roledefinition.js
8	71.43	-28.57%	src/js/components/settings/user-management/selfusermanagement.js
9	67.86	-32.14%	src/js/components/auditlogs/eventdetailsdrawer.js
10	91.38	-8.62%	src/js/components/deployments/createdeployment.js
10	47.37	-52.63%	src/js/components/devices/device-details/configimportdialog.js
10	81.48	-18.52%	src/js/components/devices/widgets/attribute-autocomplete.js
10	83.05	-16.95%	src/js/components/header/header.js
10	76.19	-23.81%	src/js/components/settings/organization/billing.js
10	28.57	-71.43%	src/js/utils/retrytimer.js
11	47.62	-52.38%	src/js/components/deployments/deployment-wizard/schedulerollout.js
11	82.54	-17.46%	src/js/components/devices/device-details/connection.js
11	69.44	-30.56%	src/js/components/devices/device-details/devicetags.js
11	81.67	-18.33%	src/js/components/devices/widgets/devicequickactions.js
11	75.56	-24.44%	src/js/components/leftnav.js
11	82.81	-17.19%	src/js/components/releases/artifactdetails.js
11	74.42	-25.58%	src/js/components/settings/webhooks/webhooks.js
12	75.0	-25.0%	src/js/components/common/forms/keyvalueeditor.js
12	85.88	-14.12%	src/js/components/deployments/deployment-report/phaseprogress.js
12	84.62	-15.38%	src/js/components/deployments/deployments.js
12	74.47	-25.53%	src/js/components/releases/releaseslist.js
12	78.57	-21.43%	src/js/components/settings/organization/organization.js
12	70.0	-30.0%	src/js/components/settings/organization/ssoeditor.js
12	60.0	-40.0%	src/js/utils/onboardingmanager.js
13	81.94	-18.06%	src/js/components/deployments/pastdeployments.js
13	72.34	-27.66%	src/js/components/search-result.js
14	83.53	-16.47%	src/js/components/deployments/deployment-wizard/phasesettings.js
14	67.44	-32.56%	src/js/components/devices/troubleshoot/filetransfer.js
14	75.0	-25.0%	src/js/components/login/signup.js
14	94.76	-5.24%	src/js/helpers.js
15	67.39	-32.61%	src/js/components/devices/widgets/filteritem.js
15	70.0	-30.0%	src/js/components/settings/user-management/twofactorauthsetup.js
16	78.67	-21.33%	src/js/components/app.js
16	71.43	-28.57%	src/js/components/common/dialogs/physicaldeviceonboarding.js
16	84.76	-15.24%	src/js/components/devices/devicelist.js
17	82.11	-17.89%	src/js/components/auditlogs/auditlogs.js
17	76.71	-23.29%	src/js/components/auditlogs/auditlogslist.js
17	73.44	-26.56%	src/js/components/dashboard/software-distribution.js
17	71.67	-28.33%	src/js/components/deployments/scheduleddeployments.js
17	61.36	-38.64%	src/js/components/devices/group-management/group-definition.js
17	63.04	-36.96%	src/js/components/settings/upgrade.js
18	85.6	-14.4%	src/js/actions/appActions.js
18	90.43	-9.57%	src/js/actions/deploymentActions.js
18	79.07	-20.93%	src/js/components/devices/expanded-device.js
19	80.0	-20.0%	src/js/components/dashboard/widgets/distribution.js
19	77.11	-22.89%	src/js/components/deployments/deployment-wizard/softwaredevices.js
19	54.76	-45.24%	src/js/tracking.js
20	60.78	-39.22%	src/js/components/devices/widgets/filters.js
20	33.33	-66.67%	src/js/components/settings/cardsection.js
22	87.5	-12.5%	src/js/actions/organizationActions.js
22	71.79	-28.21%	src/js/components/deployments/report.js
22	78.85	-21.15%	src/js/components/settings/integrations.js
24	72.73	-27.27%	src/js/components/settings/global.js
25	75.0	-25.0%	src/js/components/help/downloads.js
25	77.88	-22.12%	src/js/components/releases/releasedetails.js
26	69.77	-30.23%	src/js/components/devices/device-details/devicetwin.js
29	85.13	-14.87%	src/js/actions/releaseActions.js
30	68.75	-31.25%	src/js/components/devices/device-details/authsets/authsetlistitem.js
33	5.71	-94.29%	src/js/components/dashboard/widgets/mapwidget.js
35	7.89	-92.11%	src/js/components/devices/device-details/devicesystem.js
35	59.77	-40.23%	src/js/components/devices/troubleshoot/terminal-wrapper.js
38	47.95	-52.05%	src/js/components/auditlogs/eventdetails/terminalplayer.js
40	88.47	-11.53%	src/js/actions/userActions.js
45	73.84	-26.16%	src/js/components/devices/authorized-devices.js
47	56.88	-43.12%	src/js/components/devices/device-groups.js
49	20.97	-79.03%	src/js/components/dashboard/widgets/map.js
51	61.07	-38.93%	src/js/components/devices/device-details/configuration.js
57	89.95	-10.05%	src/js/actions/deviceActions.js
58	27.5	-72.5%	src/js/utils/sockethook.js

Jobs

ID	Job ID	Ran	Files	Coverage
0	unittests	22 Nov 2023 02:25PM UTC	245	82.8

mendersoftware / gui / 1081664682
83%
master: 83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1081664682

mendersoftware / gui / 1081664682 83% master: 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1081664682

mendersoftware / gui / 1081664682
83%
master: 83%

README BADGES
x