1081664682

Committed 22 Nov 2023 02:11PM UTC coverage: 82.798% (-17.2%) from 99.964%

Build # 1081664682

Build Type

Pull #4214

gitlab-ci

Committed by

tranchitella

Commit Message

fix: Fixed the infinite page redirects when the back button is pressed

Remove the location and navigate from the useLocationParams.setValue callback
dependencies as they change the set function that is presented in other
useEffect dependencies. This happens when the back button is clicked, which
leads to the location changing infinitely.

Changelog: Title
Ticket: MEN-6847
Ticket: MEN-6796

Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Signed-off-by: Fabio Tranchitella <fabio.tranchitella@northern.tech>

Pull Request Pull Request #4214: fix: Fixed the infinite page redirects when the back button is pressed

Run Details

4319 of 6292 branches covered (0.0%)

8332 of 10063 relevant lines covered (82.8%)

191.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.21

/src/js/components/common/chipselect.js

// Copyright 2023 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useState } from 'react';
import { Controller, useFormContext } from 'react-hook-form';

import { Autocomplete, TextField } from '@mui/material';

import { duplicateFilter, unionizeStrings } from '../../helpers';

export const ChipSelect = ({ className = '', name, disabled = false, inputRef, label = '', options = [], placeholder = '' }) => {
  const [value, setValue] = useState('');

  const { control, getValues } = useFormContext();

  // to allow device types to automatically be selected on entered ',' we have to filter the input and transform any completed device types (followed by a ',')
  // while also checking for duplicates and allowing complete resets of the input
  const onTextInputChange = (inputValue, reason, setCurrentSelection) => {
    const value = inputValue || '';
    if (reason === 'clear') {
      setValue('');
      return setCurrentSelection([]);
    } else if (reason === 'reset') {
      return setValue('');
    }
    const lastIndex = value.lastIndexOf(',');
    const possibleSelection = value.substring(0, lastIndex).split(',').filter(duplicateFilter);
    const currentValue = value.substring(lastIndex + 1);
    const selection = getValues(name);
    const nextSelection = unionizeStrings(selection, possibleSelection);
    setValue(currentValue);
    setCurrentSelection(nextSelection);
  };

  const onTextInputLeave = (value, setCurrentSelection) => {
    const selection = getValues(name);
    const nextSelection = unionizeStrings(selection, [value]);
    setCurrentSelection(nextSelection);
    setValue('');
  };

  return (
    <Controller
      control={control}
      name={name}
      render={({ field: { onChange: formOnChange, value: currentSelection, ref, ...props } }) => (
        <Autocomplete
          id={`${name}-chip-select`}
          value={currentSelection}
          className={className}
          filterSelectedOptions
          freeSolo={true}
          includeInputInList={true}
          multiple
          // allow edits to the textinput without deleting existing device types by ignoring backspace
          onChange={(e, value) => (e.key !== 'Backspace' ? formOnChange(value) : null)}
          onInputChange={(e, v, reason) => onTextInputChange(null, reason, formOnChange)}
          options={options}
          readOnly={disabled}
          ref={ref}
          renderInput={params => (
            <TextField
              {...params}
              fullWidth
              inputProps={{ ...params.inputProps, value }}
              InputProps={{ ...params.InputProps, disableUnderline: disabled }}
              key={`${name}-input`}
              label={label}
              onBlur={e => onTextInputLeave(e.target.value, formOnChange)}
              onChange={e => onTextInputChange(e.target.value, 'input', formOnChange)}
              placeholder={currentSelection.length ? '' : placeholder}
              inputRef={inputRef}
            />
          )}
          {...props}
        />
      )}
    />
  );
};

export default ChipSelect;

1	// Copyright 2023 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useState } from 'react';
15	import { Controller, useFormContext } from 'react-hook-form';
16
17	import { Autocomplete, TextField } from '@mui/material';
18
19	import { duplicateFilter, unionizeStrings } from '../../helpers';
20
21	export const ChipSelect = ({ className = '', name, disabled = false, inputRef, label = '', options = [], placeholder = '' }) => {	9!
22	const [value, setValue] = useState('');	166✔
23
24	const { control, getValues } = useFormContext();	166✔
25
26	// to allow device types to automatically be selected on entered ',' we have to filter the input and transform any completed device types (followed by a ',')
27	// while also checking for duplicates and allowing complete resets of the input
28	const onTextInputChange = (inputValue, reason, setCurrentSelection) => {	166✔
29	const value = inputValue \|\| '';	18✔
30	if (reason === 'clear') {	18!
31	setValue('');	×
32	return setCurrentSelection([]);	×
33	} else if (reason === 'reset') {	18!
34	return setValue('');	×
35	}
36	const lastIndex = value.lastIndexOf(',');	18✔
37	const possibleSelection = value.substring(0, lastIndex).split(',').filter(duplicateFilter);	18✔
38	const currentValue = value.substring(lastIndex + 1);	18✔
39	const selection = getValues(name);	18✔
40	const nextSelection = unionizeStrings(selection, possibleSelection);	18✔
41	setValue(currentValue);	18✔
42	setCurrentSelection(nextSelection);	18✔
43	};
44
45	const onTextInputLeave = (value, setCurrentSelection) => {	166✔
46	const selection = getValues(name);	1✔
47	const nextSelection = unionizeStrings(selection, [value]);	1✔
48	setCurrentSelection(nextSelection);	1✔
49	setValue('');	1✔
50	};
51
52	return (	166✔
53	<Controller
54	control={control}
55	name={name}
56	render={({ field: { onChange: formOnChange, value: currentSelection, ref, ...props } }) => (
57	<Autocomplete	179✔
58	id={`${name}-chip-select`}
59	value={currentSelection}
60	className={className}
61	filterSelectedOptions
62	freeSolo={true}
63	includeInputInList={true}
64	multiple
65	// allow edits to the textinput without deleting existing device types by ignoring backspace
66	onChange={(e, value) => (e.key !== 'Backspace' ? formOnChange(value) : null)}	×
67	onInputChange={(e, v, reason) => onTextInputChange(null, reason, formOnChange)}	9✔
68	options={options}
69	readOnly={disabled}
70	ref={ref}
71	renderInput={params => (
72	<TextField	182✔
73	{...params}
74	fullWidth
75	inputProps={{ ...params.inputProps, value }}
76	InputProps={{ ...params.InputProps, disableUnderline: disabled }}
77	key={`${name}-input`}
78	label={label}
79	onBlur={e => onTextInputLeave(e.target.value, formOnChange)}	1✔
80	onChange={e => onTextInputChange(e.target.value, 'input', formOnChange)}	9✔
81	placeholder={currentSelection.length ? '' : placeholder}	182✔
82	inputRef={inputRef}
83	/>
84	)}
85	{...props}
86	/>
87	)}
88	/>
89	);
90	};
91
92	export default ChipSelect;

mendersoftware / gui / 1081664682

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous