1081664682

Committed 22 Nov 2023 02:11PM UTC coverage: 82.798% (-17.2%) from 99.964%

Build # 1081664682

Build Type

Pull #4214

gitlab-ci

Committed by

tranchitella

Commit Message

fix: Fixed the infinite page redirects when the back button is pressed

Remove the location and navigate from the useLocationParams.setValue callback
dependencies as they change the set function that is presented in other
useEffect dependencies. This happens when the back button is clicked, which
leads to the location changing infinitely.

Changelog: Title
Ticket: MEN-6847
Ticket: MEN-6796

Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Signed-off-by: Fabio Tranchitella <fabio.tranchitella@northern.tech>

Pull Request Pull Request #4214: fix: Fixed the infinite page redirects when the back button is pressed

Run Details

4319 of 6292 branches covered (0.0%)

8332 of 10063 relevant lines covered (82.8%)

191.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

65.22

/src/js/components/common/expandable-attribute.js

// Copyright 2019 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useCallback, useEffect, useRef, useState } from 'react';

// material ui
import { FileCopyOutlined as CopyToClipboardIcon } from '@mui/icons-material';
import { ListItem, ListItemText, Tooltip } from '@mui/material';

import copy from 'copy-to-clipboard';

import { toggle } from '../../helpers';

const defaultClasses = { root: 'attributes' };

export const ExpandableAttribute = ({
  className = '',
  copyToClipboard,
  dividerDisabled,
  onExpansion,
  primary,
  secondary,
  secondaryTypographyProps = {},
  setSnackbar,
  style,
  textClasses,
  ...remainder
}) => {
  const textContent = useRef(null);
  const [expanded, setExpanded] = useState(false);
  const [overflowActive, setOverflowActive] = useState(false);
  const [tooltipVisible, setTooltipVisible] = useState(false);

  useEffect(() => {
    if (textContent.current) {
      const overflowActiveCurrently =
        textContent.current.scrollWidth > textContent.current.clientWidth || textContent.current.scrollHeight > textContent.current.clientHeight;
      if (overflowActive !== overflowActiveCurrently && !expanded) {
        setOverflowActive(overflowActiveCurrently);
      }
    }
  }, [expanded, overflowActive, textContent]);

  const onClick = useCallback(() => {
    if (copyToClipboard) {
      // Date/Time components
      copy(secondary);
      setSnackbar('Value copied to clipboard');
    }
    if (!expanded) {
      onExpansion();
    }
    setExpanded(toggle);
  }, [copyToClipboard, expanded, onExpansion, secondary, setSnackbar]);

  const currentTextClasses = `${textClasses ? textClasses.secondary : 'inventory-text'}${expanded && overflowActive ? ' expanded-attribute' : ''}`;
  const secondaryText = (
    <>
      <span className={currentTextClasses} ref={textContent}>
        {secondary}
      </span>{' '}
      {overflowActive ? <a>show {expanded ? 'less' : 'more'}</a> : null}
    </>
  );

  const cssClasses = { ...defaultClasses, root: `${defaultClasses.root} ${copyToClipboard ? 'copy-to-clipboard' : ''}`.trim() };

  return (
    <div className={className} onClick={onClick} onMouseEnter={() => setTooltipVisible(true)} onMouseLeave={() => setTooltipVisible(false)} style={style}>
      <ListItem classes={cssClasses} divider={!dividerDisabled} {...remainder}>
        <ListItemText
          primary={primary}
          secondary={secondaryText}
          secondaryTypographyProps={{ title: secondary, component: 'div', ...secondaryTypographyProps }}
        />
        {copyToClipboard ? (
          <Tooltip title={'Copy to clipboard'} placement="top" open={tooltipVisible}>
            <CopyToClipboardIcon fontSize="small"></CopyToClipboardIcon>
          </Tooltip>
        ) : null}
      </ListItem>
    </div>
  );
};

export default ExpandableAttribute;

1	// Copyright 2019 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useCallback, useEffect, useRef, useState } from 'react';
15
16	// material ui
17	import { FileCopyOutlined as CopyToClipboardIcon } from '@mui/icons-material';
18	import { ListItem, ListItemText, Tooltip } from '@mui/material';
19
20	import copy from 'copy-to-clipboard';
21
22	import { toggle } from '../../helpers';
23
24	const defaultClasses = { root: 'attributes' };	12✔
25
26	export const ExpandableAttribute = ({	12✔
27	className = '',	90✔
28	copyToClipboard,
29	dividerDisabled,
30	onExpansion,
31	primary,
32	secondary,
33	secondaryTypographyProps = {},	189✔
34	setSnackbar,
35	style,
36	textClasses,
37	...remainder
38	}) => {
39	const textContent = useRef(null);	189✔
40	const [expanded, setExpanded] = useState(false);	189✔
41	const [overflowActive, setOverflowActive] = useState(false);	189✔
42	const [tooltipVisible, setTooltipVisible] = useState(false);	189✔
43
44	useEffect(() => {	189✔
45	if (textContent.current) {	26!
46	const overflowActiveCurrently =
47	textContent.current.scrollWidth > textContent.current.clientWidth \|\| textContent.current.scrollHeight > textContent.current.clientHeight;	26✔
48	if (overflowActive !== overflowActiveCurrently && !expanded) {	26!
49	setOverflowActive(overflowActiveCurrently);	×
50	}
51	}
52	}, [expanded, overflowActive, textContent]);
53
54	const onClick = useCallback(() => {	189✔
55	if (copyToClipboard) {	×
56	// Date/Time components
57	copy(secondary);	×
58	setSnackbar('Value copied to clipboard');	×
59	}
60	if (!expanded) {	×
61	onExpansion();	×
62	}
63	setExpanded(toggle);	×
64	}, [copyToClipboard, expanded, onExpansion, secondary, setSnackbar]);
65
66	const currentTextClasses = `${textClasses ? textClasses.secondary : 'inventory-text'}${expanded && overflowActive ? ' expanded-attribute' : ''}`;	189!
67	const secondaryText = (
68	<>	189✔
69	<span className={currentTextClasses} ref={textContent}>
70	{secondary}
71	</span>{' '}
72	{overflowActive ? <a>show {expanded ? 'less' : 'more'}</a> : null}	189!
73	</>
74	);
75
76	const cssClasses = { ...defaultClasses, root: `${defaultClasses.root} ${copyToClipboard ? 'copy-to-clipboard' : ''}`.trim() };	189✔
77
78	return (	189✔
79	<div className={className} onClick={onClick} onMouseEnter={() => setTooltipVisible(true)} onMouseLeave={() => setTooltipVisible(false)} style={style}>	×
80	<ListItem classes={cssClasses} divider={!dividerDisabled} {...remainder}>
81	<ListItemText
82	primary={primary}
83	secondary={secondaryText}
84	secondaryTypographyProps={{ title: secondary, component: 'div', ...secondaryTypographyProps }}
85	/>
86	{copyToClipboard ? (	189✔
87	<Tooltip title={'Copy to clipboard'} placement="top" open={tooltipVisible}>
88	<CopyToClipboardIcon fontSize="small"></CopyToClipboardIcon>
89	</Tooltip>
90	) : null}
91	</ListItem>
92	</div>
93	);
94	};
95
96	export default ExpandableAttribute;

mendersoftware / gui / 1081664682

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous