1081664682

Committed 22 Nov 2023 02:11PM UTC coverage: 82.798% (-17.2%) from 99.964%

Build # 1081664682

Build Type

Pull #4214

gitlab-ci

Committed by

tranchitella

Commit Message

fix: Fixed the infinite page redirects when the back button is pressed

Remove the location and navigate from the useLocationParams.setValue callback
dependencies as they change the set function that is presented in other
useEffect dependencies. This happens when the back button is clicked, which
leads to the location changing infinitely.

Changelog: Title
Ticket: MEN-6847
Ticket: MEN-6796

Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Signed-off-by: Fabio Tranchitella <fabio.tranchitella@northern.tech>

Pull Request Pull Request #4214: fix: Fixed the infinite page redirects when the back button is pressed

Run Details

4319 of 6292 branches covered (0.0%)

8332 of 10063 relevant lines covered (82.8%)

191.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

47.37

/src/js/components/devices/device-details/configimportdialog.js

// Copyright 2021 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useState } from 'react';

// material ui
import { Button, Dialog, DialogActions, DialogContent, DialogTitle, FormControlLabel, FormHelperText, Radio, RadioGroup } from '@mui/material';

import FileUpload from '../../common/forms/fileupload';

export const ConfigImportDialog = ({ onCancel, onSubmit }) => {
  const [config, setConfig] = useState(null);
  const [errortext, setErrortext] = useState();
  const [importType, setImportType] = useState('default');
  const [isSubmitDisabled, setIsSubmitDisabled] = useState(false);

  const onHandleSubmit = () => {
    onSubmit({ importType, config });
  };

  const onFileChange = file => {
    let importedConfig;
    try {
      importedConfig = JSON.parse(file);
    } catch {
      if (file) {
        return setErrortext('Could not parse the selected file, please ensure the validity of the JSON structure.');
      }
    }
    setErrortext();
    setConfig(importedConfig);
    setIsSubmitDisabled(!file);
  };

  return (
    <Dialog open={true}>
      <DialogTitle>Import configuration</DialogTitle>
      <DialogContent className="margin-small" style={{ overflow: 'hidden' }}>
        <RadioGroup
          value={importType}
          onChange={e => {
            setErrortext();
            setIsSubmitDisabled(e.target.value === 'file' && !config);
            setImportType(e.target.value);
          }}
        >
          <FormControlLabel
            control={<Radio size="small" value="default" />}
            name="default"
            label="Import the current default configuration"
            style={{ marginTop: 0 }}
          />
          <div className="margin margin-left-small">or</div>
          <FormControlLabel
            control={<Radio size="small" value="file" />}
            name="file"
            label={
              <FileUpload
                placeholder={
                  <>
                    Drag & drop or <a>select a JSON file</a> to import configuration data
                  </>
                }
                onFileChange={onFileChange}
              />
            }
            style={{ marginTop: 0 }}
          />
          {errortext && <FormHelperText>{errortext}</FormHelperText>}
        </RadioGroup>
      </DialogContent>
      <DialogActions>
        <Button onClick={onCancel}>Cancel</Button>
        <Button variant="contained" disabled={isSubmitDisabled} onClick={onHandleSubmit} color="secondary" style={{ marginLeft: 10 }}>
          Import
        </Button>
      </DialogActions>
    </Dialog>
  );
};

export default ConfigImportDialog;

1	// Copyright 2021 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useState } from 'react';
15
16	// material ui
17	import { Button, Dialog, DialogActions, DialogContent, DialogTitle, FormControlLabel, FormHelperText, Radio, RadioGroup } from '@mui/material';
18
19	import FileUpload from '../../common/forms/fileupload';
20
21	export const ConfigImportDialog = ({ onCancel, onSubmit }) => {	10✔
22	const [config, setConfig] = useState(null);	2✔
23	const [errortext, setErrortext] = useState();	2✔
24	const [importType, setImportType] = useState('default');	2✔
25	const [isSubmitDisabled, setIsSubmitDisabled] = useState(false);	2✔
26
27	const onHandleSubmit = () => {	2✔
28	onSubmit({ importType, config });	1✔
29	};
30
31	const onFileChange = file => {	2✔
32	let importedConfig;
33	try {	×
34	importedConfig = JSON.parse(file);	×
35	} catch {
36	if (file) {	×
37	return setErrortext('Could not parse the selected file, please ensure the validity of the JSON structure.');	×
38	}
39	}
40	setErrortext();	×
41	setConfig(importedConfig);	×
42	setIsSubmitDisabled(!file);	×
43	};
44
45	return (	2✔
46	<Dialog open={true}>
47	<DialogTitle>Import configuration</DialogTitle>
48	<DialogContent className="margin-small" style={{ overflow: 'hidden' }}>
49	<RadioGroup
50	value={importType}
51	onChange={e => {
52	setErrortext();	×
53	setIsSubmitDisabled(e.target.value === 'file' && !config);	×
54	setImportType(e.target.value);	×
55	}}
56	>
57	<FormControlLabel
58	control={<Radio size="small" value="default" />}
59	name="default"
60	label="Import the current default configuration"
61	style={{ marginTop: 0 }}
62	/>
63	<div className="margin margin-left-small">or</div>
64	<FormControlLabel
65	control={<Radio size="small" value="file" />}
66	name="file"
67	label={
68	<FileUpload
69	placeholder={
70	<>
71	Drag & drop or <a>select a JSON file</a> to import configuration data
72	</>
73	}
74	onFileChange={onFileChange}
75	/>
76	}
77	style={{ marginTop: 0 }}
78	/>
79	{errortext && <FormHelperText>{errortext}</FormHelperText>}	2!
80	</RadioGroup>
81	</DialogContent>
82	<DialogActions>
83	<Button onClick={onCancel}>Cancel</Button>
84	<Button variant="contained" disabled={isSubmitDisabled} onClick={onHandleSubmit} color="secondary" style={{ marginLeft: 10 }}>
85	Import
86	</Button>
87	</DialogActions>
88	</Dialog>
89	);
90	};
91
92	export default ConfigImportDialog;

mendersoftware / gui / 1081664682

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous