1081664682

Committed 22 Nov 2023 02:11PM UTC coverage: 82.798% (-17.2%) from 99.964%

Build # 1081664682

Build Type

Pull #4214

gitlab-ci

Committed by

tranchitella

Commit Message

fix: Fixed the infinite page redirects when the back button is pressed

Remove the location and navigate from the useLocationParams.setValue callback
dependencies as they change the set function that is presented in other
useEffect dependencies. This happens when the back button is clicked, which
leads to the location changing infinitely.

Changelog: Title
Ticket: MEN-6847
Ticket: MEN-6796

Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Signed-off-by: Fabio Tranchitella <fabio.tranchitella@northern.tech>

Pull Request Pull Request #4214: fix: Fixed the infinite page redirects when the back button is pressed

Run Details

4319 of 6292 branches covered (0.0%)

8332 of 10063 relevant lines covered (82.8%)

191.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

61.11

/src/js/components/devices/group-management/create-group.js

// Copyright 2016 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useState } from 'react';
import { useSelector } from 'react-redux';

import { Button, Dialog, DialogActions, DialogContent, DialogTitle } from '@mui/material';

import { getGroups, getSelectedGroupInfo } from '../../../selectors';
import GroupDefinition from './group-definition';

export const CreateGroup = ({ addListOfDevices, fromFilters, isCreation, onClose, selectedDevices }) => {
  const isCreationDynamic = isCreation && fromFilters;
  const [invalid, setInvalid] = useState(true);
  const [isModification, setIsModification] = useState(!isCreation);
  const [newGroup, setNewGroup] = useState('');
  const [title, setTitle] = useState(isCreationDynamic ? 'Create a new group' : `Add ${selectedDevices.length ? 'selected ' : ''}devices to group`);

  const { selectedGroup } = useSelector(getSelectedGroupInfo);
  // ensure that existing dynamic groups are only listed if a dynamic group should be created
  const { dynamic, static: staticGroups } = useSelector(getGroups);
  const groups = fromFilters ? [...Object.keys(staticGroups), ...Object.keys(dynamic)] : Object.keys(staticGroups);

  const onNameChange = (isInvalid, newGroupName, isModification) => {
    const title = !isCreationDynamic ? `Add ${selectedDevices.length ? 'selected ' : ''}devices to group` : 'Create a new group';
    setTitle(title);
    setInvalid(isInvalid);
    setIsModification(isModification);
    setNewGroup(newGroupName);
  };

  return (
    <Dialog disableEscapeKeyDown open={true} scroll="paper" fullWidth={true} maxWidth="sm">
      <DialogTitle style={{ paddingBottom: '15px', marginBottom: 0 }}>{title}</DialogTitle>
      <DialogContent className="dialog">
        <GroupDefinition
          groups={groups}
          isCreationDynamic={isCreationDynamic}
          newGroup={newGroup}
          onInputChange={(invalidName, name, isModification) => onNameChange(invalidName, name, isModification)}
          selectedDevices={selectedDevices}
          selectedGroup={selectedGroup}
        />
      </DialogContent>
      <DialogActions style={{ marginTop: 0 }}>
        <Button style={{ marginRight: 10 }} onClick={onClose}>
          Cancel
        </Button>
        <Button variant="contained" color="primary" onClick={() => addListOfDevices(selectedDevices, newGroup)} disabled={!newGroup.length || invalid}>
          {!isModification || isCreationDynamic || groups.length === 0 ? 'Create group' : 'Add to group'}
        </Button>
      </DialogActions>
    </Dialog>
  );
};

export default CreateGroup;

1	// Copyright 2016 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useState } from 'react';
15	import { useSelector } from 'react-redux';
16
17	import { Button, Dialog, DialogActions, DialogContent, DialogTitle } from '@mui/material';
18
19	import { getGroups, getSelectedGroupInfo } from '../../../selectors';
20	import GroupDefinition from './group-definition';
21
22	export const CreateGroup = ({ addListOfDevices, fromFilters, isCreation, onClose, selectedDevices }) => {	4✔
23	const isCreationDynamic = isCreation && fromFilters;	1!
24	const [invalid, setInvalid] = useState(true);	1✔
25	const [isModification, setIsModification] = useState(!isCreation);	1✔
26	const [newGroup, setNewGroup] = useState('');	1✔
27	const [title, setTitle] = useState(isCreationDynamic ? 'Create a new group' : `Add ${selectedDevices.length ? 'selected ' : ''}devices to group`);	1!
28
29	const { selectedGroup } = useSelector(getSelectedGroupInfo);	1✔
30	// ensure that existing dynamic groups are only listed if a dynamic group should be created
31	const { dynamic, static: staticGroups } = useSelector(getGroups);	1✔
32	const groups = fromFilters ? [...Object.keys(staticGroups), ...Object.keys(dynamic)] : Object.keys(staticGroups);	1!
33
34	const onNameChange = (isInvalid, newGroupName, isModification) => {	1✔
35	const title = !isCreationDynamic ? `Add ${selectedDevices.length ? 'selected ' : ''}devices to group` : 'Create a new group';	×
36	setTitle(title);	×
37	setInvalid(isInvalid);	×
38	setIsModification(isModification);	×
39	setNewGroup(newGroupName);	×
40	};
41
42	return (	1✔
43	<Dialog disableEscapeKeyDown open={true} scroll="paper" fullWidth={true} maxWidth="sm">
44	<DialogTitle style={{ paddingBottom: '15px', marginBottom: 0 }}>{title}</DialogTitle>
45	<DialogContent className="dialog">
46	<GroupDefinition
47	groups={groups}
48	isCreationDynamic={isCreationDynamic}
49	newGroup={newGroup}
50	onInputChange={(invalidName, name, isModification) => onNameChange(invalidName, name, isModification)}	×
51	selectedDevices={selectedDevices}
52	selectedGroup={selectedGroup}
53	/>
54	</DialogContent>
55	<DialogActions style={{ marginTop: 0 }}>
56	<Button style={{ marginRight: 10 }} onClick={onClose}>
57	Cancel
58	</Button>
59	<Button variant="contained" color="primary" onClick={() => addListOfDevices(selectedDevices, newGroup)} disabled={!newGroup.length \|\| invalid}>	×
60	{!isModification \|\| isCreationDynamic \|\| groups.length === 0 ? 'Create group' : 'Add to group'}	4!
61	</Button>
62	</DialogActions>
63	</Dialog>
64	);
65	};
66
67	export default CreateGroup;

mendersoftware / gui / 1081664682

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous