1081664682

Committed 22 Nov 2023 02:11PM UTC coverage: 82.798% (-17.2%) from 99.964%

Build # 1081664682

Build Type

Pull #4214

gitlab-ci

Committed by

tranchitella

Commit Message

fix: Fixed the infinite page redirects when the back button is pressed

Remove the location and navigate from the useLocationParams.setValue callback
dependencies as they change the set function that is presented in other
useEffect dependencies. This happens when the back button is clicked, which
leads to the location changing infinitely.

Changelog: Title
Ticket: MEN-6847
Ticket: MEN-6796

Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Signed-off-by: Fabio Tranchitella <fabio.tranchitella@northern.tech>

Pull Request Pull Request #4214: fix: Fixed the infinite page redirects when the back button is pressed

Run Details

4319 of 6292 branches covered (0.0%)

8332 of 10063 relevant lines covered (82.8%)

191.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.72

/src/js/components/settings/roles.js

// Copyright 2020 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.
import React, { useEffect, useMemo, useState } from 'react';
import { useDispatch, useSelector } from 'react-redux';

// material ui
import { Add as AddIcon, ArrowRightAlt as ArrowRightAltIcon } from '@mui/icons-material';
import { Chip } from '@mui/material';

import { getDynamicGroups, getGroups } from '../../actions/deviceActions';
import { createRole, editRole, getRoles, removeRole } from '../../actions/userActions';
import { BENEFITS } from '../../constants/appConstants';
import { emptyRole, rolesById } from '../../constants/userConstants';
import { getFeatures, getGroupsByIdWithoutUngrouped, getIsEnterprise, getReleaseTagsById, getRolesList } from '../../selectors';
import DetailsTable from '../common/detailstable';
import { DocsTooltip } from '../common/docslink';
import EnterpriseNotification from '../common/enterpriseNotification';
import { InfoHintContainer } from '../common/info-hint';
import RoleDefinition from './roledefinition';

const columns = [
  { key: 'name', title: 'Role', render: ({ name }) => name },
  { key: 'description', title: 'Description', render: ({ description }) => description || '-' },
  {
    key: 'manage',
    title: 'Manage',
    render: () => (
      <div className="bold flexbox center-aligned link-color margin-right-small uppercased" style={{ whiteSpace: 'nowrap' }}>
        view details <ArrowRightAltIcon />
      </div>
    )
  }
];

export const RoleManagement = () => {
  const [adding, setAdding] = useState(false);
  const [editing, setEditing] = useState(false);
  const [role, setRole] = useState({ ...emptyRole });
  const dispatch = useDispatch();
  const features = useSelector(getFeatures);
  const groups = useSelector(getGroupsByIdWithoutUngrouped);
  const releaseTags = useSelector(getReleaseTagsById);
  const roles = useSelector(getRolesList);
  const isEnterprise = useSelector(getIsEnterprise);

  useEffect(() => {
    if (Object.keys(groups).length) {
      return;
    }
    dispatch(getDynamicGroups());
    dispatch(getGroups());
    dispatch(getRoles());
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [dispatch, JSON.stringify(groups)]);

  const addRole = () => {
    setAdding(true);
    setEditing(false);
    setRole({ ...emptyRole });
  };

  const onEditRole = editedRole => {
    setAdding(false);
    setEditing(true);
    setRole(editedRole);
  };

  const onCancel = () => {
    setAdding(false);
    setEditing(false);
  };

  const onSubmit = submittedRole => {
    if (adding) {
      dispatch(createRole(submittedRole));
    } else {
      dispatch(editRole(submittedRole));
    }
    onCancel();
  };

  const items = useMemo(
    () =>
      Object.keys(rolesById)
        .reverse()
        .reduce((accu, key) => {
          const index = accu.findIndex(({ id }) => id === key);
          accu = [accu[index], ...accu.filter((item, itemIndex) => index !== itemIndex)];
          return accu;
        }, roles),
    // eslint-disable-next-line react-hooks/exhaustive-deps
    [JSON.stringify(roles)]
  );

  return (
    <div>
      <div className="flexbox center-aligned">
        <h2 style={{ marginLeft: 20 }}>Roles</h2>
        <InfoHintContainer>
          <EnterpriseNotification id={BENEFITS.rbac.id} />
          <DocsTooltip />
        </InfoHintContainer>
      </div>
      <DetailsTable columns={columns} items={items} onItemClick={onEditRole} />
      <Chip color="primary" icon={<AddIcon />} label="Add a role" onClick={addRole} disabled={!isEnterprise} />
      <RoleDefinition
        adding={adding}
        editing={editing}
        features={features}
        onCancel={onCancel}
        onSubmit={onSubmit}
        removeRole={name => dispatch(removeRole(name))}
        selectedRole={role}
        stateGroups={groups}
        stateReleaseTags={releaseTags}
      />
    </div>
  );
};

export default RoleManagement;

1	// Copyright 2020 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	import React, { useEffect, useMemo, useState } from 'react';
15	import { useDispatch, useSelector } from 'react-redux';
16
17	// material ui
18	import { Add as AddIcon, ArrowRightAlt as ArrowRightAltIcon } from '@mui/icons-material';
19	import { Chip } from '@mui/material';
20
21	import { getDynamicGroups, getGroups } from '../../actions/deviceActions';
22	import { createRole, editRole, getRoles, removeRole } from '../../actions/userActions';
23	import { BENEFITS } from '../../constants/appConstants';
24	import { emptyRole, rolesById } from '../../constants/userConstants';
25	import { getFeatures, getGroupsByIdWithoutUngrouped, getIsEnterprise, getReleaseTagsById, getRolesList } from '../../selectors';
26	import DetailsTable from '../common/detailstable';
27	import { DocsTooltip } from '../common/docslink';
28	import EnterpriseNotification from '../common/enterpriseNotification';
29	import { InfoHintContainer } from '../common/info-hint';
30	import RoleDefinition from './roledefinition';
31
32	const columns = [	4✔
33	{ key: 'name', title: 'Role', render: ({ name }) => name },	59✔
34	{ key: 'description', title: 'Description', render: ({ description }) => description \|\| '-' },	59✔
35	{
36	key: 'manage',
37	title: 'Manage',
38	render: () => (
39	<div className="bold flexbox center-aligned link-color margin-right-small uppercased" style={{ whiteSpace: 'nowrap' }}>	59✔
40	view details <ArrowRightAltIcon />
41	</div>
42	)
43	}
44	];
45
46	export const RoleManagement = () => {	4✔
47	const [adding, setAdding] = useState(false);	8✔
48	const [editing, setEditing] = useState(false);	8✔
49	const [role, setRole] = useState({ ...emptyRole });	8✔
50	const dispatch = useDispatch();	8✔
51	const features = useSelector(getFeatures);	8✔
52	const groups = useSelector(getGroupsByIdWithoutUngrouped);	8✔
53	const releaseTags = useSelector(getReleaseTagsById);	8✔
54	const roles = useSelector(getRolesList);	8✔
55	const isEnterprise = useSelector(getIsEnterprise);	8✔
56
57	useEffect(() => {	8✔
58	if (Object.keys(groups).length) {	2!
59	return;	2✔
60	}
61	dispatch(getDynamicGroups());	×
62	dispatch(getGroups());	×
63	dispatch(getRoles());	×
64	// eslint-disable-next-line react-hooks/exhaustive-deps
65	}, [dispatch, JSON.stringify(groups)]);
66
67	const addRole = () => {	8✔
68	setAdding(true);	×
69	setEditing(false);	×
70	setRole({ ...emptyRole });	×
71	};
72
73	const onEditRole = editedRole => {	8✔
74	setAdding(false);	2✔
75	setEditing(true);	2✔
76	setRole(editedRole);	2✔
77	};
78
79	const onCancel = () => {	8✔
80	setAdding(false);	2✔
81	setEditing(false);	2✔
82	};
83
84	const onSubmit = submittedRole => {	8✔
85	if (adding) {	1!
86	dispatch(createRole(submittedRole));	×
87	} else {
88	dispatch(editRole(submittedRole));	1✔
89	}
90	onCancel();	1✔
91	};
92
93	const items = useMemo(	8✔
94	() =>
95	Object.keys(rolesById)	4✔
96	.reverse()
97	.reduce((accu, key) => {
98	const index = accu.findIndex(({ id }) => id === key);	100✔
99	accu = [accu[index], ...accu.filter((item, itemIndex) => index !== itemIndex)];	145✔
100	return accu;	20✔
101	}, roles),
102	// eslint-disable-next-line react-hooks/exhaustive-deps
103	[JSON.stringify(roles)]
104	);
105
106	return (	8✔
107	<div>
108	<div className="flexbox center-aligned">
109	<h2 style={{ marginLeft: 20 }}>Roles</h2>
110	<InfoHintContainer>
111	<EnterpriseNotification id={BENEFITS.rbac.id} />
112	<DocsTooltip />
113	</InfoHintContainer>
114	</div>
115	<DetailsTable columns={columns} items={items} onItemClick={onEditRole} />
116	<Chip color="primary" icon={<AddIcon />} label="Add a role" onClick={addRole} disabled={!isEnterprise} />
117	<RoleDefinition
118	adding={adding}
119	editing={editing}
120	features={features}
121	onCancel={onCancel}
122	onSubmit={onSubmit}
123	removeRole={name => dispatch(removeRole(name))}	1✔
124	selectedRole={role}
125	stateGroups={groups}
126	stateReleaseTags={releaseTags}
127	/>
128	</div>
129	);
130	};
131
132	export default RoleManagement;

mendersoftware / gui / 1081664682

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous