cowprotocol / contracts / 8096799720

97%

push

github

Favor nonce from Safe Multisig api (#75)

If there is a pending transaction in the Safe, the self-sell script
overwrites it when creating the `settle` transaction.
With these changes, the created transaction will use the nonce that is
recommended by the Safe API. This is the same nonce used by the
interface to determine the nonce for the next transaction.

I also sneaked in a change in the parameters, since the script is not
working unless `--to-token` is explicit.

### Test Plan

This is difficult to test as the script only works on mainnet (see #74).
I suggest to see that the api call returns the expected nonce.
For example,
[0xA03be496e67Ec29bC62F01a428683D7F9c204930](https://app.safe.global/transactions/queue?safe=sep:0xA03be496e67Ec29bC62F01a428683D7F9c204930)
is a Safe that right now has a pending transaction, and you can see that
the API output is the expected one:

```sh
curl -X 'GET' \
  'https://safe-client.safe.global/v1/chains/11155111/safes/0xA03be496e67Ec29bC62F01a428683D7F9c204930/nonces' \
  -H 'accept: application/json'
{"currentNonce":10,"recommendedNonce":11}
```

---------

Co-authored-by: Felix Leupold <felixleupold90@gmail.com>

160 of 172 branches covered (93.02%)

Branch coverage included in aggregate %.

364 of 366 relevant lines covered (99.45%)

37.8 hits per line