zopefoundation / AccessControl / 8588583915

82%

push

github

Make dict views behave like their unrestricted versions (#147)

unlike the restricted versions, the unrestricted versions:
 - are not iterators, they are views
 - have a len
 - are false when the mapping is empty, true otherwise
 - are instances of collections.abc.MappingView

This change aligns the behavior of restricted versions with the behavior
of unrestricted one, while keeping the "guard", which validates the
access with the security manager.

During this refactoring, also change `.items()` to validate
each keys and values, like `.keys()` and `.values()` do.

Co-authored-by: Dieter Maurer <d-maurer@users.noreply.github.com>

951 of 1475 branches covered (64.47%)

Branch coverage included in aggregate %.

72 of 72 new or added lines in 3 files covered. (100.0%)

5055 of 5911 relevant lines covered (85.52%)

5.12 hits per line