mendersoftware / mender / 1322289465

75%

master: 80%

push

gitlab-ci

fix: parse artifact ID before validating payload size

If a deployment fails before the artifact info is parsed, e.g. when a deployment
is started but S3 is blocked by a firewall, the JSON state data describes an
artifact with an empty payload-types list. If mender-update is subsequently
restarted, the JSON state data unmarshaler would exit early and return invalid
state data (empty deployment ID) triggering an assert in
DeploymentClient::PushStatus. The client would never recover from this.

Original-by: Fredrik Ellertsen <fredrik.ellertsen@disruptive-technologies.com>
* https://github.com/mendersoftware/mender/pull/1635

Modified-by: Kristian Amlie <kristian.amlie@northern.tech>
* Fix compile error due to declaration order.
* Made same fix for loading v1 state data.
* Adjusted changelog entry.

Changelog: Fix error which could sometimes happen with restrictive
firewalls, resulting in this output:
```
Programming error, should not happen: Assert `deployment_id != ""`
```

Ticket: MEN-7327

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>

4 of 4 new or added lines in 1 file covered. (100.0%)

7062 of 9355 relevant lines covered (75.49%)

11651.98 hits per line