mendersoftware / deployments / 1351052686

80%

master: 80%

Build Type

Pull #1029

gitlab-ci

Committed by alfrunes

Commit Message

perf: Optimize database interactions when updating deployment stats

Changed the sequential find and double update ops with a findAndModify
followed by a conditional update if the status actually changed.
This also improves atomicity as there is an inherent race condition when
doing the deployment status aggregation locally.

I also noticed that most internal calls to UpdateDeviceDeploymentStatus
already has the DeviceDeployment already, so I added an internal
updateDeviceDeploymentStatus which skips fetching the device deployment
(again).

Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>

Pull Request Pull Request #1029: perf: Optimize database interactions when updating deployment stats

Run Details

56 of 76 new or added lines in 3 files covered. (73.68%)

349 existing lines in 2 files now uncovered.

8125 of 10195 relevant lines covered (79.7%)

34.6 hits per line