mozilla / fx-private-relay / bbb7ba99-1612-4c45-98b9-c504ecd7654a

86%

main: 89%

Pull #5038

circleci

fix MPP-3893: remove onAction from menu *item* level

Our AliasGenerationButton component passed onAction to both useMenu and
useMenuItem hooks. react-aria has deprecated onAction handlers from the
menu item level in favor of handling actions at the menu level. Previous
versions of react-aria reconciled multiple handlers, but 3.43.3 does
not. So our handler was being called twice, causing MPP-3893.

(Note: the handler for custom masks was being called twice, but since it
did not POST to create an address, it did not create 2 masks.)

4121 of 5274 branches covered (78.14%)

Branch coverage included in aggregate %.

16209 of 18488 relevant lines covered (87.67%)

10.3 hits per line