1510560513

Committed 24 Oct 2024 12:04PM UTC coverage: 2.013% (+0.007%) from 2.006%

Build # 1510560513

Build Type

push

gitlab-ci

Committed by

lluiscampos

Commit Message

chore: Move variable declaration so that its always initialized at END

Clears `clang` warning:
```
.../mender-api.c:250:9: error: variable 'provides' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
  250 |     if (NULL == cJSON_AddStringToObject(json_provides, "device_type", mender_api_config.device_type)) {
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/lib/llvm-18/lib/clang/18/include/__stddef_null.h:26:14: note: expanded from macro 'NULL'
   26 | #define NULL ((void*)0)
      |              ^
.../mender-api.c:302:35: note: uninitialized use occurs here
  302 |     mender_utils_free_linked_list(provides);
      |                                   ^~~~~~~~
.../mender-api.c:250:5: note: remove the 'if' if its condition is always false
  250 |     if (NULL == cJSON_AddStringToObject(json_provides, "device_type", mender_api_config.device_type)) {
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  251 |         mender_log_error("Unable to allocate memory");
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  252 |         goto END;
      |         ~~~~~~~~~
  253 |     }
      |     ~

```

Signed-off-by: Lluis Campos <lluis.campos@northern.tech>

Run Details

31 of 1540 relevant lines covered (2.01%)

0.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/core/src/mender-artifact.c

/**
 * @file      mender-artifact.c
 * @brief     Mender artifact parser
 *
 * Copyright joelguittet and mender-mcu-client contributors
 * Copyright Northern.tech AS
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

#include <errno.h>

#include "mender-artifact.h"
#include "mender-deployment-data.h"
#include "mender-log.h"

/**
 * @brief Device type key
 */
#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
#define MENDER_ARTIFACT_DEVICE_TYPE_KEY "device_type"
#endif

/**
 * @brief TAR file header
 */
typedef struct {
    char name[100];
    char mode[8];
    char uid[8];
    char gid[8];
    char size[12];
    char mtime[12];
    char chksum[8];
    char typeflag;
    char linkname[100];
    char magic[6];
    char version[2];
    char uname[32];
    char gname[32];
    char devmajor[8];
    char devminor[8];
    char prefix[155];
} mender_artifact_tar_header_t;

/**
 * @brief Supported artifact format and version
 */
#define MENDER_ARTIFACT_SUPPORTED_FORMAT  "mender"
#define MENDER_ARTIFACT_SUPPORTED_VERSION 3

/**
 * @brief Parse header of TAR file
 * @param ctx Artifact context
 * @return MENDER_DONE if the data have been parsed, MENDER_OK if there is not enough data to parse, error code if an error occurred
 */
static mender_err_t artifact_parse_tar_header(mender_artifact_ctx_t *ctx);

/**
 * @brief Read version file of the artifact
 * @param ctx Artifact context
 * @return MENDER_DONE if the data have been parsed and version verified, MENDER_OK if there is not enough data to parse, error code if an error occurred
 */
static mender_err_t artifact_read_version(mender_artifact_ctx_t *ctx);

/**
 * @brief Read header-info file of the artifact
 * @param ctx Artifact context
 * @return MENDER_DONE if the data have been parsed and payloads retrieved, MENDER_OK if there is not enough data to parse, error code if an error occurred
 */
static mender_err_t artifact_read_header_info(mender_artifact_ctx_t *ctx);

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
/**
 * @brief Read manifest file of the artifact
 * @param ctx Artifact context
 * @return MENDER_DONE if the data have been parsed and checksums retrieved, MENDER_OK if there is not enough data to parse, error code if an error occurred
 */
static mender_err_t artifact_read_manifest(mender_artifact_ctx_t *ctx);

/**
 * @brief Read type-info file of the artifact
 * @param ctx Artifact context
 * @return MENDER_DONE if the data have been parsed and payloads retrieved, MENDER_OK if there is not enough data to parse, error code if an error occurred
 */
static mender_err_t artifact_read_type_info(mender_artifact_ctx_t *ctx);

/**
 * @brief Parse provides/depends from JSON object
 * @param json_provides_depends JSON object to parse
 * @param provides_depends Pointer to the list of provides or depends
 * @return MENDER_SUCCESS if the function succeeds, MENDER_FAIL otherwise
 */
static mender_err_t artifact_parse_provides_depends(cJSON *json_provides_depends, mender_key_value_list_t **provides_depends);
#endif

/**
 * @brief Read meta-data file of the artifact
 * @param ctx Artifact context
 * @return MENDER_DONE if the data have been parsed and payloads retrieved, MENDER_OK if there is not enough data to parse, error code if an error occurred
 */
static mender_err_t artifact_read_meta_data(mender_artifact_ctx_t *ctx);

/**
 * @brief Read data file of the artifact
 * @param ctx Artifact context
 * @param dl_data Download data for the artifact
 * @return MENDER_DONE if the data have been parsed and payloads retrieved, MENDER_OK if there is not enough data to parse, error code if an error occurred
 */
static mender_err_t artifact_read_data(mender_artifact_ctx_t *ctx, mender_artifact_download_data_t *dl_data);

/**
 * @brief Process chunk of artifact data
 */
static mender_err_t process_artifact_data_callback(const char                      *type,
                                                   const cJSON                     *meta_data,
                                                   const char                      *filename,
                                                   size_t                           size,
                                                   void                            *data,
                                                   size_t                           index,
                                                   size_t                           length,
                                                   mender_artifact_download_data_t *dl_data);

/**
 * @brief Drop content of the current file of the artifact
 * @param ctx Artifact context
 * @return MENDER_DONE if the data have been parsed and dropped, MENDER_OK if there is not enough data to parse, error code if an error occurred
 */
static mender_err_t artifact_drop_file(mender_artifact_ctx_t *ctx);

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
static mender_err_t artifact_read_header(mender_artifact_ctx_t *ctx);
#endif /* CONFIG_MENDER_FULL_PARSE_ARTIFACT */

/**
 * @brief Shift data after parsing
 * @param ctx Artifact context
 * @param length Length of data to shift
 * @return MENDER_OK if the function succeeds, error code otherwise
 */
static mender_err_t artifact_shift_data(mender_artifact_ctx_t *ctx, size_t length);

/**
 * @brief Compute length rounded up to increment (usually the block size)
 * @param length Length
 * @param incr Increment
 * @return Rounded length
 */
static size_t artifact_round_up(size_t length, size_t incr);

/**
 * @brief Artifact context
 */
static mender_artifact_ctx_t *artifact_ctx = NULL;

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
/**
 * @brief Get checksum entry for a file in the context
 * @param ctx The mender artifact context
 * @param filename The name of the file in the artifact
 * @return The checksum entry or NULL on error.
 * @note Since other files may be parsed before the manifest file, we need to
 *       create these entries in a lazy fashion.
 */
static mender_artifact_checksum_t *
artifact_checksum_get_or_create(mender_artifact_ctx_t *ctx, const char *filename) {
    assert(NULL != ctx);
    assert(NULL != filename);

    /* See if we already have an entry for this file */
    mender_artifact_checksum_t *checksum;
    for (checksum = ctx->artifact_info.checksums; NULL != checksum; checksum = checksum->next) {
        if (StringEqual(checksum->filename, filename)) {
            break;
        }
    }

    if (NULL == checksum) {
        /* Create new if entry not found */
        checksum = (mender_artifact_checksum_t *)calloc(1, sizeof(mender_artifact_checksum_t));
        if (NULL == checksum) {
            mender_log_error("Unable to allocate memory");
            return NULL;
        }
        checksum->filename = strdup(filename);
        if (NULL == checksum->filename) {
            mender_log_error("Unable to allocate memory");
            free(checksum);
            return NULL;
        }
        checksum->next               = ctx->artifact_info.checksums;
        ctx->artifact_info.checksums = checksum;

        /* Start SHA-256 checksum computation */
        if (MENDER_OK != mender_sha256_begin(&(checksum->context))) {
            mender_log_error("Failed to start checksum for file '%s'", filename);
            return NULL;
        }
    }

    return checksum;
}
#endif /* CONFIG_MENDER_FULL_PARSE_ARTIFACT */

mender_err_t
mender_artifact_check_integrity(mender_artifact_ctx_t *ctx) {
    assert(NULL != ctx);

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
    for (mender_artifact_checksum_t *checksum = ctx->artifact_info.checksums; NULL != checksum; checksum = checksum->next) {
        unsigned char computed[MENDER_DIGEST_BUFFER_SIZE];
        mender_log_debug("Checking integrity for artifact file '%s'", checksum->filename);

        if (MENDER_OK != mender_sha256_finish(checksum->context, computed)) {
            mender_log_error("Failed to finish checksum for file '%s'", checksum->filename);
            checksum->context = NULL;
            return MENDER_FAIL;
        }
        checksum->context = NULL;

        if (0 != memcmp(checksum->manifest, computed, MENDER_DIGEST_BUFFER_SIZE)) {
            mender_log_error("Computed checksum for file '%s' does not match manifest", checksum->filename);
#if CONFIG_MENDER_LOG_LEVEL >= MENDER_LOG_LEVEL_DBG
            /* Log the mismatching checksums for debugging */
            char checksum_str[(MENDER_DIGEST_BUFFER_SIZE * 2) + 1];

            for (int i = 0; i < MENDER_DIGEST_BUFFER_SIZE; i++) {
                if (2 != snprintf(checksum_str + (i * 2), 3, "%02hhx", checksum->manifest[i])) {
                    break;
                }
            }
            mender_log_debug("%s: '%s' (manifest)", checksum->filename, checksum_str);

            for (int i = 0; i < MENDER_DIGEST_BUFFER_SIZE; i++) {
                if (2 != snprintf(checksum_str + (i * 2), 3, "%02hhx", computed[i])) {
                    break;
                }
            }
            mender_log_debug("%s: '%s' (computed)", checksum->filename, checksum_str);
#endif /* CONFIG_MENDER_LOG_LEVEL >= MENDER_LOG_LEVEL_DBG */
            return MENDER_FAIL;
        }
    }
#endif /* CONFIG_MENDER_FULL_PARSE_ARTIFACT */
    return MENDER_OK;
}

mender_artifact_ctx_t *
mender_artifact_create_ctx(size_t buf_size) {

    mender_artifact_ctx_t *ctx;

    /* Create new context */
    if (NULL == (ctx = (mender_artifact_ctx_t *)calloc(1, sizeof(mender_artifact_ctx_t)))) {
        mender_log_error("Unable to allocate memory for artifact context");
        return NULL;
    }
    if (NULL == (ctx->input.data = malloc(buf_size))) {
        mender_log_error("Unable to allocate memory for artifact context buffer");
        free(ctx);
        return NULL;
    }
    ctx->input.size      = buf_size;
    ctx->input.orig_size = buf_size;

    /* Save context */
    artifact_ctx = ctx;

    return ctx;
}

mender_err_t
mender_artifact_get_ctx(mender_artifact_ctx_t **ctx) {

    assert(NULL != ctx);

    if (NULL == artifact_ctx) {
        return MENDER_FAIL;
    }

    *ctx = artifact_ctx;
    return MENDER_OK;
}

static bool
is_compressed(const char *filename) {

    static const char *compression_suffixes[] = { ".gz", ".xz", ".zst", NULL };

    for (size_t i = 0; NULL != compression_suffixes[i]; i++) {
        if (mender_utils_strendwith(filename, compression_suffixes[i])) {
            return true;
        }
    }

    return false;
}

mender_err_t
mender_artifact_process_data(mender_artifact_ctx_t *ctx, void *input_data, size_t input_length, mender_artifact_download_data_t *dl_data) {

    assert(NULL != ctx);
    mender_err_t ret = MENDER_OK;
    void        *tmp;
    size_t       new_size;
    size_t       expected_required;

    /* Copy data to the end of the internal buffer */
    if ((NULL != input_data) && (0 != input_length)) {
        if ((ctx->input.length + input_length) > ctx->input.size) {
            new_size = ctx->input.length + input_length;
            /* data/ files are processed per block for which the original size of the buffer should
               be enough, but metadata is processed as whole files so there we expect we will need
               more. */
            if (mender_utils_strbeginwith(ctx->file.name, "data/")) {
                expected_required = ctx->input.orig_size;
            } else {
                expected_required = artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE) + MENDER_ARTIFACT_STREAM_BLOCK_SIZE;
            }
            if (new_size > expected_required) {
                mender_log_debug("Reallocating artifact context buffer to %zd [SHOULD NOT BE HAPPENING!]", new_size);
            }
            /* Let's try to get what we expect we will need anyway and if we don't get that much,
               let's get the minimum required now, leaving us with a chance to get more later. */
            if (NULL == (tmp = realloc(ctx->input.data, MAX(new_size, expected_required)))) {
                if (NULL == (tmp = realloc(ctx->input.data, new_size))) {
                    /* Unable to allocate memory */
                    return MENDER_FAIL;
                }
                ctx->input.size = new_size;
            } else {
                ctx->input.size = MAX(new_size, expected_required);
            }
            ctx->input.data = tmp;
        }
        memcpy((void *)(((uint8_t *)ctx->input.data) + ctx->input.length), input_data, input_length);
        ctx->input.length += input_length;
    }

    /* Parse data */
    do {

        /* We do not support compressed artifacts */
        if (is_compressed(ctx->file.name)) {
            mender_log_error("Artifact compression is not supported");
            return MENDER_FAIL;
        }

        /* Treatment depending of the stream state */
        if (MENDER_ARTIFACT_STREAM_STATE_PARSING_HEADER == ctx->stream_state) {

            /* Parse TAR header */
            ret = artifact_parse_tar_header(ctx);

        } else if (MENDER_ARTIFACT_STREAM_STATE_PARSING_DATA == ctx->stream_state) {

            /* Treatment depending of the file name */
            if (StringEqual(ctx->file.name, "version")) {

                /* Validate artifact version */
                ret = artifact_read_version(ctx);

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
            } else if (StringEqual(ctx->file.name, "manifest")) {

                /* Read manifest file */
                ret = artifact_read_manifest(ctx);
#endif
            } else if (StringEqual(ctx->file.name, "header.tar/header-info")) {

                /* Read header-info file */
                ret = artifact_read_header_info(ctx);

            } else if ((true == mender_utils_strbeginwith(ctx->file.name, "header.tar/headers"))
                       && (true == mender_utils_strendwith(ctx->file.name, "meta-data"))) {

                /* Read meta-data file */
                ret = artifact_read_meta_data(ctx);

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
            } else if (mender_utils_strbeginwith(ctx->file.name, "header.tar/headers") && mender_utils_strendwith(ctx->file.name, "type-info")) {

                /* Read type-info file */
                ret = artifact_read_type_info(ctx);
#endif
            } else if (true == mender_utils_strbeginwith(ctx->file.name, "data")) {

                /* Read data */
                ret = artifact_read_data(ctx, dl_data);

            } else if (false == mender_utils_strendwith(ctx->file.name, ".tar")) {

                /* Drop data, file is not relevant */
                ret = artifact_drop_file(ctx);
#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
            } else if (StringEqual(ctx->file.name, "header.tar")) {
                ret = artifact_read_header(ctx);
#endif /* CONFIG_MENDER_FULL_PARSE_ARTIFACT */
            } else {

                /* Nothing to do */
                ret = MENDER_DONE;
            }

            /* Check if file have been parsed and treatment done */
            if (MENDER_DONE == ret) {

                /* Remove the previous file name */
                char *substring = mender_utils_strrstr(ctx->file.name, ".tar");
                if (NULL != substring) {
                    *(substring + strlen(".tar")) = '\0';
                } else {
                    FREE_AND_NULL(ctx->file.name);
                }
                ctx->file.size  = 0;
                ctx->file.index = 0;

                /* Update the stream state machine */
                ctx->stream_state = MENDER_ARTIFACT_STREAM_STATE_PARSING_HEADER;
            }
        }
    } while (MENDER_DONE == ret);

    return ret;
}

void
mender_artifact_release_ctx(mender_artifact_ctx_t *ctx) {

    /* Release memory */
    if (NULL != ctx) {
        free(ctx->input.data);
        if (NULL != ctx->payloads.values) {
            for (size_t index = 0; index < ctx->payloads.size; index++) {
                free(ctx->payloads.values[index].type);
                cJSON_Delete(ctx->payloads.values[index].meta_data);

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
                mender_utils_free_linked_list(ctx->payloads.values[index].provides);
                mender_utils_free_linked_list(ctx->payloads.values[index].depends);
                for (size_t i = 0; i < ctx->payloads.values[index].clears_provides_size; i++) {
                    free(ctx->payloads.values[index].clears_provides[i]);
                }
                free(ctx->payloads.values[index].clears_provides);
#endif
            }
            free(ctx->payloads.values);
        }
        free(ctx->file.name);
#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
        mender_utils_free_linked_list(ctx->artifact_info.provides);
        mender_utils_free_linked_list(ctx->artifact_info.depends);
        for (mender_artifact_checksum_t *checksum = ctx->artifact_info.checksums; NULL != checksum; checksum = checksum->next) {
            free(checksum->filename);
            mender_sha256_finish(checksum->context, NULL);
        }
#endif
        free(ctx);
    }
}

static mender_err_t
artifact_parse_tar_header(mender_artifact_ctx_t *ctx) {

    assert(NULL != ctx);
    char *tmp;

    /* Check if enough data are received (at least one block) */
    if ((NULL == ctx->input.data) || (ctx->input.length < MENDER_ARTIFACT_STREAM_BLOCK_SIZE)) {
        return MENDER_OK;
    }

    /* Cast block to TAR header structure */
    mender_artifact_tar_header_t *tar_header = (mender_artifact_tar_header_t *)ctx->input.data;

    /* Check if file name is provided, else the end of the current TAR file is reached */
    if ('\0' == tar_header->name[0]) {

        /* Check if enough data are received (at least 2 blocks) */
        if (ctx->input.length < 2 * MENDER_ARTIFACT_STREAM_BLOCK_SIZE) {
            return MENDER_OK;
        }

        /* Remove the TAR file name */
        if (NULL != ctx->file.name) {
            char *substring = mender_utils_strrstr(ctx->file.name, ".tar");
            if (NULL != substring) {
                *substring = '\0';
                substring  = mender_utils_strrstr(ctx->file.name, ".tar");
                if (NULL != substring) {
                    *(substring + strlen(".tar")) = '\0';
                } else {
                    FREE_AND_NULL(ctx->file.name);
                }
            } else {
                FREE_AND_NULL(ctx->file.name);
            }
        }

        /* Shift data in the buffer */
        if (MENDER_OK != artifact_shift_data(ctx, 2 * MENDER_ARTIFACT_STREAM_BLOCK_SIZE)) {
            mender_log_error("Unable to shift input data");
            return MENDER_FAIL;
        }

        return MENDER_DONE;
    }

    /* Check magic */
    if (strncmp(tar_header->magic, "ustar", strlen("ustar"))) {
        /* Invalid magic */
        mender_log_error("Invalid magic");
        return MENDER_FAIL;
    }

    /* Compute the new file name */
    if (NULL != ctx->file.name) {
        size_t str_length = strlen(ctx->file.name) + strlen("/") + strlen(tar_header->name) + 1;
        if (NULL == (tmp = (char *)malloc(str_length))) {
            mender_log_error("Unable to allocate memory");
            return MENDER_FAIL;
        }
        snprintf(tmp, str_length, "%s/%s", ctx->file.name, tar_header->name);
        free(ctx->file.name);
    } else {
        if (NULL == (tmp = strdup(tar_header->name))) {
            mender_log_error("Unable to allocate memory");
            return MENDER_FAIL;
        }
    }
    ctx->file.name = tmp;

    /* Retrieve file size */
    assert(sizeof(size_t) >= sizeof(unsigned long));
    char *end_ptr;
    errno = 0; /* to distinguish between success/failure */

    ctx->file.size = strtoul(tar_header->size, &end_ptr, 8);
    if ((end_ptr == tar_header->size) /* no conversion */
        || (0 != errno)) {            /* out of range (for unsigned long) */
        mender_log_error("Unable to retrieve file size");
        return MENDER_FAIL;
    }

    ctx->file.index = 0;

    /* Shift data in the buffer */
    if (MENDER_OK != artifact_shift_data(ctx, MENDER_ARTIFACT_STREAM_BLOCK_SIZE)) {
        mender_log_error("Unable to shift input data");
        return MENDER_FAIL;
    }

    /* Update the stream state machine */
    ctx->stream_state = MENDER_ARTIFACT_STREAM_STATE_PARSING_DATA;

    return MENDER_DONE;
}

static mender_err_t
artifact_read_version(mender_artifact_ctx_t *ctx) {

    assert(NULL != ctx);
    cJSON       *object = NULL;
    mender_err_t ret    = MENDER_DONE;

    /* Check if all data have been received */
    if ((NULL == ctx->input.data) || (ctx->input.length < artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        return MENDER_OK;
    }

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
    /* Get checksum entry (create one if needed) */
    mender_artifact_checksum_t *checksum;
    if (NULL == (checksum = artifact_checksum_get_or_create(ctx, "version"))) {
        /* Error already logged */
        return MENDER_FAIL;
    }

    /* Update SHA-256 checksum */
    if (MENDER_OK != mender_sha256_update(checksum->context, ctx->input.data, ctx->file.size)) {
        mender_log_error("Failed to update update checksum");
        return MENDER_FAIL;
    }
#endif /* CONFIG_MENDER_FULL_PARSE_ARTIFACT */

    /* Check version file */
    if (NULL == (object = cJSON_ParseWithLength(ctx->input.data, ctx->file.size))) {
        mender_log_error("Unable to allocate memory");
        return MENDER_FAIL;
    }
    cJSON *json_format = cJSON_GetObjectItemCaseSensitive(object, "format");
    if (true == cJSON_IsString(json_format)) {
        if (!StringEqual(cJSON_GetStringValue(json_format), MENDER_ARTIFACT_SUPPORTED_FORMAT)) {
            mender_log_error("Invalid version format");
            ret = MENDER_FAIL;
            goto END;
        }
    } else {
        mender_log_error("Invalid version file");
        ret = MENDER_FAIL;
        goto END;
    }
    cJSON *json_version = cJSON_GetObjectItemCaseSensitive(object, "version");
    if (true == cJSON_IsNumber(json_version)) {
        if (MENDER_ARTIFACT_SUPPORTED_VERSION != (int)cJSON_GetNumberValue(json_version)) {
            mender_log_error("Invalid version value");
            ret = MENDER_FAIL;
            goto END;
        }
    } else {
        mender_log_error("Invalid version file");
        ret = MENDER_FAIL;
        goto END;
    }
    mender_log_debug("Artifact has valid version");

    /* Shift data in the buffer */
    if (MENDER_OK != artifact_shift_data(ctx, artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        mender_log_error("Unable to shift input data");
        ret = MENDER_FAIL;
        goto END;
    }

END:

    /* Release memory */
    cJSON_Delete(object);

    return ret;
}

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
mender_err_t
mender_artifact_get_device_type(mender_artifact_ctx_t *ctx, const char **device_type) {

    assert(NULL != ctx);
    assert(NULL != device_type);

    mender_key_value_list_t *item = ctx->artifact_info.depends;
    while (NULL != item) {
        if (NULL != item->key) {
            if (StringEqual(MENDER_ARTIFACT_DEVICE_TYPE_KEY, item->key)) {
                *device_type = item->value;
                return MENDER_OK;
            }
        }
        item = item->next;
    }
    return MENDER_FAIL;
}

static mender_err_t
artifact_read_manifest(mender_artifact_ctx_t *ctx) {

    assert(NULL != ctx);

    /* Check if all data has been received */
    if ((NULL == ctx->input.data) || (ctx->input.length < artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        return MENDER_OK;
    }

    /*  The expected format matches the output of sha256sum: sum and the name of the file separated by two spaces
        1d0b820130ae028ce8a79b7e217fe505a765ac394718e795d454941487c53d32  data/0000/update.ext4
        4d480539cdb23a4aee6330ff80673a5af92b7793eb1c57c4694532f96383b619  header.tar.gz
        52c76ab66947278a897c2a6df8b4d77badfa343fec7ba3b2983c2ecbbb041a35  version
    */

    /* Read data line by line */
    char *line = ctx->input.data;
    char *end  = line + ctx->input.length;
    while (line < end) {
        char *next = strchr(line, '\n');
        if (NULL == next) {
            break;
        }
        *next = '\0';

        /* Process line */
        char *separator = strstr(line, "  ");
        if (NULL == separator) {
            mender_log_error("Invalid manifest file");
            return MENDER_FAIL;
        }
        *separator = '\0';

        const char *checksum_str = line;
        const char *filename     = separator + 2;

        /* Useful when debugging artifact integrity check failures */
        mender_log_debug("%s  %s", checksum_str, filename);

        /* Make sure digest is of expected length (two hex per byte) */
        if ((MENDER_DIGEST_BUFFER_SIZE * 2) != strlen(checksum_str)) {
            mender_log_error("Bad checksum '%s' in manifest for file '%s'", checksum_str, filename);
            return MENDER_FAIL;
        }

        /* Get checksum entry for the file (creates one if not found) */
        mender_artifact_checksum_t *checksum;
        if (NULL == (checksum = artifact_checksum_get_or_create(ctx, filename))) {
            /* Error already logged */
            return MENDER_FAIL;
        }

        /* Populate with manifest checksum */
        if (!mender_utils_hexdump_to_bytes(checksum_str, checksum->manifest, MENDER_DIGEST_BUFFER_SIZE)) {
            mender_log_error("Bad checksum '%s' in manifest for file '%s'", checksum_str, filename);
            return MENDER_FAIL;
        }

        ///* Move to the next line */
        line = next + 1;
    }

    /* Shift data in the buffer */
    if (MENDER_OK != artifact_shift_data(ctx, artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        mender_log_error("Unable to shift input data");
        return MENDER_FAIL;
    }

    return MENDER_DONE;
}

static mender_err_t
artifact_parse_provides_depends(cJSON *json_provides_depends, mender_key_value_list_t **provides_depends) {

    assert(NULL != json_provides_depends);
    assert(NULL != provides_depends);

    /* Create linked-list from json object */
    /* The elements can either be a string or an array of strings */
    cJSON *json_element = NULL;
    cJSON_ArrayForEach(json_element, json_provides_depends) {
        if (cJSON_IsString(json_element)) {
            if (MENDER_OK != mender_utils_create_key_value_node(json_element->string, json_element->valuestring, provides_depends)) {
                mender_log_error("Unable to create linked list node for string element");
                goto ERROR;
            }
        } else if (cJSON_IsArray(json_element)) {
            cJSON *json_element_value = NULL;
            cJSON_ArrayForEach(json_element_value, json_element) {
                if (MENDER_OK != mender_utils_create_key_value_node(json_element->string, json_element_value->valuestring, provides_depends)) {
                    mender_log_error("Unable to create linked list node for array element");
                    goto ERROR;
                }
            }
        } else {
            mender_log_error("Invalid header-info file element type");
            goto ERROR;
        }
    }

    return MENDER_OK;

ERROR:
    /* Free linked list in case of error */
    mender_utils_free_linked_list(*provides_depends);
    return MENDER_FAIL;
}
#endif

static mender_err_t
artifact_read_header_info(mender_artifact_ctx_t *ctx) {

    assert(NULL != ctx);
    cJSON       *object = NULL;
    mender_err_t ret    = MENDER_DONE;

    /* Check if all data have been received */
    if ((NULL == ctx->input.data) || (ctx->input.length < artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        return MENDER_OK;
    }

    /* Read header-info */
    if (NULL == (object = cJSON_ParseWithLength(ctx->input.data, ctx->file.size))) {
        mender_log_error("Unable to allocate memory");
        return MENDER_FAIL;
    }
    cJSON *json_payloads = cJSON_GetObjectItemCaseSensitive(object, "payloads");
    if (true == cJSON_IsArray(json_payloads)) {
        ctx->payloads.size = cJSON_GetArraySize(json_payloads);
        if (NULL == (ctx->payloads.values = (mender_artifact_payload_t *)calloc(ctx->payloads.size, sizeof(mender_artifact_payload_t)))) {
            mender_log_error("Unable to allocate memory");
            ret = MENDER_FAIL;
            goto END;
        }
        size_t index        = 0;
        cJSON *json_payload = NULL;
        cJSON_ArrayForEach(json_payload, json_payloads) {
            if (true == cJSON_IsObject(json_payload)) {
                cJSON *json_payload_type = cJSON_GetObjectItemCaseSensitive(json_payload, "type");
                if (cJSON_IsString(json_payload_type)) {
                    if (NULL == (ctx->payloads.values[index].type = strdup(cJSON_GetStringValue(json_payload_type)))) {
                        mender_log_error("Unable to allocate memory");
                        ret = MENDER_FAIL;
                        goto END;
                    }
                } else {
                    mender_log_error("Invalid header-info file");
                    ret = MENDER_FAIL;
                    goto END;
                }
            } else {
                mender_log_error("Invalid header-info file");
                ret = MENDER_FAIL;
                goto END;
            }
            index++;
        }

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
        cJSON *json_provides = cJSON_GetObjectItemCaseSensitive(object, "artifact_provides");
        if (cJSON_IsObject(json_provides)) {
            if (MENDER_FAIL == artifact_parse_provides_depends(json_provides, &(ctx->artifact_info.provides))) {
                mender_log_error("Unable to parse artifact_provides");
                ret = MENDER_FAIL;
                goto END;
            }
        }

        cJSON *json_depends = cJSON_GetObjectItemCaseSensitive(object, "artifact_depends");
        if (cJSON_IsObject(json_depends)) {
            if (MENDER_FAIL == artifact_parse_provides_depends(json_depends, &(ctx->artifact_info.depends))) {
                mender_log_error("Unable to parse artifact_depends");
                ret = MENDER_FAIL;
                goto END;
            }
        }
#endif

    } else {
        mender_log_error("Invalid header-info file");
        ret = MENDER_FAIL;
        goto END;
    }

    /* Shift data in the buffer */
    if (MENDER_OK != artifact_shift_data(ctx, artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        mender_log_error("Unable to shift input data");
        ret = MENDER_FAIL;
        goto END;
    }

END:

    /* Release memory */
    cJSON_Delete(object);

    return ret;
}

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
static mender_err_t
artifact_read_header(mender_artifact_ctx_t *ctx) {
    assert(NULL != ctx);

    /* Check if all data have been received */
    if ((NULL == ctx->input.data) || (ctx->input.length < artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        return MENDER_OK;
    }

    /* Get checksum entry (create one if needed) */
    mender_artifact_checksum_t *checksum;
    if (NULL == (checksum = artifact_checksum_get_or_create(ctx, "header.tar"))) {
        /* Error already logged */
        return MENDER_FAIL;
    }

    /* Update SHA-256 checksum */
    if (MENDER_OK != mender_sha256_update(checksum->context, ctx->input.data, ctx->file.size)) {
        mender_log_error("Failed to update update checksum");
        return MENDER_FAIL;
    }

    return MENDER_DONE;
}
#endif /* CONFIG_MENDER_FULL_PARSE_ARTIFACT */

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
static mender_err_t
artifact_read_type_info(mender_artifact_ctx_t *ctx) {

    assert(NULL != ctx);
    cJSON       *object = NULL;
    mender_err_t ret    = MENDER_DONE;
    size_t       index  = 0;

    /* Check if all data have been received */
    if ((NULL == ctx->input.data) || (ctx->input.length < artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        return MENDER_OK;
    }

    /* Read type-info */
    if (NULL == (object = cJSON_ParseWithLength(ctx->input.data, ctx->file.size))) {
        mender_log_error("Unable to allocate memory");
        return MENDER_FAIL;
    }

    /* Check if payload index is valid */
    if (NULL == ctx->payloads.values[index].type) {
        mender_log_error("Invalid artifact format; no payload found for index %d", index);
        ret = MENDER_FAIL;
        goto END;
    }
#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
    cJSON *json_provides = cJSON_GetObjectItemCaseSensitive(object, "artifact_provides");
    if (cJSON_IsObject(json_provides)) {
        if (MENDER_FAIL == artifact_parse_provides_depends(json_provides, &(ctx->payloads.values[index].provides))) {
            mender_log_error("Unable to parse artifact_provides");
            ret = MENDER_FAIL;
            goto END;
        }
    }

    cJSON *json_depends = cJSON_GetObjectItemCaseSensitive(object, "artifact_depends");
    if (cJSON_IsObject(json_depends)) {
        if (MENDER_FAIL == artifact_parse_provides_depends(json_depends, &(ctx->payloads.values[index].depends))) {
            mender_log_error("Unable to parse artifact_depends");
            ret = MENDER_FAIL;
            goto END;
        }
    }

    cJSON *json_clears_provides = cJSON_GetObjectItemCaseSensitive(object, "clears_artifact_provides");
    if (cJSON_IsArray(json_clears_provides)) {
        ctx->payloads.values[index].clears_provides_size = cJSON_GetArraySize(json_clears_provides);
        ctx->payloads.values[index].clears_provides      = (char **)calloc(ctx->payloads.values[index].clears_provides_size, sizeof(char *));
        if (NULL == ctx->payloads.values[index].clears_provides) {
            mender_log_error("Unable to allocate memory");
            ret = MENDER_FAIL;
            goto END;
        }

        size_t i                            = 0;
        cJSON *json_clears_provides_element = NULL;

        cJSON_ArrayForEach(json_clears_provides_element, json_clears_provides) {
            if (cJSON_IsString(json_clears_provides_element)) {
                char *clears_provides = strdup(json_clears_provides_element->valuestring);
                if (NULL == clears_provides) {
                    mender_log_error("Unable to allocate memory");
                    ret = MENDER_FAIL;
                    goto END;
                }
                ctx->payloads.values[index].clears_provides[i] = clears_provides;
                i++;
            } else {
                mender_log_error("Invalid header-info file");
                ret = MENDER_FAIL;
                goto END;
            }
        }
    }
#endif

    /* Shift data in the buffer */
    if (MENDER_OK != artifact_shift_data(ctx, artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        mender_log_error("Unable to shift input data");
        ret = MENDER_FAIL;
        goto END;
    }

END:

    /* Release memory */
    cJSON_Delete(object);

    return ret;
}
#endif

static mender_err_t
artifact_read_meta_data(mender_artifact_ctx_t *ctx) {

    assert(NULL != ctx);

    /* Retrieve payload index. We expect "header.tar/headers/%u/meta-data" where
     * %u is the index. Yes sscanf(3) would be nice, but we've experienced
     * unexplained segmentation faults on some hardware when using it. */
    const char *const prefix = "header.tar/headers/";
    if (!mender_utils_strbeginwith(ctx->file.name, prefix)) {
        mender_log_error("Invalid artifact format");
        return MENDER_FAIL;
    }

    assert(sizeof(size_t) >= sizeof(unsigned long));
    const char *start_ptr = ctx->file.name + strlen(prefix);
    char       *end_ptr;
    errno = 0; /* to distinguish between success/failure */

    const size_t index = strtoul(start_ptr, &end_ptr, 10);
    if ((end_ptr == start_ptr)              /* no conversion */
        || (0 != errno)                     /* out of range (for unsigned long) */
        || (index >= ctx->payloads.size)) { /* index out of bounds */
        mender_log_error("Invalid artifact format");
        return MENDER_FAIL;
    }

    assert(NULL != end_ptr);
    assert(StringEqualN(end_ptr, "/meta-data", 10)); /* just one last sanity check */

    /* Check size of the meta-data */
    if (0 == artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE)) {
        /* Nothing to do */
        return MENDER_DONE;
    }

    /* Check if all data have been received */
    if ((NULL == ctx->input.data) || (ctx->input.length < artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        return MENDER_OK;
    }

    /* Read meta-data */
    if (NULL == (ctx->payloads.values[index].meta_data = cJSON_ParseWithLength(ctx->input.data, ctx->file.size))) {
        mender_log_error("Unable to allocate memory");
        return MENDER_FAIL;
    }

    /* Shift data in the buffer */
    if (MENDER_OK != artifact_shift_data(ctx, artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
        mender_log_error("Unable to shift input data");
        return MENDER_FAIL;
    }

    return MENDER_DONE;
}

/**
 * @brief Callback function to be invoked to perform the treatment of the data from the artifact
 * @param type Type from header-info payloads
 * @param meta_data Meta-data from header tarball
 * @param filename Artifact filename
 * @param size Artifact file size
 * @param data Artifact data
 * @param index Artifact data index
 * @param length Artifact data length
 * @param dl_data Download data for the artifact
 * @return MENDER_OK if the function succeeds, error code if an error occurred
 */
static mender_err_t
process_artifact_data_callback(const char                      *type,
                               const cJSON                     *meta_data,
                               const char                      *filename,
                               size_t                           size,
                               void                            *data,
                               size_t                           index,
                               size_t                           length,
                               mender_artifact_download_data_t *dl_data) {

    assert(NULL != type);
    mender_err_t ret = MENDER_FAIL;

#if CONFIG_MENDER_LOG_LEVEL >= MENDER_LOG_LEVEL_INF
    if (size > 0) {
        static size_t download_progress = 0;
        /* New update */
        if (0 == index) {
            download_progress = 0;
        }

        /* Update every 10% */
        if (((index * 10) / size) > download_progress) {
            download_progress = (index * 10) / size;
            mender_log_info("Downloading '%s' %zu0%%... [%zu/%zu]", type, download_progress, index, size);
        }
    }
#endif

    dl_data->update_module = mender_update_module_get(type);
    if (NULL == dl_data->update_module) {
        /* Content is not supported by the mender-mcu-client */
        mender_log_error("Unable to handle artifact type '%s'", type);
        return MENDER_FAIL;
    }

    /* Retrieve ID and artifact name */
    const char *id;
    if (MENDER_OK != mender_deployment_data_get_id(dl_data->deployment, &id)) {
        mender_log_error("Unable to get ID from the deployment data");
        return MENDER_FAIL;
    }
    const char *artifact_name;
    if (MENDER_OK != mender_deployment_data_get_artifact_name(dl_data->deployment, &artifact_name)) {
        mender_log_error("Unable to get artifact name from the deployment data");
        return MENDER_FAIL;
    }

    /* Invoke update module download callback */
    struct mender_update_download_state_data_s download_state_data = { id, artifact_name, type, meta_data, filename, size, data, index, length, false };
    mender_update_state_data_t                 state_data          = { .download_state_data = &download_state_data };
    if (MENDER_OK != (ret = dl_data->update_module->callbacks[MENDER_UPDATE_STATE_DOWNLOAD](MENDER_UPDATE_STATE_DOWNLOAD, state_data))) {
        mender_log_error("An error occurred while processing data of the artifact '%s' of type '%s'", artifact_name, type);
        return ret;
    }

    /* Treatments related to the artifact type (once) */
    if (0 == index) {
        /* Add type to the deployment data */
        if (MENDER_OK != (ret = mender_deployment_data_add_payload_type(dl_data->deployment, type))) {
            /* Error already logged */
            return ret;
        }
    }

    return MENDER_OK;
}

static mender_err_t
artifact_read_data(mender_artifact_ctx_t *ctx, mender_artifact_download_data_t *dl_data) {

    assert(NULL != ctx);
    mender_err_t ret;

    /* Retrieve payload index. We expect "data/%u.tar" where %u is the index.
     * Yes sscanf(3) would be nice, but we've experienced unexplained
     * segmentation faults on some hardware when using it. */
    const char *const prefix = "data/";
    if (!mender_utils_strbeginwith(ctx->file.name, prefix)) {
        mender_log_error("Invalid artifact format");
        return MENDER_FAIL;
    }

    assert(sizeof(size_t) >= sizeof(unsigned long));
    const char *start_ptr = ctx->file.name + strlen(prefix);
    char       *end_ptr;
    errno = 0; /* to distinguish between success/failure */

    const size_t index = strtoul(start_ptr, &end_ptr, 10);
    if ((end_ptr == start_ptr)              /* no conversion */
        || (0 != errno)                     /* out of range (for unsigned long) */
        || (index >= ctx->payloads.size)) { /* index out of bounds */
        mender_log_error("Invalid artifact format");
        return MENDER_FAIL;
    }

    assert(NULL != end_ptr);
    assert(StringEqualN(end_ptr, ".tar", 4)); /* just one last sanity check */

    /* Check if a file name is provided (we don't check the extension because we don't know it) */
    if (strlen("data/xxxx.tar") == strlen(ctx->file.name)) {

        /* Beginning of the data file */
        if (MENDER_OK
            != (ret = process_artifact_data_callback(ctx->payloads.values[index].type, ctx->payloads.values[index].meta_data, NULL, 0, NULL, 0, 0, dl_data))) {
            mender_log_error("An error occurred");
            return ret;
        }

        return MENDER_DONE;
    }

    /* Check size of the data */
    if (0 == artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE)) {
        /* Nothing to do */
        return MENDER_DONE;
    }

    /* Parse data until the end of the file has been reached */
    do {

        /* Check if enough data are received (at least one block) */
        if ((NULL == ctx->input.data) || (ctx->input.length < MENDER_ARTIFACT_STREAM_BLOCK_SIZE)) {
            return MENDER_OK;
        }

        /* Compute length */
        size_t length
            = ((ctx->file.size - ctx->file.index) > MENDER_ARTIFACT_STREAM_BLOCK_SIZE) ? MENDER_ARTIFACT_STREAM_BLOCK_SIZE : (ctx->file.size - ctx->file.index);

#ifdef CONFIG_MENDER_FULL_PARSE_ARTIFACT
        mender_artifact_checksum_t *checksum;
        {
            /* The filename will be something like
             * 'data/0000.tar/zephyr.signed.bin'. But the manifest will hold
             * 'data/0000/zephyr.signed.bin'. Hence, we need to remove the
             * '.tar' extension from the string.
             */
            char filename[strlen(ctx->file.name) + 1];
            strcpy(filename, ctx->file.name);

            for (char *ch = strstr(filename, ".tar"); (NULL != ch) && (*ch != '\0'); ch++) {
                /* Don't worry! The call to strlen() on a static string should
                 * be optimized out by the compiler */
                *ch = ch[strlen(".tar")];
            }

            /* Get checksum entry (create one if needed) */
            if (NULL == (checksum = artifact_checksum_get_or_create(ctx, filename))) {
                /* Error already logged */
                return MENDER_FAIL;
            }
        }

        /* Update SHA-256 checksum */
        if (MENDER_OK != mender_sha256_update(checksum->context, ctx->input.data, length)) {
            mender_log_error("Failed to update update checksum");
            return MENDER_FAIL;
        }
#endif /* CONFIG_MENDER_FULL_PARSE_ARTIFACT */

        /* Invoke the download artifact callback */
        ret = process_artifact_data_callback(ctx->payloads.values[index].type,
                                             ctx->payloads.values[index].meta_data,
                                             strstr(ctx->file.name, ".tar") + strlen(".tar") + 1,
                                             ctx->file.size,
                                             ctx->input.data,
                                             ctx->file.index,
                                             length,
                                             dl_data);
        if (MENDER_OK != ret) {
            mender_log_error("An error occurred");
            return ret;
        }

        /* Update index */
        ctx->file.index += MENDER_ARTIFACT_STREAM_BLOCK_SIZE;

        /* Shift data in the buffer */
        if (MENDER_OK != (ret = artifact_shift_data(ctx, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
            mender_log_error("Unable to shift input data");
            return ret;
        }

    } while (ctx->file.index < ctx->file.size);

    return MENDER_DONE;
}

static mender_err_t
artifact_drop_file(mender_artifact_ctx_t *ctx) {

    assert(NULL != ctx);
    mender_err_t ret;

    /* Check size of the data */
    if (0 == artifact_round_up(ctx->file.size, MENDER_ARTIFACT_STREAM_BLOCK_SIZE)) {
        /* Nothing to do */
        return MENDER_DONE;
    }

    /* Parse data until the end of the file has been reached */
    do {

        /* Check if enough data are received (at least one block) */
        if ((NULL == ctx->input.data) || (ctx->input.length < MENDER_ARTIFACT_STREAM_BLOCK_SIZE)) {
            return MENDER_OK;
        }

        /* Update index */
        ctx->file.index += MENDER_ARTIFACT_STREAM_BLOCK_SIZE;

        /* Shift data in the buffer */
        if (MENDER_OK != (ret = artifact_shift_data(ctx, MENDER_ARTIFACT_STREAM_BLOCK_SIZE))) {
            mender_log_error("Unable to shift input data");
            return ret;
        }

    } while (ctx->file.index < ctx->file.size);

    return MENDER_DONE;
}

static mender_err_t
artifact_shift_data(mender_artifact_ctx_t *ctx, size_t length) {

    assert(NULL != ctx);

    /* Shift data */
    if (length > 0) {
        if (ctx->input.length > length) {
            memmove(ctx->input.data, (void *)(((uint8_t *)ctx->input.data) + length), ctx->input.length - length);
            ctx->input.length -= length;
            /* Here we could shrink the ctx->input.data buffer, but most likely, we would need to
               grow it again when we receive another batch of data so there's little point in doing
               so. */
        } else {
            ctx->input.length = 0;
        }
    }

    return MENDER_OK;
}

static size_t
artifact_round_up(size_t length, size_t incr) {
    return length + (incr - length % incr) % incr;
}

mendersoftware / mender-mcu / 1510560513

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous