1510560513
2%
main: 61%

Ran 24 Oct 2024 12:06PM UTC

Jobs 1

Files 13

Run time 1min

Badge

Embed ▾

Committed 24 Oct 2024 12:04PM UTC coverage: 2.013% (+0.007%) from 2.006%

Build # 1510560513

Build Type

push

gitlab-ci

Committed by

lluiscampos

Commit Message

chore: Move variable declaration so that its always initialized at END

Clears `clang` warning:
```
.../mender-api.c:250:9: error: variable 'provides' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
  250 |     if (NULL == cJSON_AddStringToObject(json_provides, "device_type", mender_api_config.device_type)) {
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/lib/llvm-18/lib/clang/18/include/__stddef_null.h:26:14: note: expanded from macro 'NULL'
   26 | #define NULL ((void*)0)
      |              ^
.../mender-api.c:302:35: note: uninitialized use occurs here
  302 |     mender_utils_free_linked_list(provides);
      |                                   ^~~~~~~~
.../mender-api.c:250:5: note: remove the 'if' if its condition is always false
  250 |     if (NULL == cJSON_AddStringToObject(json_provides, "device_type", mender_api_config.device_type)) {
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  251 |         mender_log_error("Unable to allocate memory");
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  252 |         goto END;
      |         ~~~~~~~~~
  253 |     }
      |     ~

```

Signed-off-by: Lluis Campos <lluis.campos@northern.tech>

Run Details

31 of 1540 relevant lines covered (2.01%)

0.55 hits per line

Uncovered Existing Lines

Lines	∆	File
9	0.0%	core/src/mender-artifact-download.c
14	0.0%	core/src/mender-update-module.c
90	0.0%	core/src/mender-api.c
192	0.0%	core/src/mender-artifact.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	1510560513.1	24 Oct 2024 12:06PM UTC	13	2.01

mendersoftware / mender-mcu / 1510560513
2%
main: 61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1510560513

mendersoftware / mender-mcu / 1510560513 2% main: 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1510560513

mendersoftware / mender-mcu / 1510560513
2%
main: 61%

README BADGES
x