PHPCSStandards / PHP_CodeSniffer / 11587556685

78%

master: 79%

push

github

Generic/ConstructorName: fix minor bug

This commit fixes a minor bug in `Generic.NamingConventions
.ConstructorName` when checking if a given class has a parent. The code
was checking if the lower case version of the value returned by
`File::findExtendedClassName()`` is `false`. The problem is that
`strtolower()` never returns `false`, it always returns a `string`.
Thus, the condition would never evaluate to `true` and the sniff would
not bail at this point when a given class has no parent.

This did not cause any issues to the sniff, even for invalid code, as
there is not a scenario where a class method can have a `T_DOUBLE_COLON`
token followed by a `T_STRING` token with an empty `content`. This is
true even for empty strings as PHPCS includes the quotes in the
`content`.

3 of 3 new or added lines in 1 file covered. (100.0%)

18136 of 24449 relevant lines covered (74.18%)

72.69 hits per line