pulibrary / orangelight / 2b24cf4f-a4a5-45d4-a869-e58b2310f807

95%

push

circleci

[#4552] More reliable boolean operators on the advanced search form (#4553)

* [#4552] More reliable boolean operators on the advanced search form

This is not quite working, see failing test
spec/features/advanced_searching_spec.rb:156

Specifically, if the user enters a boolean NOT search in the advanced
search, the constraints on the search results page is currently not
including the word NOT, so the user doesn't get the feedback that it
is a negated term.

I think we could address this in our ClausePresenter, although it
might make that class quite a bit more complex.

* Mutate the params in the controller instead

This allows the ClausePresenter to access both our params (e.g. boolean_operator1=OR)
and the ones that Solr's BoolQParser likes (e.g. clause[0][op]=should).

29 of 29 new or added lines in 2 files covered. (100.0%)

5988 of 6193 relevant lines covered (96.69%)

1539.22 hits per line