SwissDataScienceCenter / renku-data-services / 12373079746

86%

Build Type

push

github

Committed by web-flow

Commit Message

feat!: add support for session secrets (#545)

Closes #509.

Details:
* Add support for session secret slots which describe files with secret contents to be mounted in sessions. Session secret slots exist at the project level and can be managed by users with at the WRITE permission on the project. Session secrets can be used by all users with the READ permission on the project.
* Add support for session secrets which connect a project's session secret slots to user secrets. Session secrets can be used by all users with the READ permission on the project.
* Add support for mounting user secrets in sessions according to the project's session secret slots.
* Add support for multiple names in `key_mapping` when creating a kubernetes secret. This allows the same user secret to be supplied more than once in sessions.
* Re-work user secrets to make them more usable in Renku 2.0.
    - Change the `name` field to be `default_filename`. This field is only meaningful in the context of Renku 1.0.
    - Add a new `name` field (which does not have constraints) to let users name their secrets, e.g. "AWS Secret Key ID for Project XYZ".
    - User secret objects now include back references to Session secret slots and Data connectors -> `session_secret_slot_ids` and `data_connector_ids` fields returned from the API.
    - The `UserSecretsRepo` class has been split into `LowLevelUserSecretsRepo` and `UserSecretsRepo`. `LowLevelUserSecretsRepo` is used internally, e.g. for key rotation  and `UserSecretsRepo` is used for the `UserSecretsBP` blueprint
* Add a new field secrets_mount_directory to projects, which allows user to configure where secrets are mounted in sessions.

---------

Co-authored-by: Tasko Olevski <olevski90@gmail.com>
Co-authored-by: Ralf Grubenmann <ralf.grubenmann@sdsc.ethz.ch>

Run Details

632 of 683 new or added lines in 27 files covered. (92.53%)

4 existing lines in 4 files now uncovered.

15132 of 17482 relevant lines covered (86.56%)

1.53 hits per line