pulibrary / bibdata / 3d4f7542-4e4d-4ac4-979c-598f40574373
90%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 116
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.682%. Remained the same
3d4f7542-4e4d-4ac4-979c-598f40574373

push

circleci

web-flow 
Ephemera 2639 v6 (#2716)

* Add chunk_read_url. Update ephemera_folders_iterator

* Update structs with updated EphemeraItem
Looked into mocking the url. discussed with @sandbergja that it would be better to remove the domain from the url
 and read only the id so that we can use a different env path each time for tests and code.

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>

* Add figgy vars in config.toml

Add .vscode in .gitignore

* Make the server url configurable, so that we can pass in a Mockito url

* Rename @id to id in EphemeraItem struct
* Return a vector serialized responses that are ready to POST to solr

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>

* Get one test passing

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>

* Update test_read_ephemera_folders mock server to GET from path.
Set path as a variable and call it in the test.

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>

* Update read_ephemera_folders to read ids and not links with ids
pass str url in ephemera_folders_iterator
Remove std::env::var as it does not set the var.
Improve this in future work.\
pass str url in chunk_read_id
Update test_ephemera_folders_iterator to use a regular expression to mock figgy ids

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>

* update json_ephemera_document to call ephemera_folders_iterator

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>

* made test test_json_ephemera_document_with_no_transliterated_title passing

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Kevin Reiss <kevinreiss@users.noreply.github.com>
Co-authored-by: regineheberlein <regineheberlein@users.noreply.github.com>
Co-authored-by: Ryan Laddusaw <rladdusaw@users.noreply.github.com>

* Add some notes about how to resolve the failing test

Co-authored-by: Christina Chortaria <christinach@users.nore... (continued)

3494 of 3811 relevant lines covered (91.68%)

385.76 hits per line

Jobs
ID Job ID Ran Files Coverage
1 3d4f7542-4e4d-4ac4-979c-598f40574373.1 116
91.68
Source Files on build 3d4f7542-4e4d-4ac4-979c-598f40574373