• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pulibrary / orangelight / f88dec70-741f-4569-827e-f3dc4ca5fe0e
95%
main: 95%

Build:
Build:
LAST BUILD BRANCH: 5240-cas-provider-audit
DEFAULT BRANCH: main
Ran 04 Jun 2025 11:01PM UTC
Jobs 1
Files 199
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

04 Jun 2025 10:55PM UTC coverage: 95.337%. Remained the same
f88dec70-741f-4569-827e-f3dc4ca5fe0e

Pull #4940

circleci

sandbergja
Don't make HTTP requests to bibdata when creating FactoryBot factories

Requests::Patron effectively has a regular mode and an expensive mode
for initializing a new instance.  If you pass a patron_hash, it will
use the data from the hash.  If you don't, though, it will make an
HTTP call to bibdata to get the data.

For some reason, neither WebMock nor VCR seem to catch requests made
in factories!  And several of them were using the expensive initialize
version, making an HTTP call to bibdata-staging, getting "something
went wrong" since they weren't authenticated properly, and returning
no data anyway.  We can skip all that by providing an empty hash.

For me, this reduces the amount of time it takes to run
`bundle exec rspec -t requests` from 56 seconds to 48 seconds.

Helps with pulibrary/dacs_handbook#301
Pull Request #4940: Don't make HTTP requests to bibdata when creating FactoryBot factories

6032 of 6327 relevant lines covered (95.34%)

1516.01 hits per line

Jobs
ID Job ID Ran Files Coverage
1 f88dec70-741f-4569-827e-f3dc4ca5fe0e.1 04 Jun 2025 11:01PM UTC 199
95.34
Source Files on build f88dec70-741f-4569-827e-f3dc4ca5fe0e
  • Tree
  • List 199
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • CircleCI Build #F88DEC70...
  • Pull Request #4940
  • PR Base - main (#62F98D52...)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc