ed1cefda-f43b-4b58-95dd-12a33b7f1f7a

Committed 02 Jul 2025 06:23PM UTC coverage: 96.252% (-3.2%) from 99.494%

Build # ed1cefda-f43b-4b58-95dd-12a33b7f1f7a

Build Type

Pull #381

circleci

Committed by

sandbergja

Commit Message

Refactor RackResponseController so that subclasses don't need to implement #json

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>

Pull Request Pull Request #381: Rewrite DPUL and FindingAids controllers as rack applications

Run Details

29 of 30 new or added lines in 3 files covered. (96.67%)

94 existing lines in 20 files now uncovered.

976 of 1014 relevant lines covered (96.25%)

63.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.67

/app/models/best_bet_document.rb

# frozen_string_literal: true

# This class is responsible for getting relevant
# metadata from the BestBetRecords in the database
# The document is a BestBetRecord
class BestBetDocument < Document
  private

  def title
    document.title
  end

  # Not relevant for this service
  def creator; end

  # TODO: Would it be possible to add this to the sheet? or is it irrelevant?
  def publisher; end

  # TODO: Could we add identifiers to the sheet? Then they would be more likely to stay consistent
  def id
    document.id
  end

  # TODO: Can we add this to the sheet? Or should they all be "Electronic Resource" or similar?
  def type
    'Electronic Resource'
  end

  def description
    document.description
  end

  def url
    document.url
  end

  # No other fields needed at this time
  def other_fields; end
end

1	# frozen_string_literal: true
2
3	# This class is responsible for getting relevant
4	# metadata from the BestBetRecords in the database
5	# The document is a BestBetRecord
6	class BestBetDocument < Document	2✔
7	private	2✔
8
9	def title	2✔
UNCOV 10	document.title	×
11	end
12
13	# Not relevant for this service
14	def creator; end	2✔
15
16	# TODO: Would it be possible to add this to the sheet? or is it irrelevant?
17	def publisher; end	2✔
18
19	# TODO: Could we add identifiers to the sheet? Then they would be more likely to stay consistent
20	def id	2✔
UNCOV 21	document.id	×
22	end
23
24	# TODO: Can we add this to the sheet? Or should they all be "Electronic Resource" or similar?
25	def type	2✔
UNCOV 26	'Electronic Resource'	×
27	end
28
29	def description	2✔
UNCOV 30	document.description	×
31	end
32
33	def url	2✔
UNCOV 34	document.url	×
35	end
36
37	# No other fields needed at this time
38	def other_fields; end	2✔
39	end

pulibrary / allsearch_api / ed1cefda-f43b-4b58-95dd-12a33b7f1f7a

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous