pulibrary / allsearch_api / ed1cefda-f43b-4b58-95dd-12a33b7f1f7a
100%
main: 100%

LAST BUILD BRANCH: replace-all-controllers
DEFAULT BRANCH: main
Ran
Jobs 2
Files 67
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.252% (-3.2%) from 99.494%
ed1cefda-f43b-4b58-95dd-12a33b7f1f7a

Pull #381

circleci

sandbergja 
Refactor RackResponseController so that subclasses don't need to implement #json

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
Pull Request #381: Rewrite DPUL and FindingAids controllers as rack applications

29 of 30 new or added lines in 3 files covered. (96.67%)

94 existing lines in 20 files now uncovered.

976 of 1014 relevant lines covered (96.25%)

63.21 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
96.15
 app/controllers/rack_response_controller.rb

Uncovered Existing Lines

Lines Coverage ∆ File
1
75.0
 -25.0% app/controllers/dpul_controller.rb
1
97.37
 -2.63% app/models/catalog_document.rb
1
96.0
 -4.0% app/models/libanswers.rb
2
50.0
 -50.0% app/controllers/article_controller.rb
2
50.0
 -50.0% app/controllers/best_bet_controller.rb
2
50.0
 -50.0% app/controllers/catalog_controller.rb
2
50.0
 -50.0% app/controllers/library_website_controller.rb
2
85.71
 -14.29% app/models/oauth_token.rb
3
62.5
 -37.5% app/services/best_bet_loading_service.rb
5
72.73
 -22.73% app/models/article.rb
5
66.67
 -33.33% app/models/best_bet_document.rb
5
61.54
 -38.46% app/models/best_bet.rb
5
83.87
 -16.13% app/models/concerns/solr.rb
6
60.0
 -40.0% app/models/dpul.rb
6
60.0
 -40.0% app/models/library_website_document.rb
7
61.11
 -38.89% app/models/dpul_document.rb
7
83.33
 -16.67% app/models/physical_holding.rb
8
38.46
 -61.54% app/models/best_bet_record.rb
11
60.71
 -39.29% app/models/library_website.rb
13
61.76
 -38.24% app/models/article_document.rb
Jobs
ID Job ID Ran Files Coverage
1 ed1cefda-f43b-4b58-95dd-12a33b7f1f7a.1 67
88.36
2 ed1cefda-f43b-4b58-95dd-12a33b7f1f7a.2 67
88.46
Source Files on build ed1cefda-f43b-4b58-95dd-12a33b7f1f7a