pulibrary / orangelight / 68f73718-8b3c-4b64-9464-233d807f755d

95%

main: 95%

Build Type

Pull #5254

circleci

Committed by sandbergja

Commit Message

Refactor: move Requestable creation out of Requests::Form

Prior to this commit, one of the Form class' many
responsibilities was to create many of the
Requestable instances needed by the Requests system.
It created four different kinds of Requestable, and
it was hard to trace the logic throughout the Form
class for each one of those four paths.

This commit takes a different approach: introducing
a factory class named RequestablesList, which
determines what type of Requestable to create,
then delegates the creation to one of four smaller
factories: AlmaItemsFactory, ScsbItemsFactory,
NoItemsFactory, and TooManyItemsFactory.

Pull Request Pull Request #5254: Refactor: move Requestable creation out of Requests::Form

Run Details

160 of 164 new or added lines in 7 files covered. (97.56%)

1 existing line in 1 file now uncovered.

6150 of 6455 relevant lines covered (95.27%)

1498.04 hits per line