pulibrary / bibdata / a520d9ef-2bb9-4a2a-a60c-7fdf8fa3aa5c

90%

main: 89%

Build Type

Pull #2969

circleci

Committed by sandbergja

Commit Message

Remove unnecessary call from bibliographic holding availability endpoint

This affects the endpoint /bibliographic/:bib_id/holdings/:holding_id/availability,
which is used by the Requests form.

Prior to this commit, this endpoint made 2 or more requests to Alma:
* 1 to retrieve the MarcXML record along with requests and general
  availability data
* 1 or more to retrieve the item availability data

The first call was only used to retrieve the bib id -- something that
we already have because the user provided it in the request. Therefore,
we can eliminate this call and save an extra 500-1000ms each time we
load the request form (and be gentler on our API limits).

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
Co-authored-by: Mark Zelesky <mzelesky@users.noreply.github.com>

Pull Request Pull Request #2969: Remove unnecessary call from bibliographic holding availability endpoint

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

9022 of 10050 relevant lines covered (89.77%)

346.2 hits per line