pulibrary / orangelight / 2d9b4e4b-8c4a-4734-bbf2-4a9c46bdef41

95%

main: 95%

Pull #5268

circleci

Improve performance of online_holding_note?

* Rename method for clarity
* Memoize the parsed JSON so that it does not need to
  be parsed again for every field in the catalog
  controller (this is the main performance gain)
* Symbolize names to reduce memory allocations
* Use any? with a block, rather than collect, so we
  don't need to iterate through every holding if we
  get a match before that
* Check in a microbenchmark
* Upgrade the json gem to a newer version that has
  some performance optimizations

Microbenchmark before:
```
$ bundle exec ruby benchmarks/app/controllers/concerns/orangelight/catalog.rb
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
                        36.000 i/100ms
Calculating -------------------------------------
                        363.356 (± 1.4%) i/s    (2.75 ms/i) -      1.836k in   5.053892s
23428 objects allocated
```

Microbenchmark after:
```
Warming up --------------------------------------
                       374.839k i/100ms
Calculating -------------------------------------
                          3.749M (± 0.7%) i/s  (266.76 ns/i) -     18.742M in   4.999956s
2 objects allocated
```

* More iterations/second is good!
* Fewer allocations is good!

6 of 6 new or added lines in 3 files covered. (100.0%)

6142 of 6441 relevant lines covered (95.36%)

1501.8 hits per line