pulibrary / orangelight / bcbb5bc1-bb4e-4673-8f14-c13e799f28e2

95%

push

circleci

Refactor hidden_fields_item helper into its own view component (#5340)

To me, this is much easier to read as HTML+ERB than the previous
implementation (which used string concatenation and Rails form
helpers).  I think that the tests (which now use Nokogiri, rather
than direct string comparison) will be less brittle to changes
like the order of attributes within a tag.

It is also 4x as fast to avoid the Rails form helpers, for what
it's worth (not that this helper was a bottleneck in any way):

Before:
```
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
Requests::ApplicationHelper#hidden_fields_item
                         2.214k i/100ms
Calculating -------------------------------------
Requests::ApplicationHelper#hidden_fields_item
                         22.325k (± 2.1%) i/s   (44.79 μs/i) -    112.914k in   5.060022s
```

After:
```
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
Requests::ItemHiddenFieldsComponent
                         8.453k i/100ms
Calculating -------------------------------------
Requests::ItemHiddenFieldsComponent
                         84.098k (± 1.3%) i/s   (11.89 μs/i) -    422.650k in   5.026524s
```

12 of 12 new or added lines in 1 file covered. (100.0%)

6195 of 6493 relevant lines covered (95.41%)

1467.21 hits per line