MushroomObserver / mushroom-observer / 19621639274

95%

main: 95%

Build Type

Pull #3489

github

Committed by nimmolo

Commit Message

Fix new Phlex email form params in controllers

Most of our forms concern db models. But some of our older forms just send params.

Phlex superforms all need to use a form object - whether it's the database record or a PORO (using ActiveModel), superform wants to validate the object you're creating/updating when you send the form, as it should - this is a sturdier code pattern than validating params individually. The params become attributes of that form object.

So the Phlex conversion has involved creating objects for object-less forms. But claude and i forgot to update the controllers to look for the params nested under these objects. This PR fixes that.

This "form-object" thing is incidentally the same pattern we now use on Search Forms.

Pull Request Pull Request #3489: Next set of Phlex superform components

Run Details

301 of 314 new or added lines in 19 files covered. (95.86%)

8 existing lines in 1 file now uncovered.

30688 of 32243 relevant lines covered (95.18%)

693.21 hits per line