pulibrary / bibdata / 6c1313cb-a5bb-4d73-abbf-ee3975dd384c

90%

Build Type

push

circleci

Committed by web-flow

Commit Message

Re-write call number browse and display in Rust (#3012)

* Re-write call number browse and display in Rust

This is a performance improvement over the original ruby as
measured by this microbenchmark:

```
require 'benchmark/ips'
record = MARC::XMLReader.new('spec/fixtures/marc_to_solr/9939238033506421.mrx').first
marc_breaker = MarcBreaker.break(record)
Benchmark.ips do |x|
  x.report("ruby version") { browse_fields(record, marc_breaker:) }
  x.report("rust version") { BibdataRs::Marc.call_number_labels_for_display(marc_breaker) }
  x.compare!
end
```

...which outputs:

```
ruby 3.4.4 (2025-05-14 revision a38531fd3f) +PRISM [arm64-darwin24]
Warming up --------------------------------------
        ruby version     3.932k i/100ms
        rust version     4.893k i/100ms
Calculating -------------------------------------
        ruby version     39.098k (± 1.5%) i/s   (25.58 μs/i) -    196.600k in   5.029478s
        rust version     50.202k (± 0.4%) i/s   (19.92 μs/i) -    254.436k in   5.068313s

Comparison:
        rust version:    50202.3 i/s
        ruby version:    39098.1 i/s - 1.28x  slower
```

* Add tests and avoid collecting an iterator

Run Details

83 of 105 new or added lines in 2 files covered. (79.05%)

1 existing line in 1 file now uncovered.

9091 of 10147 relevant lines covered (89.59%)

352.14 hits per line