MushroomObserver / mushroom-observer / 22119095372

96%

main: 96%

Pull #3938

github

Convert Translation Edit form to Phlex, Claude 1st draft

New files
 - form_object/translation.rb — Minimal FormObject with tag attribute and persisted? = true (forces PATCH method)
- translation_form.rb — Phlex form component using Pattern B (internal FormObject creation) with FieldProxy for dynamic textareas

Modified files
- edit.erb — Renders Components::TranslationForm instead of the _form partial
- index.erb — Same change for the index page

Key design decisions
- FieldProxy for dynamic fields: The translation form has dynamic textarea fields (tag_#{ttag}) with flat parameter names (not nested under a model namespace). FieldProxy with nil namespace generates the correct flat name="tag_one" attributes that the controller expects
- Pattern B form: The form creates its own FormObject internally since there's no ActiveRecord model backing translation edits
- Official section fix: The original ERB had a silent no-op where render(partial: "translations/official") was inside <% %> (no output). The Phlex component properly renders the official text section above the form for non-official languages
- Boolean attribute gotcha: Phlex renders turbo: true as a boolean HTML attribute (data-turbo) rather than data-turbo="true". Used string "true" to match Rails tag helper behavior that Turbo expects

0 of 232 new or added lines in 2 files covered. (0.0%)

34103 of 35774 relevant lines covered (95.33%)

675.06 hits per line