pulibrary
/
bibdata
/
343632c7-5a85-4d7f-8ef4-0f6379ee98e4
90%
|
Ran
|
Jobs
2
|
Files
199
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 90.522%. Remained the same
push
circleci
web-flowSidekiq pro, sidekiq, connection pool upgrade (#3280) * bundle update connection_pool to 3.0.2 bundle update sidekiq ~> 8.0.10 * This part was moved in pull request https://github.com/pulibrary/bibdata/pull/3281/changes/9c8450db0 In this commit we keep only the require 'sidekiq/api' refactor the helper test method run_all_callbacks zadd - a redis command that adds a member to a sorted set with a numeric score. Redis sorted sets store members in order by their score. Pro 7 — score based when Batch.new was called creation time + expiry: m.zadd("batches", @created_f + expiry, bid) Pro 8 — score based when the jobs block finishes, now + expiry: m.zadd("batches", (Time.now + expiry).to_f, bid) This difference changes to_a ordering only in tests because of the Sidekiq::Testing.inline!: with inline! the jobs calls perform_async which runs the job synchronously. this job calls index_next_dump to_a order in pro7 is [parent,child] <- ZRANGE to_a order in pro8 is [child, parent] <- ZRANGE In pro7 the test assumes that to_a.last is the child because of the ZRANGE. In pro8 the parent will not finish until everything inside the parent block has run. because of the ZRANGE if we use to_a.last the parent will wait for everyhting inside to run then it will run last and the reindex! will call .wipe! and delete the records that were indexed from the child. So in this case to_a.last will call the parent.
11012 of 12165 relevant lines covered (90.52%)
85.66 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 343632c7-5a85-4d7f-8ef4-0f6379ee98e4.1 | 89 |
89.93 |
||
| 2 | 343632c7-5a85-4d7f-8ef4-0f6379ee98e4.2 | 110 |
92.19 |
