zopefoundation / zope.sendmail / 28424609448

99%

push

github

Improve logging in QueueProcessorThread (queue.py) (#72)

* Improve logging in QueueProcessorThread

Include sender, recipients and queue filename on delivery failures and
always attach a traceback via log.exception.

Fixes #71

* Apply pre-commit code formatting

* Fix log calls and update tests

- Avoid passing 'filename' in logging 'extra' (reserved LogRecord
  attribute, raised KeyError at runtime); include sender, recipients
  and queue filename in the message text instead.
- Add 'exception' method to LoggerStub and adapt the queue tests.

* Log data errors via log.error, keep traceback only for unexpected exceptions

Permanent SMTP errors and refused recipients are data problems, not code
errors, so drop the traceback for those and keep log.exception only for
the blanket except handler. Addresses review feedback on #71.

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

125 of 136 branches covered (91.91%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 3 files covered. (100.0%)

1793 of 1793 relevant lines covered (100.0%)

1.0 hits per line